[36688] Set default locale before checking authorization (#9114)

We do set the user's desired (from HTTP headers)
or saved language preference, but that is called after `check_if_login_required`
so in some cases we return before setting localization

https://community.openproject.org/work_packages/36688

app/controllers/application_controller.rb

@@ -131,10 +131,10 @@ class ApplicationController < ActionController::Base
   end
 
   before_action :user_setup,
+                :set_localization,
                 :check_if_login_required,
                 :log_requesting_user,
                 :reset_i18n_fallbacks,
-                :set_localization,
                 :check_session_lifetime,
                 :stop_if_feeds_disabled,
                 :set_cache_buster,
@@ -176,6 +176,7 @@ class ApplicationController < ActionController::Base
   def openproject_cookie_missing?
     request.cookies[OpenProject::Configuration['session_cookie_name']].nil?
   end
+
   helper_method :openproject_cookie_missing?
 
   ##
@@ -336,7 +337,8 @@ class ApplicationController < ActionController::Base
       end
 
       # TODO: Remove this hidden dependency on params
-      instances << (if instances.last.nil?
+      instances << (
+        if instances.last.nil?
           scope_name.camelize.constantize.find(params[:"#{scope_name}_id"])
         else
           instances.last.send(scope_association.to_sym)
@@ -489,17 +491,20 @@ class ApplicationController < ActionController::Base
     I18n.t(label + '_plural',
            default: label.to_sym)
   end
+
   helper_method :default_breadcrumb
 
   def show_local_breadcrumb
     false
   end
+
   helper_method :show_local_breadcrumb
 
   def admin_first_level_menu_entry
     menu_item = admin_menu_item(current_menu_item)
     menu_item.parent
   end
+
   helper_method :admin_first_level_menu_entry
 
   def check_session_lifetime