Rename upload result 'uploads' to 'finished'

frontend/app/components/api/api-v3/hal-resources/work-package-resource.service.test.ts

@@ -243,7 +243,7 @@ describe('WorkPackageResource service', () => {
         uploadFilesDeferred = $q.defer();
         const uploadResult = {
           uploads: [uploadFilesDeferred.promise],
-          upload: uploadFilesDeferred.promise
+          finished: uploadFilesDeferred.promise
         };
         attachmentsUploadStub = sinon.stub(workPackage.attachments, 'upload').returns(uploadResult);
         uploadNotificationStub = sinon.stub(NotificationsService, 'addWorkPackageUpload');

frontend/app/components/api/api-v3/hal-resources/work-package-resource.service.ts

@@ -193,11 +193,11 @@ export class WorkPackageResource extends HalResource {
    * Return an updated AttachmentCollectionResource.
    */
   public uploadAttachments(files: UploadFile[]): IPromise<any> {
-    const {uploads, upload} = this.attachments.upload(files);
+    const {uploads, finished} = this.attachments.upload(files);
     const message = I18n.t('js.label_upload_notification', this);
     const notification = NotificationsService.addWorkPackageUpload(message, uploads);
 
-    return upload
+    return finished
       .then(() => {
         $timeout(() => {
           NotificationsService.remove(notification);

frontend/app/components/api/op-file-upload/op-file-upload.service.test.ts

@@ -85,7 +85,7 @@ describe('opFileUpload service', () => {
     });
 
     it('should return a resolved promise that is the summary of the uploads', () => {
-      expect(result.upload).to.eventually.be.fulfilled;
+      expect(result.finished).to.eventually.be.fulfilled;
     });
   });
 });

frontend/app/components/api/op-file-upload/op-file-upload.service.ts

@@ -36,7 +36,7 @@ export interface UploadFile extends File {
 
 export interface UploadResult {
   uploads: IPromise<any>[];
-  upload: IPromise<any>;
+  finished: IPromise<any>;
 }
 
 export class OpenProjectFileUploadService {
@@ -57,9 +57,9 @@ export class OpenProjectFileUploadService {
         }
       }
     }));
-    const upload = this.$q.all(uploads);
+    const finished = this.$q.all(uploads);
 
-    return {uploads, upload};
+    return {uploads, finished};
   }
 }