Update .travis.yml from devkit [ci skip]

.travis.yml

@@ -26,20 +26,14 @@
 # See doc/COPYRIGHT.rdoc for more details.
 #++
 
-# Travis configuration based on the respective OpenProject core configuration.
-# Everything save for the matrix section and additional `before_install`
-# instructions is copied and pasted from the core.
-
 language: ruby
 
 rvm:
   - 2.4.2
 
-sudo: false
+sudo: required
 dist: trusty
 
-sudo: false
-
 cache:
   bundler: true
   directories:
@@ -55,13 +49,12 @@ env:
   global:
     - CI=true
     - RAILS_ENV=test
+    - GECKODRIVER_VERSION="0.19.1"
 
   matrix:
     - "TEST_SUITE=plugins:specs     DB=mysql    GROUP_SIZE=1 GROUP=1"
     - "TEST_SUITE=plugins:features  DB=mysql    GROUP_SIZE=1 GROUP=1"
-
     - "TEST_SUITE=npm"
-
     - "TEST_SUITE=spec_legacy       DB=mysql"
     - "TEST_SUITE=cucumber          DB=mysql     GROUP_SIZE=1  GROUP=1"
     - "TEST_SUITE=specs             DB=mysql     GROUP_SIZE=4  GROUP=1"
@@ -73,9 +66,10 @@ env:
     - "TEST_SUITE=features          DB=mysql     GROUP_SIZE=4  GROUP=3"
     - "TEST_SUITE=features          DB=mysql     GROUP_SIZE=4  GROUP=4"
 
-before_install:
-  # Custom plugin instructions follow.
 
+
+before_install:
+  ## Custom plugin instructions follow.
   # Move the plugin into a subfolder. The plugin-provided Gemfile.plugins
   # must refer to this folder.
   - mkdir -p plugins/this
@@ -88,18 +82,17 @@ before_install:
   - git fetch --depth=1 openproject
   - git checkout openproject/$TRAVIS_BRANCH
 
-  # End of custom plugin instructions.
   - "echo `firefox -v`"
   - "export DISPLAY=:99.0"
   - "/sbin/start-stop-daemon --start -v --pidfile ./tmp/custom_xvfb_99.pid --make-pidfile --background --exec /usr/bin/Xvfb -- :99 -ac -screen 0 1920x1080x16"
   - "echo `xdpyinfo -display :99 | grep 'dimensions' | awk '{ print $2 }'`"
-
   # Install geckodriver
-  - wget https://github.com/mozilla/geckodriver/releases/download/v0.19.0/geckodriver-v0.19.0-linux64.tar.gz
+  - echo "Installing geckodriver ${GECKODRIVER_VERSION}"
+  - wget https://github.com/mozilla/geckodriver/releases/download/v${GECKODRIVER_VERSION}/geckodriver-v${GECKODRIVER_VERSION}-linux64.tar.gz
   - mkdir geckodriver
-  - tar -xzf geckodriver-v0.19.0-linux64.tar.gz -C geckodriver
+  - tar -xzf geckodriver-v${GECKODRIVER_VERSION}-linux64.tar.gz -C geckodriver
   - export PATH=$PATH:$PWD/geckodriver
-
+  - echo `geckodriver --version`
   # Install Node LTS Boron (6.9.1)
   - "nvm install 6.9.1"
 
@@ -126,5 +119,8 @@ notifications:
       - secure: "dkVCNYSedLfeuqTboRPx/iWmXldhoHZpSp83cpkG6ZL81Psut2ZEHg6aBiWgqQWdfNAca4a51hWXs6utRqdgnxo51YAB/pMy0/b+jEOjZvuShOVz6TVqn5W5JLTNZJeVZL+BgvwXZWbIujH/cSuUv+h7GTnS+8Y4b2ZrCYilP35sAck2bbbAsKzbuW2yZZqK7X0UnSjoxg+KeT9DuK1zjjJJ6CZig1/n5ZjciQIv7JD50hmqFxBgjyBi71Loh/iohUF89EoQRXm0KkSmEhCINld5s+7SP4jSmnqyrNamNNw2ZGCgg3OXhcvDqOHjPwpCNNhrtzTExt/Z2cTzHz4FnV9ncJj9i1pkbjveuudVUTeaSHHXjw/X496OKLP3LwEZYggUCyc3nu9qR2zSs6zdG4ijhclOVzNrXDDixjpYGmOg8mVunG2cwFUSjtmX8nyPNXQvRnvsfnVYalprqXJHGmQW07nFE/2lbjdmnQiCEExNsKXO5vqrqo6RYOtTfka9B5s3ZkTkXgZkTWuEgWbaMC/fZhi0NCu2Ow3XOzQrs8hVLF4w1zngjqOLjk+LftqWwT42D47RKW3SZfVEVm8Vw+JGfh/uJUNAsPsu+Mybw8k0aDmLjPTlRZD+dYvQ2EPizgc2+cf+0GVoaGzKZF+cJ8I0ut8kO13M9ZmjiHU0se4="
 
 addons:
-  firefox: "45.0esr"
-  postgresql: "9.3"
+  # Setting latest here due to the switch from old selenium bindings
+  # to Marionette. At the date of this writing, ESR is Firefox 52 and has
+  # bad support for it. Thus we use latest (57.0 as of this writing)
+  firefox: "latest"
+  postgresql: "9.6"