Add BCF comments to factories

modules/bcf/spec/bcf/bcf_xml/issue_reader_spec.rb

@@ -108,7 +108,24 @@ describe ::OpenProject::Bcf::BcfXml::IssueReader do
     let(:bcf_issue) { subject.extract! }
 
     it 'WP start date gets initialized with BCF CreationDate' do
-      expect(bcf_issue.work_package.start_date).to eql(subject.extractor.creation_date)
+      expect(bcf_issue.work_package.start_date).to eql(subject.extractor.creation_date.to_date)
+    end
+  end
+
+  context 'on updating import' do
+    context '#update_comment' do
+      let(:bcf_issue) { FactoryBot.create :bcf_issue_with_comment}
+
+      it '#update_comment' do
+        allow(subject).to receive(:issue).and_return(bcf_issue)
+
+        modified_time = Time.iso8601('2019-07-11T12:00:00Z')
+        comment_data = { uuid: bcf_issue.comments.first.uuid, comment: 'Updated comment', modified_date: modified_time }
+        subject.send(:update_comment, comment_data)
+
+        expect(bcf_issue.comments.first.journal.notes).to eql('Updated comment')
+        expect(bcf_issue.comments.first.journal.created_at).to eql(modified_time)
+      end
     end
   end
 end

modules/bcf/spec/factories/bcf_comment_factory.rb

@@ -0,0 +1,45 @@
+#-- copyright
+# OpenProject Backlogs Plugin
+#
+# Copyright (C)2013-2014 the OpenProject Foundation (OPF)
+# Copyright (C)2011 Stephan Eckardt, Tim Felgentreff, Marnen Laibow-Koser, Sandro Munda
+# Copyright (C)2010-2011 friflaj
+# Copyright (C)2010 Maxime Guilbot, Andrew Vit, Joakim Kolsjö, ibussieres, Daniel Passos, Jason Vasquez, jpic, Emiliano Heyns
+# Copyright (C)2009-2010 Mark Maglana
+# Copyright (C)2009 Joe Heck, Nate Lowrie
+#
+# This program is free software; you can redistribute it and/or modify it under
+# the terms of the GNU General Public License version 3.
+#
+# OpenProject Backlogs is a derivative work based on ChiliProject Backlogs.
+# The copyright follows:
+# Copyright (C) 2010-2011 - Emiliano Heyns, Mark Maglana, friflaj
+# Copyright (C) 2011 - Jens Ulferts, Gregor Schmidt - Finn GmbH - Berlin, Germany
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See doc/COPYRIGHT.rdoc for more details.
+#++
+
+FactoryBot.define do
+  factory :bcf_comment, class: ::Bcf::Comment do
+    after(:create) do |bcf_comment|
+      bcf_comment.journal = create(:work_package_journal)
+      bcf_comment.journal.update_attribute(:notes, 'Some BCF comment.')
+      bcf_comment.journal.save
+      bcf_comment.save
+    end
+  end
+end

modules/bcf/spec/factories/bcf_issue_factory.rb

@@ -35,8 +35,11 @@
 
 FactoryBot.define do
   factory :bcf_issue, class: ::Bcf::Issue do
-    after(:create) do |issue|
+    factory :bcf_issue_with_comment do
-      create(:bcf_viewpoint, issue: issue)
+      after(:create) do |issue|
+        create(:bcf_viewpoint, issue: issue)
+        create(:bcf_comment, issue: issue)
+      end
     end
   end
 end