Revert "Also check for query props that are now null"

Not actually needed since checksum was identical except for operator
pull/6346/head
Oliver Günther 6 years ago
parent 5c4baf1094
commit d8eddc272e
No known key found for this signature in database
GPG Key ID: 88872239EB414F99
  1. 14
      frontend/src/app/components/wp-list/wp-list-checksum.service.ts
  2. 1
      frontend/src/app/modules/common/op-date-picker/op-date-picker.component.ts

@ -30,7 +30,7 @@ import {QueryResource} from 'core-app/modules/hal/resources/query-resource';
import {WorkPackageTablePagination} from '../wp-fast-table/wp-table-pagination'; import {WorkPackageTablePagination} from '../wp-fast-table/wp-table-pagination';
import {StateService} from '@uirouter/core'; import {StateService} from '@uirouter/core';
import {UrlParamsHelperService} from 'core-components/wp-query/url-params-helper'; import {UrlParamsHelperService} from 'core-components/wp-query/url-params-helper';
import {Inject, Injectable} from '@angular/core'; import {Injectable} from '@angular/core';
@Injectable() @Injectable()
export class WorkPackagesListChecksumService { export class WorkPackagesListChecksumService {
@ -94,7 +94,7 @@ export class WorkPackagesListChecksumService {
} }
} }
private set(id:number | null, checksum:string|null) { private set(id:number | null, checksum:string) {
this.id = id; this.id = id;
this.checksum = checksum; this.checksum = checksum;
} }
@ -131,14 +131,8 @@ export class WorkPackagesListChecksumService {
( (
// Query ID changed // Query ID changed
idChanged || idChanged ||
// Query ID same // Query ID same + query props changed
(!idChanged && checksumChanged && (!idChanged && checksumChanged && (otherChecksum || this.visibleChecksum)) ||
(
// + query props are now unset
(!otherChecksum && hasCurrentChecksum) ||
// + query props changed
(otherChecksum || this.visibleChecksum)
)) ||
// No query ID set // No query ID set
(!hasCurrentQueryID && visibleChecksumChanged) (!hasCurrentQueryID && visibleChecksumChanged)
) )

@ -109,6 +109,7 @@ export class OpDatePickerComponent implements OnInit {
initialValue, initialValue,
options options
); );
this.datePickerInstance.show(); this.datePickerInstance.show();
} }
} }

Loading…
Cancel
Save