Load attachments only if the work package has any (#4561)

frontend/app/components/work-packages/wp-attachments/wp-attachments.directive.ts

@@ -27,20 +27,20 @@
 //++
 
 import {wpDirectivesModule} from '../../../angular-modules';
-import {WpAttachmentsService} from './wp-attachments.service'
+import {WpAttachmentsService} from './wp-attachments.service';
 
 export class WorkPackageAttachmentsController {
   public workPackage:any;
 
-  public attachments: Array = [];
+  public attachments:any[] = [];
   public fetchingConfiguration:boolean = false;
-  public files: Array<File> = [];
+  public files:File[] = [];
   public hasRightToUpload:boolean = false;
   public I18n:any;
   public loading:boolean = false;
-  public rejectedFiles: Array = [];
+  public rejectedFiles:any[] = [];
 
-  public settings: Object = {
+  public settings = {
     maximumFileSize: Number
   };
 
@@ -49,14 +49,14 @@ export class WorkPackageAttachmentsController{
   private currentlyFocussing;
   private editMode:boolean;
 
-  constructor(protected $scope: ng.IScope,
+  constructor(protected $scope:any,
               protected $element:ng.IAugmentedJQuery,
               protected $attrs:ng.IAttributes,
               protected wpAttachments:WpAttachmentsService,
-              protected NotificationsService: ng.IServiceProvider,
+              protected NotificationsService:any,
               protected I18n:any,
-              protected ConfigurationService: ng.IServiceProviderFactory,
+              protected ConfigurationService:any,
-              protected ConversionService: ng.IServiceProvider){
+              protected ConversionService:any) {
 
     this.attachments = this.wpAttachments.getCurrentAttachments();
     this.editMode = $attrs.hasOwnProperty('edit');
@@ -70,7 +70,7 @@ export class WorkPackageAttachmentsController{
       this.fetchingConfiguration = false;
     });
 
-    if(angular.isDefined(this.workPackage)) {
+    if (this.workPackage && this.workPackage.attachments) {
       this.loadAttachments();
     }
 
@@ -104,8 +104,7 @@ export class WorkPackageAttachmentsController{
   public remove(file):void {
     if (this.workPackage.isNew) {
       _.remove(this.wpAttachments.attachments, file);
-    }
+    } else {
-    else{
       this.wpAttachments.remove(file);
     }
   };
@@ -129,10 +128,8 @@ export class WorkPackageAttachmentsController{
 
   public uploadFilteredFiles(files):void {
     this.filterFiles(files);
-    this.upload()
+    this.upload();
   }
-
-
 }
 
 function wpAttachmentsDirective():ng.IDirective {
@@ -148,12 +145,11 @@ function wpAttachmentsDirective(): ng.IDirective {
     templateUrl: (element:ng.IAugmentedJQuery, attrs:ng.IAttributes):string => {
       if (attrs.hasOwnProperty('edit')) {
         return '/components/work-packages/wp-attachments/wp-attachments-edit.directive.html';
-        }
+      } else {
-        else {
         return '/components/work-packages/wp-attachments/wp-attachments.directive.html';
       }
     }
-  }
+  };
 }
 
 wpDirectivesModule.directive('wpAttachments', wpAttachmentsDirective);