replace user manual registration cukes (#6267)

[ci skip]

features/users/user_activation.feature

@@ -1,62 +0,0 @@
-#-- copyright
-# OpenProject is a project management system.
-# Copyright (C) 2012-2018 the OpenProject Foundation (OPF)
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License version 3.
-#
-# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
-# Copyright (C) 2006-2017 Jean-Philippe Lang
-# Copyright (C) 2010-2013 the ChiliProject Team
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; either version 2
-# of the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-#
-# See docs/COPYRIGHT.rdoc for more details.
-#++
-
-Feature:User Activation
-
-@javascript
-Scenario: An admin could activate the pending registration request
-
-Given I open the registration modal
-And I fill in "user_login" with "heidi"
-And I fill in "user_password" with "test123=321test"
-And I fill in "user_password_confirmation" with "test123=321test"
-And I fill in "user_firstname" with "Heidi"
-And I fill in "user_lastname" with "Swiss"
-And I fill in "user_mail" with "heidi@heidiland.com"
-And I click on "Create" within ".registration-modal"
-Then I should see "Your account was created and is now pending administrator approval"
-And I am admin
-And I am on the admin page of pending users
-Then I should see "heidi" within ".generic-table"
-
-@javascript
-Scenario: An admin activates the pending registration request
-
-Given I open the registration modal
-And I fill in "user_login" with "heidi"
-And I fill in "user_password" with "test123=321test"
-And I fill in "user_password_confirmation" with "test123=321test"
-And I fill in "user_firstname" with "Heidi"
-And I fill in "user_lastname" with "Swiss"
-And I fill in "user_mail" with "heidi@heidiland.com"
-And I click on "Create" within ".registration-modal"
-Then I should see "Your account was created and is now pending administrator approval"
-And I am already admin
-And I am on the admin page of pending users
-When I follow "Activate" within ".generic-table"
-Then I should see "Successful update"

features/users/user_registration.feature

@@ -1,64 +0,0 @@
-#-- copyright
-# OpenProject is a project management system.
-# Copyright (C) 2012-2018 the OpenProject Foundation (OPF)
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License version 3.
-#
-# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
-# Copyright (C) 2006-2017 Jean-Philippe Lang
-# Copyright (C) 2010-2013 the ChiliProject Team
-#
-# This program is free software; you can redistribute it and/or
-# modify it under the terms of the GNU General Public License
-# as published by the Free Software Foundation; either version 2
-# of the License, or (at your option) any later version.
-#
-# This program is distributed in the hope that it will be useful,
-# but WITHOUT ANY WARRANTY; without even the implied warranty of
-# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-# GNU General Public License for more details.
-#
-# You should have received a copy of the GNU General Public License
-# along with this program; if not, write to the Free Software
-# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
-#
-# See docs/COPYRIGHT.rdoc for more details.
-#++
-
-Feature: User Registration
-
-@javascript
-Scenario: A user can register successfully after filling in the registration form
-Given I open the registration modal
-And I fill in "user_login" with "heidi"
-And I fill in "user_password" with "test123456T?"
-And I fill in "user_password_confirmation" with "test123456T?"
-And I fill in "user_firstname" with "Heidi"
-And I fill in "user_lastname" with "Swiss"
-And I fill in "user_mail" with "heidi@test.com"
-And I click on "Create" within ".registration-modal"
-Then I should see "Your account was created and is now pending administrator approval."
-
-@javascript
-Scenario: A user is unable to register if one of the constraints left blank
-Given I open the registration modal
-And I fill in "user_login" with "heidi"
-And I fill in "user_password" with "test123456T?"
-And I fill in "user_password_confirmation" with "test123456T?"
-And I fill in "user_firstname" with "Heidi"
-And I fill in "user_lastname" with "Swiss"
-And I click on "Create" within ".registration-modal"
-Then the element "#user_mail" should be invalid
-
-@javascript
-Scenario: A user is unable to register if the password does not match the confirmation
-Given I open the registration modal
-And I fill in "user_login" with "heidi"
-And I fill in "user_password" with "test123456T?"
-And I fill in "user_password_confirmation" with "test1"
-And I fill in "user_firstname" with "Heidi"
-And I fill in "user_lastname" with "Swiss"
-And I fill in "user_mail" with "heidi@test.com"
-And I click on "Create" within ".registration-modal"
-Then I should see "Confirmation doesn't match Password"

spec/features/users/self_registration_spec.rb

@@ -0,0 +1,114 @@
+#-- copyright
+# OpenProject is a project management system.
+# Copyright (C) 2012-2018 the OpenProject Foundation (OPF)
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2017 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See docs/COPYRIGHT.rdoc for more details.
+#++
+
+require 'spec_helper'
+
+describe 'user self registration', type: :feature, js: true do
+  let(:admin) { FactoryGirl.create :admin, password: 'Test123Test123', password_confirmation: 'Test123Test123' }
+  let(:home_page) { Pages::Home.new }
+
+  context 'with "manual account activation"' do
+    before do
+      allow(Setting)
+        .to receive(:self_registration?)
+        .and_return true
+    end
+
+    it 'allows self registration and activation by an admin' do
+      home_page.visit!
+
+      # registration as an anonymous user
+      within '.top-menu-items-right .menu_root' do
+        click_link 'Sign in'
+
+        # Wait until click handler has been initialized
+        sleep(0.1)
+
+        click_link 'Create a new account'
+      end
+
+      # deliberately inserting a wrong password confirmation
+      within '.registration-modal' do
+        fill_in 'Login', with: 'heidi'
+        fill_in 'First name', with: 'Heidi'
+        fill_in 'Last name', with: 'Switzerland'
+        fill_in 'Email', with: 'heidi@heidiland.com'
+        fill_in 'Password', with: 'test123=321test'
+        fill_in 'Confirmation', with: 'something different'
+
+        click_button 'Create'
+      end
+
+      expect(page)
+        .to have_content('Confirmation doesn\'t match Password')
+
+      # correcting password
+      within '.registration-modal' do
+        # Cannot use 'Password' here as the error message on 'Confirmation' is part of the label
+        # and contains the string 'Password' as well
+        fill_in 'user_password', with: 'test123=321test'
+        fill_in 'Confirmation', with: 'test123=321test'
+
+        click_button 'Create'
+      end
+
+      expect(page)
+        .to have_content('Your account was created and is now pending administrator approval.')
+
+      registered_user = User.find_by(status: Principal::STATUSES[:registered])
+
+      # Trying unsuccessfully to login
+      login_with 'heidi', 'test123=321test'
+
+      expect(page)
+        .to have_content I18n.t(:'account.error_inactive_manual_activation')
+
+      # activation as admin
+      login_with admin.login, admin.password
+
+      user_page = Pages::Admin::User.new(registered_user.id)
+
+      user_page.visit!
+
+      user_page.activate!
+
+      expect(page)
+        .to have_content('Successful update.')
+
+      logout
+
+      # Test logging in as newly created and activated user
+      login_with 'heidi', 'test123=321test'
+
+      within '.top-menu-items-right .menu_root' do
+        expect(page)
+          .to have_selector("a[title='#{registered_user.name}']")
+      end
+    end
+  end
+end

spec/support/authentication_helpers.rb

@@ -49,6 +49,10 @@ module AuthenticationHelpers
       click_button I18n.t(:button_login)
     end
   end
+
+  def logout
+    visit signout_path
+  end
 end
 
 RSpec.configure do |config|

spec/support/pages/admin/user.rb

@@ -102,6 +102,12 @@ module Pages
       def select_project!(project_name)
         select(project_name, from: 'membership_project_id')
       end
+
+      def activate!
+        within '.toolbar-items' do
+          click_button 'Activate'
+        end
+      end
     end
   end
 end

spec/support/pages/home.rb

@@ -0,0 +1,37 @@
+#-- copyright
+# OpenProject is a project management system.
+# Copyright (C) 2012-2018 the OpenProject Foundation (OPF)
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2017 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See docs/COPYRIGHT.rdoc for more details.
+#++
+
+require 'support/pages/page'
+
+module Pages
+  class Home < Page
+    def path
+      "/"
+    end
+  end
+end

spec/support/pages/page.rb

@@ -26,7 +26,6 @@
 # See docs/COPYRIGHT.rdoc for more details.
 #++
 
-
 module Pages
   class Page
     include Capybara::DSL