Fix new work package creation form post

frontend/src/app/shared/components/datepicker/multi-date-modal/multi-date.modal.ts

@@ -203,6 +203,7 @@ export class MultiDateModalComponent extends OpModalComponent implements AfterVi
         this.handleDatePickerChange(field, castArray(update));
       }
 
+      this.onDataChange();
       this.cdRef.detectChanges();
     });
 
@@ -237,7 +238,7 @@ export class MultiDateModalComponent extends OpModalComponent implements AfterVi
       switchMap((fieldsToUpdate:FieldUpdates) => this
         .apiV3Service
         .work_packages
-        .id(this.changeset.id)
+        .withOptionalId(this.changeset.id === 'new' ? null : this.changeset.id)
         .form
         .forPayload({
           ...fieldsToUpdate,
@@ -498,6 +499,7 @@ export class MultiDateModalComponent extends OpModalComponent implements AfterVi
 
     const dates = [startDate, endDate];
     setDates(dates, this.datePickerInstance, enforceDate);
+    this.onDataChange();
   }
 
   private handleDatePickerChange(activeField:DateFields, dates:Date[]) {

spec/features/work_packages/new/new_work_package_datepicker_spec.rb

@@ -35,12 +35,13 @@ require 'features/work_packages/work_packages_page'
 
 describe 'New work package datepicker',
          with_settings: { date_format: '%Y-%m-%d' },
+         with_flag: { work_packages_duration_field_active: true },
          js: true, selenium: true do
   let(:project) { create :project_with_types, public: true }
   let(:user) { create :admin }
 
   let(:wp_page_create) { Pages::FullWorkPackageCreate.new(project:) }
-  let(:start_date) { wp_page_create.edit_field(:combinedDate) }
+  let(:date_field) { wp_page_create.edit_field(:combinedDate) }
 
   before do
     login_as(user)
@@ -49,18 +50,21 @@ describe 'New work package datepicker',
   end
 
   it 'can open and select the datepicker' do
-    start_date.input_element.click
+    date_field.input_element.click
+    date_field.ignore_non_working_days true
 
     start = (Time.zone.today - 1.day).iso8601
-    start_date.activate_start_date_within_modal
+    date_field.focus_start_date
-    start_date.datepicker.set_date start, true
+    date_field.set_active_date start
 
     due = (Time.zone.today + 1.day).iso8601
-    start_date.activate_due_date_within_modal
+    date_field.focus_due_date
-    start_date.datepicker.set_date due, true
+    date_field.set_active_date due
 
-    start_date.save!
+    date_field.expect_duration 3
-    start_date.expect_inactive!
+
-    start_date.expect_value "#{start} - #{due}"
+    date_field.save!
+    date_field.expect_inactive!
+    date_field.expect_value "#{start} - #{due}"
   end
 end

spec/support/edit_fields/date_edit_field.rb

@@ -18,7 +18,15 @@ class DateEditField < EditField
     @datepicker ||= ::Components::WorkPackageDatepicker.new modal_selector
   end
 
-  delegate :expect_duration, :set_duration, to: :datepicker
+  delegate :set_start_date,
+           :set_due_date,
+           :focus_start_date,
+           :focus_due_date,
+           :expect_start_highlighted,
+           :expect_due_highlighted,
+           :expect_duration,
+           :set_duration,
+           :ignore_non_working_days, to: :datepicker
 
   def modal_selector
     '[data-qa-selector="op-datepicker-modal"]'
@@ -117,7 +125,7 @@ class DateEditField < EditField
         datepicker.set_start_date value.first
         datepicker.set_due_date value.last
       else
-        select_value value
+        set_active_date value
       end
 
       save! if save
@@ -135,7 +143,7 @@ class DateEditField < EditField
     expect(input_element.value).to eq(value)
   end
 
-  def select_value(value)
+  def set_active_date(value)
     datepicker.set_date value
   end