@ -1,6 +1,5 @@
require_relative '../spec_helper' require_relative '../spec_helper'
# rubocop:disable RSpec/NestedGroups
describe :: OpenProject :: TwoFactorAuthentication :: TokenStrategyManager do describe :: OpenProject :: TwoFactorAuthentication :: TokenStrategyManager do
let ( :dev_strategy ) { :: OpenProject :: TwoFactorAuthentication :: TokenStrategy :: Developer } let ( :dev_strategy ) { :: OpenProject :: TwoFactorAuthentication :: TokenStrategy :: Developer }
let ( :totp_strategy ) { :: OpenProject :: TwoFactorAuthentication :: TokenStrategy :: Totp } let ( :totp_strategy ) { :: OpenProject :: TwoFactorAuthentication :: TokenStrategy :: Totp }
@ -12,129 +11,110 @@ describe ::OpenProject::TwoFactorAuthentication::TokenStrategyManager do
end end
let ( :enforced ) { false } let ( :enforced ) { false }
context 'without EE' do include_context 'with settings' do
include_context 'with settings' do let ( :settings ) do
let ( :settings ) do {
{ plugin_openproject_two_factor_authentication : configuration
plugin_openproject_two_factor_authentication : { }
'active_strategies' = > % i [ developer ]
}
}
end
end
it 'is not enabled' do
expect ( described_class ) . not_to be_enabled
end end
end end
context 'with EE' , with_2fa_ee : true do describe '#find_matching_strategy' do
include_context 'with settings' do subject { described_class . find_matching_strategy ( :sms ) }
let ( :settings ) do
{
plugin_openproject_two_factor_authentication : configuration
}
end
end
describe '#find_matching_strategy' do
subject { described_class . find_matching_strategy ( :sms ) }
context 'when no strategy is set' do context 'when no strategy is set' do
let ( :active_strategies ) { [ ] } let ( :active_strategies ) { [ ] }
it 'returns nil' do it 'returns nil' do
expect ( subject ) . to be_nil expect ( subject ) . to be_nil
end
end end
end
context 'when matching strategy exists' do context 'when matching strategy exists' do
let ( :active_strategies ) { [ :developer ] } let ( :active_strategies ) { [ :developer ] }
it 'returns the strategy' do it 'returns the strategy' do
expect ( subject ) . to eq ( dev_strategy ) expect ( subject ) . to eq ( dev_strategy )
end
end end
end
context 'when non-matching strategy exists' do context 'when non-matching strategy exists' do
let ( :active_strategies ) { [ :totp ] } let ( :active_strategies ) { [ :totp ] }
it 'returns the strategy' do it 'returns the strategy' do
expect ( subject ) . to be_nil expect ( subject ) . to be_nil
end
end end
end end
end
describe '#active_strategies' do describe '#active_strategies' do
context 'with bogus strategy' do context 'with bogus strategy' do
let ( :active_strategies ) { [ :doesnotexist ] } let ( :active_strategies ) { [ :doesnotexist ] }
it 'raises when accessing' do it 'raises when accessing' do
expect { described_class . active_strategies } . to raise_error ( ArgumentError ) expect { described_class . active_strategies } . to raise_error ( ArgumentError )
end end
it 'raises when validating' do it 'raises when validating' do
expect { described_class . validate_active_strategies! } . to raise_error ( ArgumentError ) expect { described_class . validate_active_strategies! } . to raise_error ( ArgumentError )
end
end end
end end
end
describe '#validate_active_strategies!' do describe '#validate_active_strategies!' do
subject { described_class . validate_active_strategies! } subject { described_class . validate_active_strategies! }
context 'when no strategy is set' do context 'when no strategy is set' do
let ( :active_strategies ) { [ ] } let ( :active_strategies ) { [ ] }
before do before do
allow ( OpenProject :: TwoFactorAuthentication :: TokenStrategyManager ) allow ( OpenProject :: TwoFactorAuthentication :: TokenStrategyManager )
. to receive ( :add_default_strategy? ) . to receive ( :add_default_strategy? )
. and_return false . and_return false
end end
context 'when enforced is false' do context 'when enforced is false' do
let ( :enforced ) { false } let ( :enforced ) { false }
it 'accepts that' do it 'accepts that' do
expect { subject } . not_to raise_error expect { subject } . not_to raise_error
expect ( described_class ) . not_to be_enabled expect ( described_class ) . not_to be_enabled
expect ( described_class ) . not_to be_enforced expect ( described_class ) . not_to be_enforced
end
end end
end
context 'when enforced is true' do context 'when enforced is true' do
let ( :enforced ) { true } let ( :enforced ) { true }
it 'raises and error that a strategy is needed' do it 'raises and error that a strategy is needed' do
expect { subject } . to raise_error ( ArgumentError ) expect { subject } . to raise_error ( ArgumentError )
expect ( described_class ) . not_to be_enabled expect ( described_class ) . not_to be_enabled
expect ( described_class ) . to be_enforced expect ( described_class ) . to be_enforced
end
end end
end end
end
context 'when a strategy is set' do context 'when a strategy is set' do
let ( :active_strategies ) { [ :developer ] } let ( :active_strategies ) { [ :developer ] }
context 'when it is valid' do context 'when it is valid' do
it 'returns that' do it 'returns that' do
expect { subject } . not_to raise_error expect { subject } . not_to raise_error
expect ( described_class . active_strategies ) . to eq ( [ dev_strategy ] ) expect ( described_class . active_strategies ) . to eq ( [ dev_strategy ] )
expect ( described_class ) . to be_enabled expect ( described_class ) . to be_enabled
expect ( described_class ) . not_to be_enforced expect ( described_class ) . not_to be_enforced
end
end end
end
context 'when it is invalid' do context 'when it is invalid' do
it 'raises' do it 'raises' do
allow ( dev_strategy ) . to receive ( :validate! ) . and_raise 'Error!' allow ( dev_strategy ) . to receive ( :validate! ) . and_raise 'Error!'
expect { subject } . to raise_error 'Error!' expect { subject } . to raise_error 'Error!'
expect ( described_class ) . to be_enabled expect ( described_class ) . to be_enabled
expect ( described_class ) . not_to be_enforced expect ( described_class ) . not_to be_enforced
end
end end
end end
end end
end end
end end
# rubocop:enable RSpec/NestedGroups
Oliver Günther
2 years ago