217 Commits (dev)

Author	SHA1	Message	Date
Christophe Bliard	10085736da	refactor: Rename and generalize #accessor_name as #attribute_name ... Also extract #attribute_getter and #attribute_setter when using #attribute_name in the context of calling the getter/setter methods.	2 years ago
Christophe Bliard	85b3258a29	Autocorrect with some rubocop cops ... RSpec/Rails/InferredSpecType and Style/RedundantConstantBase rubocop --autocorrect-all --only RSpec/Rails/InferredSpecType,Style/RedundantConstantBase spec modules/*/spec	2 years ago
Christophe Bliard	5cf125a6f9	[#3897] Add specific permission archive_project ... See https://community.openproject.org/work_packages/3897 This permission is automatically added to project admin role. A project can be archived by a user if this user has the archive_project permission on the project and all its descendants.	2 years ago
Christophe Bliard	21a696ef9b	Update copyright information for 2023	2 years ago
Dombi Attila	1691077d44	[Fix] Create rake task to fix missing notification settings (#11362) ... * Create rake task to fix missing notification settings * fixup! Create rake task to fix missing notification settings * Test whether users being created without settings	2 years ago
Behrokh Satarnejad	c051eb5174	[44955] Re-think and harmonize Enterprise Edition vs Enterprise edition (#11694) ... * change Edition to edition in strings * use add-on instead of feature * replace premium with enterprise * Change Edition to edition in readme files * change feature to add-on	2 years ago
Dombi Attila	b28c088a54	[#44673] Editing custom fields on work packages in readonly status possible via bulk edit ... https://community.openproject.org/work_packages/44673	2 years ago
Dombi Attila	d349c30d7e	[#44414] Add the Enterprise Edition guard on date alerts settings ... https://community.openproject.org/work_packages/44414	2 years ago
Dmitrii	57eb0a930e	make everyday for overdue as P1D	2 years ago
Dmitrii	ce8a4e973b	fix failing specs and do not allow 1 day for overdue	2 years ago
Christophe Bliard	75f272504a	Change NotificationSettings duration units to days ... Days are easier to work with than hours when building SQL requests. Also change "everyday" value for overdue from 0 to 1, for consistency with the other values.	2 years ago
Oliver Günther	7b82097ef8	Adapt token creation with added foreign key constraint	2 years ago
Dombi Attila	2868748ce6	Fix spec descriptions	2 years ago
Dmitrii	00a0d42ed1	[#43673] fixes after comments	2 years ago
Dmitrii	ac1d98ea03	[#43673] move validation to contract	2 years ago
ulferts	81d52906d7	bail on altering working days before last change is processed	2 years ago
Dombi Attila	bb107a7223	[#43819] Basic administration for non working days (excluding danger zone) ... https://community.openproject.org/work_packages/43819 WorkingDays as Setting	2 years ago
ulferts	7be7ede6b5	restrict writability of ignore_non_working_days if parent	2 years ago
Christophe Bliard	9ac8cd6112	fixup! Refactor: rename factory week_days	2 years ago
Christophe Bliard	4e2dd77892	Refactor: rename factory week_days	2 years ago
Oliver Günther	a6b7bee822	Cleanup code for duration / non working days (#11222) ... * Remove work_packages_duration_field_active feature flag Duration is now globally active for 12.3.0. * Remove `ignore_non_working_days: false` in tests Not needed anymore as it is now the default value. Keep it where the test explicitly refers to it, for clarity. Co-authored-by: Christophe Bliard <c.bliard@openproject.com>	2 years ago
ulferts	17d9388bb8	robustness upon an invalid wp parent_id	2 years ago
Dombi Attila	a519ba0c72	Change default for ignore_non_working_days on work packages	2 years ago
Christophe Bliard	469474efbe	Return validation error if duration does not match	2 years ago
Christophe Bliard	0cf2ffedb9	Forbid having only 2 duration/dates fields set ... As per OP#31992, for start date, finish date, and duration, it is possible to have no attributes, only one attribute, or all three. It is not possible to have just two (since the third will be derived from the other two).	2 years ago
bsatarnejad	7044ddb842	remove the attribute name and colon to make it consistant with other error texts	2 years ago
bsatarnejad	9bb7708e2b	adjust test with the changes into error text	2 years ago
Christophe Bliard	38e65b8cc0	[#43223] Forbid to set due date before soonest_start ... https://community.openproject.org/work_packages/43223 Before, only start_date was checked to be after soonest_start. Now both are checked in case start_date is unset.	2 years ago
Oliver Günther	8fa841c9c2	Prevent uncontainered attachments being added due to public permissions ... If there is an anonymous role to view_project, there are two attachable instances (Grids::MyPage, Projects::Export) that allow anonymous attaching of uncontainered attachments. This has the consequence that anon users can upload uncontainered attachments when this role is set. This PR fixes this by preventing these classes from getting uncontainered attachments, as they are only necessary for resources created through the frontend (projects, work packages).	2 years ago
Dombi Attila	8124a3705a	Move duration for milestone validations to the base contract	2 years ago
ulferts	122b56332e	let writability of duration and ignore_non_working_days be govered by feature flag	3 years ago
ulferts	a82fa93a70	add ignore flag to work package contracts but hide from form configuration	3 years ago
Christophe Bliard	c6e44141db	Remove :stubbed_work_package factory ... Using build_stubbed(:work_package) works equally well. Relates to commit e1607a6116	3 years ago
Christophe Bliard	48a4f1b6ad	lint with rubocop --autocorrect (safe cops only)	3 years ago
Christophe Bliard	90a8329c3a	fix i18n keys for duration	3 years ago
ulferts	f5fc2b9c59	ensure duration to be integer	3 years ago
Frank Bergmann	c84980b257	Improve flow and guidance for setting up a file storage	3 years ago
ulferts	89eae6714c	include duration in contract	3 years ago
ulferts	ccf1c2de0e	linting	3 years ago
luz paz	9e22d420db	Fix typos ... Found via `codespell -q 3 -S ./config/locales,./modules/xls_export/config/locales,./modules/job_status/config/locales,./modules/two_factor_authentication/config/locales,./modules/backlogs/config/locales/crowdin,./**/config/locales -L ba,nd,parms,pullrequest,pullrequests,sur,varius`	3 years ago
Oliver Günther	02a80edccd	Allow setting the status on User create/update contracts	3 years ago
Oliver Günther	58b64686d8	Add create contract spec for queries	3 years ago
ulferts	491928a3fd	replace typed_dag with closure_tree and CTE	3 years ago
Christophe Bliard	d760752677	better rspec test output	3 years ago
Christophe Bliard	fb2440ca18	improve output of contract tests	3 years ago
Christophe Bliard	a33524ef6d	remove ruby magic comment for utf-8 ... ruby interprets source encoding as utf-8 since 2.0.0, making magic comment redundant and useless	3 years ago
ulferts	d18f60aefe	replace assignable column on role	3 years ago
Christophe Bliard	bc8d423ec2	update copyright information for 2022	3 years ago
Christophe Bliard	47a297daae	Fix argument alignment since f08bea3467 (#10129) ... * Fix argument alignment since f08bea3467 The FactoryBot.* prefix has been removed in f08bea3467. Since then rubocop complains about Layout/ArgumentAlignment. This commit fixes it. * do not fix alignments for modules/*/spec yet hoping to be under the limit of 65535 characters for reviewdog to report on rubocop errors	3 years ago
Oliver Günther	f08bea3467	Remove FactoryBot.* prefix where applicable	3 years ago