115 Commits (022321b560167ad78af5d230bc2370cd1a8eec39)

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976) ... * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods 5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190) * turn scope classes into modules	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	6fe0d2752f	don`t bail if data is already gone	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized ... * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
ulferts	75b308d154	fix permission checks for edit_own_work_package_notes	4 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	7cd51d6443	remove unused users module	5 years ago
ulferts	59f907560e	no mail on empty wp update	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
Oliver Günther	693bd7760a	Replace deprecated `update_attribute` with `update` ... `update_attributes` was deprecated in Rails 6	5 years ago
Oliver Günther	abfaed8b74	Implement separate version table for journals ... This ensures inserts to the journal versions are atomtic, so we can avoid locking the journals table. https://community.openproject.com/wp/30594	5 years ago
Oliver Günther	1dfa9c1cf2	[30594] Implement separate version table for journals ... This ensures inserts to the journal versions are atomtic, so we can avoid locking the journals table. https://community.openproject.com/wp/30594	5 years ago
Oliver Günther	54d753262b	Fix issues caused by eager loading in production	5 years ago
ulferts	9c3206220b	remove mysql specific code throughout the application	5 years ago
Oliver Günther	8ed4ecb779	Check if the lock was acquired or raise an exception	6 years ago
Oliver Günther	e4ccc964b3	Use a journalized-scope advisory lock to minimize exclusive locks ... This commit removes transactional_lock (mysql-support only) with `with_advisory_lock` which supports both MySQL and PostgresSQL. For PostgreSQL, which supports more than one advisory lock per session, we can reference the customized type and ID to minimize the locking we do for other work packages.	6 years ago
Jens Ulferts	2d65eb3ebf	use string for class_name	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Jan Sandbrink	ebbd928a18	Remove outdated comments	9 years ago
Jan Sandbrink	9d68773b05	Use an advisory lock that is released on COMMIT/ROLLBACK ... for MySQL this seems to be the only available workaround that is not destroying running transactions. Note that TransactionalLock is a self-developed gem, that will emulate PostgreSQL style advisory locks, that are automatically released at transaction end.	9 years ago
Jan Sandbrink	aaf4637138	Ensure that concurrent version updates play well together	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Alexander Bach	a8e1aadec7	replace changed_data by details ... working towards making the alias obsolete...	9 years ago
Jan Sandbrink	6a0ef38f5f	extract get_changes into own module	9 years ago
Jan Sandbrink	5ed1ff28c1	styling	9 years ago
Jan Sandbrink	d6533b100c	first spike for aggregatable journals	9 years ago
Alex Coles	5557f58e80	Migrate model scopes to use lambda/block ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	df51b6ed99	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	a90d059841	make sure data is saved after creation already too	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	6fe9535b1f	Fix syntax (w/Rubocop) in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	721101ed25	Use 1.9+ Hash syntax in (Rails) models ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Richard	ee29bbd089	Journal editable_by? checks if user is the journal owner.	10 years ago
Hagen Schink	66ad6d6b76	Make changes a hash with indifferent access	11 years ago
Hagen Schink	abe3d9cac9	Remove symbols from journal processing ... This prevents journal processing of lots of objects from exhausting memory	11 years ago
Markus Kahl	d6b215f09e	dropped redundant limit	11 years ago
Markus Kahl	7301228d65	don't rely on journal record id to find predecessor and use version instead	11 years ago
Markus Kahl	08f8c482fe	dropped redundant limit	11 years ago
Markus Kahl	05c003e11f	don't rely on journal record id to find predecessor and use version instead	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Philipp Tessenow	ce68fdf70b	add fancy collection_select helper in the tabular_form_helper	11 years ago
Sebastian Schuster	9012596804	Changes from empty string to nil and vice versa are no ... longer recorded as journalized changes	11 years ago