119 Commits (0981c65582d734cc8cf2c37f192b42341a11cb0e)

Author	SHA1	Message	Date
Oliver Günther	d98f08b7db	Use tagged logger with timestamp formatting as early as possible (#9178) ... This ensure identical behavior in all environments and results in loggers receiving timestamps and levels in development as well.	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Cyril Rohr	b4086b2968	Standalone CI docker container (#8943)	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code ... Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	3076e5d57d	fix outdated console printout	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
ulferts	e695ba4d3b	enable zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
Oliver Günther	0182215f8c	Move mysql error early into application boot	5 years ago
ulferts	e7263fcedb	migrate to rails 6.0.0	5 years ago
Markus Kahl	1547a75a16	log sql statements by default in dev mode	5 years ago
Oliver Günther	d0756e2730	Re-add constraints path to eager_load	5 years ago
Oliver Günther	2ea2ad4826	Remove plugin tests from lib/ that now are eager loaded	5 years ago
Oliver Günther	54d753262b	Fix issues caused by eager loading in production	5 years ago
Oliver Günther	2fc4416601	Store User.current in current thread	5 years ago
Markus Kahl	3a1ee72b05	do not serve dynamic content assets (e.g. highlighting) through asset host	5 years ago
ulferts	7399488750	Replace Sass by SassC (#7011) ... * non engineer`s solution to replacing sass with sassc - livingstyleguide disabled * use the sass load path to add foundation * reenable livingstyleguide * readd sass to get livingstyleguide working [ci skip]	6 years ago
Oliver Günther	c3de946972	Add rake task job that will dynamically load tasks	6 years ago
Oliver Günther	e41d85e9c7	Implement OAuth applications CRUD	6 years ago
Oliver Günther	e6d578ad98	Remove storage and move 5.2 defaults in application.rb	6 years ago
Oliver Günther	4bb14e2a62	Upgrade to Rails 5.2	6 years ago
Cyril Rohr	c531fba836	Make the log_level configurable	6 years ago
Markus Kahl	e6a425e953	polish	6 years ago
Wieland Lindenthal	0a21541dd7	Allow filter WPs based on the content or file name of their attachments	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	3db13c90f0	Silence AS deprecations on production ... [ci skip]	7 years ago
Joe Rafaniello	d5bbfbf820	Avoid require memory leak with pathnames in load path ... Any ruby requires that occur in your application will leak with Pathnames in the $LOAD_PATH in ruby 2.3/2.4. Beyond that, it's faster to use strings in the load path. Please join this bug and add your support for a fix: https://bugs.ruby-lang.org/issues/14372 Same problem found here: https://github.com/lobsters/lobsters/pull/449	7 years ago
Joe Rafaniello	504a157ef0	Avoid require memory leak with pathnames in load path (#6148) ... Any ruby requires that occur in your application will leak with Pathnames in the $LOAD_PATH in ruby 2.3/2.4. Beyond that, it's faster to use strings in the load path. Please join this bug and add your support for a fix: https://bugs.ruby-lang.org/issues/14372 Same problem found here: https://github.com/lobsters/lobsters/pull/449 [ci skip]	7 years ago
Oliver Günther	e47c21ad41	Require active_support before including lib/	7 years ago
Oliver Günther	3649a81721	Rewrite user settings tabs to be extensible without patching (#6141) ... [ci skip]	7 years ago
Oliver Günther	845797d9ed	Add translations for core plugin branch	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533) ... * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Wieland Lindenthal	c8ae835074	Do not allow `admin/enterprise` routes if configuration if `ee_mangager_visible` is FALSE ... With such a configuration and in case a token is present, the might be a good reason not to reveal the enterpise token to the admin. Think of cloud solutions for instance.	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	38d49a5109	Don't produce deprecation notice on production ... [ci skip]	8 years ago
Oliver Günther	6fcddd42ab	Clean temporary RackMultiPart* files using middleware	8 years ago
Oliver Günther	191ee549b3	Silence deprecations on production and CI mode	8 years ago
Oliver Günther	544358855f	[24111] Fix double encoding of gzip attachments in Firefox ... Firefox will wrongly decode gzip attachments with `Content-Encoding: gzip`. https://bugzilla.mozilla.org/show_bug.cgi?id=421928 https://bugzilla.mozilla.org/show_bug.cgi?id=610679	8 years ago
Oliver Günther	5db362af4d	Rails 5 no longer does autoload constants outside the global namespace constant. ... Thus required files under lib/ are no longer correctly loaded at the moment. There are two solutions: Set config.enable_dependency_loading = true. This is not threadsafe and is not advised Eagerly load what we need from lib/. Since this now requires everything in there, it throws for old code and embedded files we did not actually require before. http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html#autoloading-is-disabled-after-booting-in-the-production-environment	8 years ago
Jens Ulferts	181514742f	replace observers by moving functionality inside the observed object ... The observers should have been removed a long time ago and with rails 5 there is https://github.com/rails/rails-observers/issues/52 to consider as well.	8 years ago
Oliver Günther	0d861af6d4	Remove deprecated raise_in_transactional_callbacks ... > In the next version, these errors will no longer be suppressed. Instead, the errors will propagate normally just like in other Active Record callbacks. http://edgeguides.rubyonrails.org/upgrading_ruby_on_rails.html	8 years ago
Oliver Günther	b72ecf2336	Adjust application middlewares	8 years ago
Oliver Günther	0f6c644b9e	WIP	8 years ago
Oliver Günther	3de8303361	Fix middleware reloading ... This should fix the `A copy of ResetCurrentUser has been removed from the module tree but is still active`.	9 years ago
Markus Kahl	00dff8b96a	fix User.current leak (#4533)	9 years ago