6179 Commits (1f45cd3ba1bc95b2a86fdf871ff091c5a2179018)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Czuchra	1f45cd3ba1	Merge pull request #5 from opf/feature/silently_rebuild_nested_set ... Feature/silently rebuild nested set	12 years ago
Martin Czuchra	719c51fe0d	Merge pull request #37 from opf/fix/issue_attachment_deletion ... no longer serializes changes as they will be anyway	12 years ago
Martin Czuchra	373c5560e0	Merge pull request #36 from opf/fix/issue_calendar_inclusion ... include calendar js files in case they are needed for edit	12 years ago
Jens Ulferts	0d3be2f958	no longer serializes changes as they will be anyway ... Assigning an already serialized attribute to an attribute that will be serialized by active record is disabled due to security issues (rails 2.3.17)	12 years ago
ulferts	e9da81ebca	Merge pull request #35 from opf/fix/urls-coming-from-rails-already-have-the-full-path ... Fixes problem with other urls passed into the function.	12 years ago
Jens Ulferts	26d37cf4f4	include calendar js files in case they are needed for edit ... The edit form requires Calendar.js. As the form is loaded asynchronously now and thus without html-header, the required files where no longer included in the page once an edit is desired. This might not be an optimal solution as the files are loaded regardless of whether they are actually used or not. Given the migration to rails 3, I consider it a practical solution as it solves the problem without creating mechanisms that might later be on hand anyway once the migration is done.	12 years ago
Martin Czuchra	1aca15609a	Fixes problem with other urls passed into the function. ... When urls are passed into this function, they originate from Rails. Rails already knows the full path, so the expansion only should happen on the default project list.	12 years ago
ulferts	544f64595c	Merge pull request #33 from opf/feature/projectSelect-url-argument ... Feature/project select url argument	12 years ago
Nils Kenneweg	777f197222	added the posibility to configure the url ... from which the project list is loaded. arguments is not an array...	12 years ago
Martin Czuchra	00717a702c	Fixes project hierarchy for subsequent searches.	12 years ago
Nils Kenneweg	1a2ce0bebd	hierarchy improved. nodes are not doubled any more. ... also stability increased. small bugfix.	12 years ago
cratz	d1189d04ba	Merge pull request #29 from opf/perf/issue_show_without_edit ... Perf/issue show without edit	12 years ago
Jens Ulferts	83abbf71e7	adapt ajaxAppend usage for loading issue diff to changed configuration ... It also moves the call to js instead of relying on inline js.	12 years ago
Jens Ulferts	b32b88d6dc	no longer loads priority and workflow as the edit form is no longer rendered directly	12 years ago
Jens Ulferts	857dd7c4d2	uses ajaxAppend for loading the issue#edit form ... This means that it is no longer necessary to render the edit form on every show request which will significantely increase the load speed of the page. We will have to see if it is ok for the user to have to wait for the form to load once he actually wishes to edit the issue.	12 years ago
Jens Ulferts	a0a81ee546	adapts ajaxAppend to be configurable ... The whole point of the extension is to be able to not only append directly behind the click target but to also be able to provide a target for appending.	12 years ago
Jens Ulferts	811ff89a48	renders the action menu twice on issue#show instead of copying it with javascript ... The js was only used on this specific page and it was required in the body. Now we render the action menu twice. Doing so required to place it in a partial which of course has some performance overhead. This and the fact that the action menu does not follow the paradigms employed by the other menus will require us to refactor the action menu to be just another menu, albeit it being rendered differently.	12 years ago
cratz	2841d1fc05	Merge pull request #28 from opf/perf/issue_show_eager_loading ... Perf/issue show eager loading	12 years ago
Jens Ulferts	8dcd74d2bd	no longer sorts by lft as it already is	12 years ago
Jens Ulferts	f135d4cfbe	eager loads assigned to on ancestors/descendants	12 years ago
Jens Ulferts	8f3aee5d4d	eager load objects associated with the changeset	12 years ago
Jens Ulferts	6b3fc60874	uses already loaded relations	12 years ago
Jens Ulferts	9b8cad4395	eager loads objects associated to issue	12 years ago
Jens Ulferts	2c22694e98	eager loads objects associated to the issue's relations	12 years ago
Jens Ulferts	3a8753d1b5	eager loads models associated with the issues ancestors and descendants ... Additionally it fixes the bug that all issues of the tree would be displayed even when the user didn't have the right to view them. This would be the case when the user has rights in Project A but non in Project B. Viewing an issue in Project A having ancestors/descendants in Project B would show those erroneously. Saves about 1.5 seconds when having 100 ancestors/desendants.	12 years ago
Jens Ulferts	cad2d044cd	allows joining multiple tables of awesome_nested_set structured models while using nested_set methods ... When joining issues and projects both tables come with their set of nested_set attributes. The attributes are named equally in both tables. This leads to ambiguous references when calling e.g. Issue.find(1).visible.descendants. This fix scopes the nested_set to reference the left attribute fully qualified. Adds additional methods that can be applied should the need arise. We should reevaluate why nested set is vendored as the problem would not have arisen when using the gem.	12 years ago
Jens Ulferts	f1c2656517	whitspace fixes	12 years ago
cratz	35cc017180	Merge pull request #27 from opf/perf/assignable_users_in_db ... refactors querying for assignable users	12 years ago
cratz	c19e611a66	Merge pull request #26 from opf/perf/issue_show_history ... Perf/issue show history	12 years ago
Christian Ratz	a2401b2798	removed join for always -one element- array, changed this to string	12 years ago
cratz	1e844335d1	Merge pull request #25 from opf/perf/journal_caching ... Perf/journal caching	12 years ago
cratz	563d054794	Merge pull request #23 from opf/cleanup/css ... Cleanup/css for filter fieldset	12 years ago
Christian Ratz	4b044d2015	added class to container element so all styles will be used	12 years ago
Martin Czuchra	964d46f974	Merge pull request #32 from opf/fix/token_mysql_vulnerability ... prevents exploiting implicit mysql typecasting	12 years ago
Jens Ulferts	d5daa90937	prevents exploiting implicit mysql typecasting ... This should prevent an attacker from issuing a request where he sends a token param casted to integer. MySql would cast the value attribute of Token to integer which is either the integer at the beginning of the value or, in absence of such, 0.	12 years ago
Martin Czuchra	4104f501ce	Merge pull request #31 from opf/fix/wiki_journals_after_2.3.17 ... removes explicit casting of changes to yaml	12 years ago
Jens Ulferts	e28a52e05a	removes explicit casting of changes to yaml ... Journal changes are serialized anyway. This double serialization worked fine until a security risk was identified and a fix for that was created which prevents already serialized data to be serialized again (rails 2.3.17)	12 years ago
cratz	3c3fbb0a92	Merge pull request #30 from opf/rails/2.3.17 ... updates rails to 2.3.17	12 years ago
Jens Ulferts	0dd5553af9	updates rails to 2.3.17	12 years ago
Jens Ulferts	e61b9b1351	uses a journal cache to render the history ... See the comment for some details. We should think about moving this into a different place like the controller or the User.current. Doing so would provide us with a request cache that can be reused for multiple purposes. However this might cause serious memory issues.	12 years ago
Jens Ulferts	89db6011e8	switches to join concatenation (as it was faster in my test)	12 years ago
Jens Ulferts	78fefce03b	moves issue tree row rendering into helper ... The partial was using content_tag methods anyway so readability was not improved by using a partial vs. a helper. Additionally the partial contained a lot of non view related ruby code. That and the fact that partials are expensive lead to moving it into a helper.	12 years ago
Jens Ulferts	e3be06f320	allows journal formatters to receive options and uses it to be able to ... pass an object cache For now it is only used by the NamedAssociation Formatter. The formatter requires to read a lot of model objects.	12 years ago
Jens Ulferts	892799d780	adds a very simple cache to cache arbitrary model objects ... yields a block with object_klass and object_id to be able to cope with not finding an object.	12 years ago
Jens Ulferts	db265d3123	adds a journaled_class method ... That way we do not have to load the class or do some magic parsing names when wanting to now what is journaled.	12 years ago
Jens Ulferts	747196f9b1	removes outdated comment	12 years ago
Jens Ulferts	74e21f7770	refactors querying for assignable users ... It is still not as fast as it should be. Even after refactoring it takes 1-2 seconds before the answer is calculated (used to be 5-6).	12 years ago
ulferts	5345c0f8f9	Merge pull request #24 from opf/feature/index-on-project-identifier ... Adds index to identifier field on projects.	12 years ago
Martin Czuchra	4eb461fbd2	Adds index to identifier field on projects.	12 years ago
Jens Ulferts	cfd1412d4e	removes css rules no longer needed	12 years ago