203 Commits (1f45cd3ba1bc95b2a86fdf871ff091c5a2179018)

Author	SHA1	Message	Date
Jens Ulferts	cad2d044cd	allows joining multiple tables of awesome_nested_set structured models while using nested_set methods ... When joining issues and projects both tables come with their set of nested_set attributes. The attributes are named equally in both tables. This leads to ambiguous references when calling e.g. Issue.find(1).visible.descendants. This fix scopes the nested_set to reference the left attribute fully qualified. Adds additional methods that can be applied should the need arise. We should reevaluate why nested set is vendored as the problem would not have arisen when using the gem.	12 years ago
Jens Ulferts	f1c2656517	whitspace fixes	12 years ago
Jens Ulferts	e3be06f320	allows journal formatters to receive options and uses it to be able to ... pass an object cache For now it is only used by the NamedAssociation Formatter. The formatter requires to read a lot of model objects.	12 years ago
Jens Ulferts	892799d780	adds a very simple cache to cache arbitrary model objects ... yields a block with object_klass and object_id to be able to cope with not finding an object.	12 years ago
Jens Ulferts	db265d3123	adds a journaled_class method ... That way we do not have to load the class or do some magic parsing names when wanting to now what is journaled.	12 years ago
Jens Ulferts	747196f9b1	removes outdated comment	12 years ago
Jens Ulferts	8bfc52ad29	whitespace fixes	12 years ago
Jens Ulferts	293e44e010	whitespace fixes	12 years ago
Jens Ulferts	dfec8a9375	reuses journal formatters	12 years ago
Jens Ulferts	4b54ba3ae3	keeps the old api for registering journal formatters intact ... The provided proc is dynamically assigned to an anonymous class which inherits from JournalFormatter::Proc. This class, a subclass of JournalFormatter::Attribute, is instantiated along with the other formatters once a field registered on the formatter needs to be formatted. The proc is then called within the value formatting.	12 years ago
Jens Ulferts	705200ec33	matches journaled field against regexp to be able to cope with dynamic field names ... Some plugin, e.g. acts_as_attachable and acts_as_customizable, dynamically add associations to a model following a schema, e.g attachments_[n], where n is increased over time.	12 years ago
Jens Ulferts	f8942922a8	moves journal formatting into multiple classes ... To better allow for customization, formatting journal entries is moved to separate classes. One can register for each field of a journaled object the same way like before (e.g. register_on_journal_formatter (:plaintext, 'subject')). The difference is purely inside the JournalFormatter. It determines the formatter required for the given field and class, instantiates it and calls the render method on the instance. JournalFormatter::Base subclasses are provided to handle the most common types of formatting (e.g. plaintext and decimal). The OpenProject formatters are removed altogether from acts_as_journalized and are moved into the OpenProject /lib directory. The helper_issues_show_detail_after_setting hook is removed. It should no longer be needed.	12 years ago
Jens Ulferts	eade1d29a8	indentation	12 years ago
Jens Ulferts	8fd1417e63	displays only the fact that an issue description has been changed and a link ... * displaying the first 80 characters reveals no information as the description is normally way longer than that	12 years ago
Eric Davis	225ae21b0b	Truncate and show a link to the full journal diff in the issue history	12 years ago
Gregor Schmidt	c94c0789bb	Async loading of project list in project jump box ... * Adding special URL endpoint to get all visible projects at once (w/o paging - as in /projects/index.json) * Adding openProject JS object to carry useful information and helper methods for JS land * Adding helper method to User to get the number of visible projects w/o loading all of them * Reducing dependency to DOM structure of select2 - using API access instead * Close menu when select2 list is closed	12 years ago
Felix Schäfer	dcca30bc70	Revert "code cleanup" ... This reverts commit 90d737aff5. The recreation of the hash wasn't "random", see 6f809b826e	13 years ago
Jens Ulferts	90d737aff5	code cleanup ... * should better convey the meaning that the value still is blank * avoids recreating the hash	13 years ago
Romano Licker	35c84fcd68	do not create a journal when attributes change from ... blank to blank (eg. nil -> "") we first came in contact with the problem when issue journals were created stating "description deleted" although there has never been any description on that object	13 years ago
Martin Linkhorst	d533816987	fixed a bug when projects couldn't be deleted when they have an issue hierarchy of more than 2 levels. credit jplang, redmine, see http://www.redmine.org/issues/8880	13 years ago
Martin Linkhorst	1fce5b6a8f	added attr_protected calls to protect mass assignment of :project_id through a view	13 years ago
Gregor Schmidt	ad1f36b16d	Avoid calling attr_protected if _accessible is used ... When attr_accessible is used, we may assume that watcher_ids and watcher_user_ids is already protected from mass assignment. Therefore we do not need to perform additional actions. Also, when attr_protected and attr_accessible is used on the same model, AR throws nasty "Declare either attr_protected or attr_accessible for *, but not both." errors.	13 years ago
Martin Linkhorst	cc74c1e998	added attr_protected calls to protect mass assignment of :project_id through a view	13 years ago
Romano Licker	de4cdf538b	without ! nothing is added to the formatters hash	13 years ago
Romano Licker	d29112203b	fixes recreating initial journals ... the method now uses the acts_as_journalized methods when recreating the initial journal and tries to use existing journals for rebuilding the history	13 years ago
Gregor Schmidt	124b559faa	Recreating journal sub classes if Journal was reloaded	13 years ago
Gregor Schmidt	2e890821f7	Using instance var to store journal class name ... this way journal classes are only created for classes with calls to acts_as_journalized. You may now subclass journaled models to extend them with helper methods in plugins w/o interfering with aaj.	13 years ago
Felix Schäfer	6fcb1de63a	Graciously handle deleted custom fields on issue history view.	13 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Felix Schäfer	a24a24eb19	Add deferred loading for plugins which's requirements aren't all met yet #256	13 years ago
Jean-Philippe Lang	5d7bc5c94c	[#577] Avoid validating users when creating watcher relation ... Taken from Redmine r5880 Committed by Jean Philippe Lang	13 years ago
Eric Davis	bf13b0f409	Check for journal_user, then updated_by, and finally User.current when creating Journals	14 years ago
Eric Davis	68526f6f2d	Clear @extra_journal_attributes also after saving a Journal	14 years ago
Gregor Schmidt	e2d16e1397	[#540] compatibility layer to reenable API from Chili 1.x	14 years ago
Eric Davis	c0d26da34e	Refactor: move method to recreate the initial journals out of migration	14 years ago
Eric Davis	dd6d9d1c68	[#513] Fix links to attachments in the issue history	14 years ago
Eric Davis	df0c75c050	Fix a problem loading ARCondition in development on second request.	14 years ago
Eric Davis	3b9980b449	Fix aaj to allow setting the journal user, note, and attributes directly. ... This will allow the Journaled object to reliability set the fields on the Journal without calling init_journal (which is a before_save hook and shouldn't be called directly).	14 years ago
Eric Davis	2f3657502f	[#474] aaj should use the Model's activity options for timestamp and author_key ... Some models (Changeset) require custom options passed to acts_as_activity_provider but acts_as_journalized wasn't accepting these for :timestamp or :author_key	14 years ago
Eric Davis	1cf08ee300	[#474] Changesets should use the author method for events ... This will let them pick up the committer string if user is nil	14 years ago
Eric Davis	bfba5e2151	[#441] Journals should touch their journaled to update updated_on/at fields	14 years ago
Eric Davis	33e3a71341	[#445] Track initial object attributes on the initial journal ... So the initial journal would have the changes from an Object#new to the created version of the Object. Also includes a change to the database migration in order to create these initial journals for all journaled Objects.	14 years ago
Eric Davis	aa07982daa	Fix an edge-edge case bug in journal_attributes_for_user with different users ... In one case in a plugin (not able to reproduce in core) journal_attributes_for_user would set the :user to something different than what's in updated_by thus assigning the Journal to the wrong user.	14 years ago
Felix Schäfer	6f809b826e	Replace a call to changes with its code from AR::Dirty. #422 ... acts_as_journalized called changes as per ActiveRecord::Dirty (see http://ar.rubyonrails.org/classes/ActiveRecord/Dirty.html#M000291), the journalized model Changeset :has_many changes though, which made the call return a list of associated objects instead of the intended list of changed attributes. Replaced changes with the code from AR::Dirty to work around that.	14 years ago
Felix Schäfer	66561031eb	[#400] Fix the event types (icons on activity and search views).	14 years ago
Gregor Schmidt	09fd71232e	[#412] fixes to make tests run on 1.9.2	14 years ago
Eric Davis	193b2c7a38	[#404] Move vendor/plugins/acts_as_journalized/app/ to the core app/	14 years ago
Eric Davis	adf57a64f1	[#123] Move aaj migrations to core	14 years ago
Eric Davis	23ef9fedef	[#123] Port the send_notification feature to aaj	14 years ago
Eric Davis	0ca73a7f69	[#123] Fix the down migration for Journal#journalized_type	14 years ago