138 Commits (290cc8bd02c154a4e1b2791f72ee4fcc5632be81)

Author	SHA1	Message	Date
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556) ... * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
Jens Ulferts	ea745865ad	remove focusability/role on non editable elements	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529) ... * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
ulferts	cbd33707b8	don't submit field if we already know it to be erroneous (#4525) ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
Jens Ulferts	48200d3a5c	don't submit field if we already know it to be erroneous ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
ulferts	76e2a5e0ce	submit on user blur (#4513) ... Will also submit the work package when clicking somewhere else (blur).	9 years ago
ulferts	104f918796	provide role attribute so that ngAria does not set it to "button" (#4518)	9 years ago
ulferts	a97797b057	Fix/nullable date field (#4503) ... * allow setting date fields to null * move all transformers into dedicated folder	9 years ago
Jens Ulferts	3bfc489a8e	remove html-class setting already present in the template ... There is already an ng-class statement setting the desired class upon editability. As the wp-edit-field directive is applied via an attribute, the $element is the dom element the directive is an attribute of. That way, the -editable class is applied twice.	9 years ago
Alex Dik	e79ce2a28f	Refactor editActionsBar directive (#4490) ... * Refactor editActionsBar directive * Move editActionsBar directive files to another location * Make the editActionsBar directive more general * Refactor WP details controller test * Fix WP details controller test	9 years ago
Roman Roelofsen	ae6087e9f0	Removed timeout defer	9 years ago
Roman Roelofsen	57e98024bb	WIP reducing watcher count	9 years ago
Roman Roelofsen	210379367f	WIP reducing watcher count	9 years ago
Oliver Günther	67c1cc154c	Cherry pick @og refactoring	9 years ago
Roman Roelofsen	e0bf811f77	Reduced watchers count, needs review!	9 years ago
Roman Roelofsen	8985c910f7	Reduced Watcher Count	9 years ago
ulferts	48ac7aa6f4	introduce strategy for displaying fields (#4469) ... In order improve the code structure and in order to enable plugins to add display strategies for fields, that are not covered by the core yet, a strategy pattern is introduced for displaying fields. The mechanism is identical to the way EditFields are handled. In fact, the DisplayFields and EditFields now inherit from a common superclass, Field. Also, the service and the factory inherit from a common superclass.	9 years ago
Oliver Günther	10d6a07b06	Fix empty wiki textarea check (#4465)	9 years ago
Oliver Günther	c223d6f108	Explicit setter for wpEditField.workPackage	9 years ago
Oliver Günther	909bc08266	Fix cuke selector	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up ... The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	6589b6ba50	Initialize edit field when work package is updated in cache	9 years ago
Oliver Günther	2f1d84c7cf	Fix saving/display of boolean custom fields ... Boolean custom fields were no longer saved since the field was marked as required and thus invalid when unchecked. Even when booleans were unchecked, they were output as 'Yes' since the text was evaluated to become the placeholder `-` before the format helper was called, thus resulting in a truthey value. Also, unchecked booleans are marked as placeholders since they are falsey when empty.	9 years ago
Oliver Günther	95541c1715	Add auto-complete directive	9 years ago
Manu Schiller	23a78a9895	enable save button for empty wiki-textareas if no value required (#4442)	9 years ago
Oliver Günther	ef94a15660	[23120,23121] Add required fields, labels to wp-edit-fields (#4421) ... * Add default label (name) to fields * Mark fields as required when schema says so * Work around xvfb :invalid state	9 years ago
Oliver Günther	9c7a368c05	Fix description focussing	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Oliver Günther	2bdf6ac776	Remove invalid description spec	9 years ago
Roman Roelofsen	72e3d62d3d	Focus Management Improvements: Throttle + Priority (#4430)	9 years ago
Oliver Günther	a1755f3ef3	Avoid click propagation from active edit-fields (#4428) ... Avoid clicks within the form to bubble up to the row handler. Otherwise, clicks within wp-edit-fields may cause the split / full view to open.	9 years ago
Oliver Günther	e439bf485c	Add form--select to inline select fields (#4426) ... Fixes the missing dropdown arrow in IE11	9 years ago
Oliver Günther	7fc5d13b7f	[23075][23087] Force selection of values when select is required (#4389) ... This changes the disabled default option for required select fields to select that by default and disable it. This causes a required field to have a default selection of Please select similar to the Rails selects. https://community.openproject.com/work_packages/23075/activity Angular doesn't seem to respect the string 'null' option correctly when removing an assigned field. Instead, the model is set to undefined and we need to check for that. https://community.openproject.com/work_packages/23087/activity	9 years ago
Alex Dik	5b89ebdd90	Enable jQuery UI Datepicker for date fields	9 years ago
Oliver Günther	ed9dfc3be1	Fix preview in description and comment for all modes	9 years ago
Oliver Günther	5da8c31f40	Fix switching types in Edit all mode	9 years ago
Oliver Günther	6e009604fa	Restore comment field ... It's incorrectly styled, still.	9 years ago
Oliver Günther	760fc47c7f	Fix focus on first element on create	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed ... This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	f6cb5b5ca4	Edit route for context menu	9 years ago
Oliver Günther	b849514904	Separate methods for entering/cancelling by user events	9 years ago
Oliver Günther	426876a264	Fix enabling fields by default when switching	9 years ago
Oliver Günther	cd17492a44	Save $pristine values in work package resource	9 years ago
Oliver Günther	4e2303ff60	Activate edit all when switching	9 years ago
Oliver Günther	d34799a89a	Edit all on fullscreen view	9 years ago
Oliver Günther	805b754971	Add wpEditModeState service to register form	9 years ago
Oliver Günther	c7d9be477d	Expand fields correctly	9 years ago
Oliver Günther	650b5f4159	Implement edit-all through wpEditForm	9 years ago
Oliver Günther	a5823dc755	Fix error state of fields newly introduced by type switch	9 years ago