361 Commits (2e00ea7c99e1d4c29b92c9ac5aff9fb3605de723)

Author	SHA1	Message	Date
Oliver Günther	7780126274	Remove attachment service/directive coupling ... Previously, attachments for a work package were kept in the directive (good, since its scoped by the active work package and destroyed when moving) AND in the service (horrible, since they are requested twice AND the service is never reset). This causes a bug when moving to new/existing work packages due to remaining attachments in the service. We can completely avoid this by passing an event from drag handler to the directive instead to the service. This also removes the edit / no-edit attachment template duality, since that's no longer required.	8 years ago
Oliver Günther	85d4b319a8	Remove attachment _link references	8 years ago
Oliver Günther	61b74b0b27	Fix comment accessibility ... 1. Make the title a label (we won't need a title for seeing users anyway, the full text is there). 2. Remove invalid `|| undefined` in the ng-disabled check	8 years ago
Oliver Günther	8dacc087af	Fix attachment service	8 years ago
Oliver Günther	e8f668fc52	Remove traces of workPackageRefreshRequired	8 years ago
Oliver Günther	0bab97cf48	Refactor watcher panel	8 years ago
Oliver Günther	e68d9275e0	Fix activity spec	8 years ago
Oliver Günther	35fa754a81	Forceful reloading the activites after commenting	8 years ago
Oliver Günther	4a2afe4902	Refactor activity-panel	8 years ago
Oliver Günther	a07e499373	Fix wpAttachmentsService spec	8 years ago
Oliver Günther	2b94f14490	Fix wp comment test	8 years ago
Oliver Günther	8a21d854b7	Fix quoting existing comments	8 years ago
Oliver Günther	f705e4d9ac	Rewrite comment directive in TypeScript without inplace	8 years ago
Oliver Günther	7c9e032a5f	Remove props usage	8 years ago
Oliver Günther	e4f479c1b4	Use WorkPackageResource in panels	8 years ago
Oliver Günther	06550750b1	Replace inplaceEditAll	8 years ago
Oliver Günther	f1b9ac931d	Remove inplace-edit	8 years ago
Oliver Günther	f338621a83	Remove double timeout execution in interactive-table (#4616) ... Removes: Throwing resize in single-view, since $timeout is used anyway in the initialization. double timeout execution in interactive-table Contributes to https://community.openproject.com/work_packages/23139	8 years ago
Oliver Günther	ea6b930582	Show 'Open in full screen' notification only when not in fullscreen ... https://community.openproject.com/work_packages/23574/activity	8 years ago
ulferts	4e4d78aa2d	refer to original event to get to the data (#4604) ... * refer to original event to get to the data * Use the correct decorated event by jQuery	8 years ago
Oliver Günther	f9f6eb6986	Remove double identifier	8 years ago
Alex Dik	91d38bf212	Fix tsc test output	8 years ago
Alex Dik	18ba664f72	Fix and refactor attachments related stuff	8 years ago
Alex Dik	69b03633d3	Refactor singleViewWp service	8 years ago
Oliver Günther	6c5904c151	Fix TS warnings	8 years ago
Jens Ulferts	bae0bfdd0b	prevent empty values from being hidden while editing	8 years ago
Oliver Günther	49f5a836e8	Revert show-all default behavior ... This reverts the change to show all fields in the create mode to behave like before in all tests. If we want to change it, we should move it out of this PR.	9 years ago
Alex Dik	83760a4c54	Show usually hidden fields of new WPs ... Toggle the 'show all' button, if the WP is being created. Also fix a bug, where the attributes where show regardless of the expand/collapse state.	9 years ago
Oliver Günther	e28ad041d2	Don't show new work package id in single view	9 years ago
Alex Dik	57f191ba61	Fix custom field spec ... Thanks to ulferts	9 years ago
Alex Dik	c7096bb220	Add subject field ... Add subject field	9 years ago
Alex Dik	b68394d3cb	Replace wpCreateForm directive with wpCreate directive	9 years ago
Alex Dik	e23b32c495	Load attachments only if the work package has any (#4561)	9 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556) ... * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
Jens Ulferts	473a1107a6	use aria-label to communication "label + value"	9 years ago
Jens Ulferts	112f2d398a	remove class that is then replaced ... Because of the use of replace: true within the wp-display-attr, the classes of the first element get merged with whatever classes are defined on the calling dom element. As the classes on the calling dom elemnt suffice, we do not need that extra class.	9 years ago
manuschiller	d9a38f8b89	Adding attachments to work package descriptions by drag and drop ... https://community.openproject.org/work_packages/22511 This adds drag and drop functionality for wiki-textareas concerning wp-attachments (mainly the description field) in workpackages. based on the use of our new directives by @furinvader as proposed in https://github.com/opf/openproject/pull/4471 Features: handles drop events on description fields of work packages and can distinguish between: - local files: initiates file upload (single file or upload queue) - external urls: become inserted as default weblink - external image files: become inserted as inline image - attachments from current work package: become inserted as attachment link - attachments (imagefiles) from current work package: become inserted as inline image	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
Jens Ulferts	90bae4ebfd	prevent duplicate readout of the wp-display-attr label	9 years ago
ulferts	9fb2f68675	fix hidden label (#4500)	9 years ago
Jens Ulferts	2e5dfc794b	add missing closing div tag	9 years ago
Roman Roelofsen	ae6087e9f0	Removed timeout defer	9 years ago
Roman Roelofsen	f32b9c90b2	Removed timeout defer	9 years ago
Roman Roelofsen	57e98024bb	WIP reducing watcher count	9 years ago
Roman Roelofsen	78417cdd0c	WIP reducing watcher count	9 years ago
Roman Roelofsen	210379367f	WIP reducing watcher count	9 years ago
Roman Roelofsen	e0bf811f77	Reduced watchers count, needs review!	9 years ago
Roman Roelofsen	8985c910f7	Reduced Watcher Count	9 years ago
ulferts	48ac7aa6f4	introduce strategy for displaying fields (#4469) ... In order improve the code structure and in order to enable plugins to add display strategies for fields, that are not covered by the core yet, a strategy pattern is introduced for displaying fields. The mechanism is identical to the way EditFields are handled. In fact, the DisplayFields and EditFields now inherit from a common superclass, Field. Also, the service and the factory inherit from a common superclass.	9 years ago
Markus Kahl	f64d06638c	hide hidden fields even if they have a value (#4408) ... * Make test/dev assets settings explit * description must not be customizable * updated feature help text * fields with default values can be hidden * fixed hide condition * fixed edit wp spec (required cf) for some reason factories initialize custom fields with '' (empty string) as default values. The API interprets this as a default value being present. In normal operation a custom field without a default value will return nil, not the empty string	9 years ago