openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	245a7ddfcf	Fix/duplicate work packages across pages (#8651 ) * deprecated method * remove apparently unused methods * append id desc sorting to work packages * enforce sorting is applied in query results * ensure deterministic order in base query	4 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Oliver Günther	a6a4031aa2	[31667] Fix ambiguous reference to project_id when group/sort Properly reference project_id to avoid ambiguous references to project_id when grouping by project_id and sorting by priority https://community.openproject.com/wp/31667	5 years ago
ulferts	c47a8bb5b0	fix group_by associated resource if only a nil group exists	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	c4dc6e2c91	ensure sums are also sorted by group_by column	5 years ago
ulferts	c5ec196a37	minor cleanup of spec	5 years ago
ulferts	9c3206220b	remove mysql specific code throughout the application	6 years ago
Oliver Günther	9020120e44	[29689] Allow setting the sort dir for group_by column https://community.openproject.com/wp/29689	6 years ago
Oliver Günther	622e73664d	Remove hierarchy paths and migrate away from parent column	6 years ago
Oliver Günther	c6538c5b69	[29598] Fix SQL joins from filter when grouping https://community.openproject.com/wp/29598	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773 ) * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
Jens Ulferts	43e293178c	avoid AR exception on overlapping groups	6 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Jens Ulferts	79d8be42c4	dynamically determine the correct sort order in parent order test	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
ulferts	8c732b9a42	Fix/parent depth first sorting (#6133 ) * maintain hierarchy path for performant sorting * by default - only sort by parent Parent sorting is exclusive as the sorting used is depth first. Because of that, the id of the work package is always part of the parent order criteria. By that, all other properties of the work package become irrelevant. [ci skip]	7 years ago
Oliver Günther	0d55bc0308	[26675] Remove implicit ID sorting on parent sort (#6039 ) * [26675] Remove implicit ID sorting on parent sort https://community.openproject.com/wp/26675 * parent sort -> breadth first sort, top down [ci skip]	7 years ago
ulferts	b8355caf51	treats non set cf values same as "No" for boolean cf filtering (#5803 ) Work packages who cannot have the value (not added to project or type) are exempt from this. [ci skip]	7 years ago
ulferts	c70aa76ea0	mimic AR join alias calculation for query (#5682 ) * mimic AR join alias calculation for query * remove unused columns parameter on v3 query get [ci skip]	8 years ago
Jens Ulferts	4df369884a	employ the subproject filter to handle subproject setting	8 years ago
Jens Ulferts	33545b9e39	refactor query filter statements into distinct classes	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Jens Ulferts	f833cd2753	add test for mysql flag	8 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Jens Ulferts	2516e9c0e7	allow to disambiguously group by responsible association Before the commit, the result for a count on a query grouped by responsible would be of the schema { id: count, id2: count2 }. For other attributes, e.g. assignee it is { user: count, user2: count2}. The difference is caused by using :responsible_id for grouping which is necessary as the association causes an ambiguous reference in the issued db query. That problem has been fixed in rails/master (`c2d33c4abf`). But as long as the fix is not backported, we will have to overwrite a method of ActiveRecord::Calculations	9 years ago
Alex Coles	81de05e5fe	Remove deprecated Relation#all in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Jens Ulferts	0fa28f14dc	avoid id naming collisions on query statements	10 years ago
Alex Coles	f95c9d15f3	Prefer #map over #collect in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	789e13a479	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec -f * 46 conversions from: it { should ... } to: it { is_expected.to ... } * 9 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 1 conversion from: describe 'some request' { } to: describe 'some request', :type => :request { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { \|example\| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Hagen Schink	084a01b212	Clean up spec file	11 years ago
slawa	5842457395	Spec tests assignee role query result	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Till Breuer	cba6dbec16	Specify table name when queries group by responsible (fixes #3202 )	11 years ago

43 Commits (2eb58888afbe120aaa0253977b0179193bbedf26)