openproject

Commit Graph

Author	SHA1	Message	Date
luz paz	e8c2928a12	Fix typo beeing->being in spec/ and modules/	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	5e33c4b637	ensure all enqueued jobs are run	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
ulferts	7e7b9132e3	Fix/child scheduling restrictions (#8584 ) * allow free scheduling children of manualy scheduled parents If a parent has a follows relations with another work package, that relationship also limites children of the work package. But if the work package is scheduled manually, this creates a scheduling barrier. Children of a manually scheduled work package are not hampered by the follows relationships of the parent or other ancestors. * simplify soonest_start query * eager load * extract to scope	4 years ago
ulferts	655f021b92	add derived dates to the work package resource The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
ulferts	e20910a2c9	remove unused service The last call to the `reschedule_after` method was removed in #690e0ffc60.	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
ulferts	67ade5002d	extract journal notification setting to separate class	5 years ago
Oliver Günther	80e747e0c6	Fix test by calling service with system user Adds this to the factory to avoid using the system user all over the place	5 years ago
Oliver Günther	e4dcc6c5ea	Avoid usage of `users <<` pattern in group This will no longer trigger the addition	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275 ) * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	830451d9f9	remove unused changes module	5 years ago
ulferts	7fa2abf5fa	adapt factory usages	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	6c4e572f4e	consolidate allowed_* logic in the wp contract	5 years ago
ulferts	a78b59d479	unsubscribe from OP notification to avoid affecting other specs	5 years ago
Oliver Günther	7a09d8fcdd	delay all jobs	5 years ago
ulferts	67e3a7a15a	let mail sending rely on notifications That way, the two are no longer intermingled and we can build on the notifications in other use cases like it is already done for the webhooks	5 years ago
ulferts	60b4b47c75	ensure journal notifications value is reset Before, an execption raised within the block would lead to the value not being reset. This happens e.g. when a transaction is canceled. This caused spec failures to occur from time to time e.g. rspec ./spec/models/work_package/openproject_notifications_spec.rb[1:1:1:1] ./spec/requests/api/v3/membership_resources_spec.rb[1:2:3:1] --seed 92792 but might also have unwanted side effects in production	5 years ago
ulferts	663d4a32ca	attempt to fix flickering spec	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
Markus Kahl	6b5b314e36	add :work_package_after_create\|update to Redmine::Hooks	5 years ago
Oliver Günther	693bd7760a	Replace deprecated `update_attribute` with `update` `update_attributes` was deprecated in Rails 6	5 years ago
Markus Kahl	a27c700948	add :work_package_after_create\|update to Redmine::Hooks	5 years ago
Oliver Günther	726241bc95	[30532] Don't submit notification mails for parent changes https://community.openproject.com/wp/30532	5 years ago
ulferts	cc0145daf6	prevent useless edits to wp status In case the fixed version and the status of a work package are both closed, the status of a work package cannot be altered any more. Attempting it will result in an error. Before the fix, the possible status calculation would not factor in that situation and the status would be marked as writable regardless as well. Therefore, the frontend would display a list of statuses even though selecting one would do nothing at all. Now, the status property is marked as non writable in such a situation and the status list will only contain the current status. As we only fetch the form after a click on the edit field, we can only disable the field after that which is a bit weird.	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
ulferts	1850622f20	Feature/versions api update (#7299 ) Feature/versions api update [ci skip]	6 years ago
Oliver Günther	5b49b33b21	Prepare for core integration	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Jens Ulferts	8d7a59806a	remove unused service Has been part of the timelines functionality	6 years ago
Jens Ulferts	26f984c64e	avoid sending mail in unit spec	6 years ago
Oliver Günther	3807bc4f7f	[28446] Rename due date to finish date https://community.openproject.com/wp/28446	6 years ago
Wieland Lindenthal	57892d782b	Satisfy spec and code climate	6 years ago
Jens Ulferts	a8e5ab619f	adapt to core's altered eager loading	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot Removes the deprecation	7 years ago
Oliver Günther	61afac09cc	FactoryGirl => FactoryBot (belongs to opf/openproject#6304 )	7 years ago
Jens Ulferts	b3a11a0fd9	replace deprecated references to changes in after_save hooks	7 years ago
Jens Ulferts	77cd58a1b2	fix error access	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Jens Ulferts	a1812699f0	validate actions	7 years ago
Jens Ulferts	42e5933545	improve wp#index performance by eager loading custom actions	7 years ago
Jens Ulferts	d20960b998	add role condition	7 years ago

1 2 3 4 5

220 Commits (3157dd0d0b378e6ce5e106307a9144d5a2ff10e1)