2685 Commits (463aa185da51bdd1b6285d84e8f186ebe9d7dee2)

Author	SHA1	Message	Date
Jan Sandbrink	ebbd928a18	Remove outdated comments	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jan Sandbrink	9d68773b05	Use an advisory lock that is released on COMMIT/ROLLBACK ... for MySQL this seems to be the only available workaround that is not destroying running transactions. Note that TransactionalLock is a self-developed gem, that will emulate PostgreSQL style advisory locks, that are automatically released at transaction end.	9 years ago
Jan Sandbrink	3c335866d1	Fix saving of journal in association ... When moving the code over here I replaced a journable.journals.select(&:new_record?).each(&:save!) with journal.save! I did this because we know that only the latest journal will be unsaved. However, it seems that we actually rely on a side-effect of journable.journals being iterated (journable.journals.to_a works as well). I have no idea whats going on, but I made the unobvious part more obvious...	9 years ago
Jan Sandbrink	aaf4637138	Ensure that concurrent version updates play well together	9 years ago
Jan Sandbrink	caf05e9b1a	Simplify joins clause	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Jan Sandbrink	26574521d3	Prefill predecessors for results of multiple journables too	9 years ago
Jan Sandbrink	0343e12c83	Prefill predecessor when it is already known ... Getting the predeccessor of a journal is a common operation. When computing the journals for a single journable, it is easily possible to prefill the predecessor (because we know all the journals). Doing this avoids an N+1 query later on (in case the journals are used to display diffs).	9 years ago
Markus Kahl	9af0e26623	make user creation/invitation work with plugins ...	9 years ago
Markus Kahl	86248f400e	groups are never disposable	9 years ago
Markus Kahl	3738329078	delete invited users when removed from project	9 years ago
Markus Kahl	ac8a096488	polish considering remarks through review and houndci	9 years ago
Markus Kahl	8882a0a2cc	the session is optional	9 years ago
Markus Kahl	45153a5d1b	dummy LDAP auth source ... I don't care if we have a company LDAP. My thoughts go out to devs* who don't have that. *OpenSource, right?	9 years ago
Markus Kahl	df36876d21	User ⊆ Principal ∧ Principal ⊄ User ... I.e. calling Member#principal will always work. On the other hand calling #user will fail if the member is a group.	9 years ago
Markus Kahl	fecb1b91b7	invited uses should be usable too ... We may need to think of a name that includes active, registered as well as invited users. For now we can think of invited users as registered ones. Just a bit differently.	9 years ago
Markus Kahl	2ce62e3999	user invitation polish	9 years ago
Markus Kahl	43e18dd00c	switch to user invitation by default ... this changes quite many flows. With this user self registration is a separate flow to what happens when an admin creates a user. Users created by admins are 'invited' instead of 'registered'.	9 years ago
Markus Kahl	98ba7ce333	basic user invitation prototype	9 years ago
Alex Coles	d76e97755c	Fix Settings callbacks for ActiveSupport API change ... Identify callbacks with String not Symbol. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	db078e0964	Fix for ActiveRecord::Base.reflections API change ... `WorkPackage.reflections.keys` now returns Strings rather than symbols. This solution is not ideal: calling `to_sym` is often a code smell. It might be acceptable to pass through Strings to `includes`, but this warrants further discussion. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	407aa02eae	Fix deprecated .find arg in Project ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	8870838ce9	Ensure compatibility of sum-functions with Array callers ... this is neccessary to allow building sums for grouped results. The long-term goal should be to also move the grouping to the SQL side. Currently grouping will make a query very slow ("normal" with respect to its prior performance, but "slow" with respect to the performance of the grouping-free sum implementation).	9 years ago
Jan Sandbrink	1e4427f400	Uniformly format QueryColumns ... - wrap all columns parameter-wise - ensure that none exceeds the 100 character limit per line	9 years ago
Jan Sandbrink	02e7b9f5a8	Move summing of column values into QueryColumn ... - letting a column indicate whether it is summable (avoiding errors when trying to sum the "subject" or other silly things) - summing normal QueryColumns SQL side - doing SQL side filtering for CF-columns to improve performance for sparsely filled custom fields Possible improvements: - fully computing custom field sums SQL side (for dense custom fields) - only using a single query for all summed columns, instead of one SQL query per column	9 years ago
Jan Sandbrink	ef9cc87338	Always cache work_packages of Query::Results ... replacing the already cached :all_work_packages by the usual :work_packages	9 years ago
Oliver Günther	15273724c3	Homescreen functionality ... This commit adds the homescreen functionality to OpenProject, replacing the default welcome screen. This adds support for: * Blocks of content for various privilege levels (latest projects, users, news, etc.) * Links to common functionality (administration, community) Relevant work package: https://community.openproject.org/work_packages/19722	9 years ago
Oliver Günther	c13afd01c4	Force disabled_types to be symbols ... To avoid exposed types from misconfiguration (or installations where string-based configuration is a requirement), we convert the input from `disabled_types` to be symbols.	9 years ago
Jan Sandbrink	b76c351813	Ensure mails are not sent twice ... ... in case a user is author + watcher	9 years ago
Jan Sandbrink	e8c57d7674	Correctly deliver notifications on behalf	9 years ago
Jan Sandbrink	4ee163393f	Rearrange mail delivery responsibilities ... - each delivery job delivers only a single mail (like in the past) - a common super-class ensures correct handling of different error conditions (similar to the past) This new structure should allow for an efficient error handling: - fail the mail delivery on a per-recipient basis (i.e. redeliveries on error only affect the user that did not receive a mail) - only fail the delayed job for delivery errors (e.g. network issues, etc) - do not fail the delayed job for rendering errors (which are likely to re-occur on each rendering) -> only log those	9 years ago
Alex Coles	07551ae585	Switch to new AR API for boolean typecasting ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Stefan Botzenhart	868d764a97	Use activejob deliver_now method (removes deprecation warning)	9 years ago
Oliver Günther	6661f2b6d5	Refuse to delete a repository in OpenProject on FS permission errors ... This commit changes the behavior of removing repositories. It is no longer possible to remove a managed repository (model) when the underlying repository directory could not be removed. This error originally occurred when Apache committed changes to the repository through mod_svn, which resulted in the OpenProject user being unable to delete a particular subdirectory.	9 years ago
Jan Sandbrink	08ef41b14d	increase type compatibility of :sql_for_field ... it is expecting a string array anyway (and casting to integer on demand) still that makes ints not less valid...	9 years ago
Jan Sandbrink	92bb497a66	rename parameter/update code doc ... it is actually expected to be an array...	9 years ago
Alexander Bach	51b2bf768c	Remove homepage attribute from project model	9 years ago
Jan Sandbrink	1ac1188ef8	fix spec double and remove users from groupable CFs ... - spec double was not up to date with reality of return values - user custom fields are not successfully groupable, because the order statement is a list	9 years ago
Jan Sandbrink	a64209967e	extract order_statements out of CustomField	9 years ago
Jan Sandbrink	85afbf9f82	remove unused find_all_by overload ... could not find any usages in core or plugins	9 years ago
Jan Sandbrink	dfb9a5cd20	remove remaining AR find_by_x finders ... - most of them were removed by @myabc in the rails4 branch - some where reintroduced due to parallel development to that branch - still some occurences left that will hit custom implementations	9 years ago
Alexander Bach	144dfc0236	Clarify SQL condition to explicitly look for pending notifications	9 years ago
Alexander Bach	7c084f1dd8	Fix line length	9 years ago
Alexander Bach	564273cded	Prevent duplicate notifications for the same work package	9 years ago
Alexander Bach	4105a920b5	Style watcher notification mail	9 years ago
Alexander Bach	c22c41b7db	Directly notify new watchers by mail	9 years ago
Oliver Günther	dfb8ac4853	Add basic checkout instructions ... This commit adds very basic checkout instructions similar to `openproject-checkout` to repositories. Issues: * Uses table style for checkout component, as exact styling is unclear * Adds compressed table style with less padding * Checkout settings are best organized in a Hash with keys per SCM * vendor. Using default settings, a lot of new setting values would be introduced * Checks for Hash in SettingsController * Currently can't use SettingsHelper, as it requires single setting values	9 years ago
Jan Sandbrink	e978876acc	fix expectations in legacy spec ... - real code is actually able to deal with arrays being returned from sortable - simplified group by sorting	9 years ago
Jan Sandbrink	04895aeffb	ensure sortability of all user columns ... I am not seeing any other unsortable columns, so this might make the API exposed "sortable" property obsolete (exposed in experimental API)	9 years ago