openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	26dff6132e	Remove default route (#6137 ) * Remove default route * Fix and clean legacy specs * Fix specs * Fix missing ID in request parameters in view specs https://stackoverflow.com/a/21789313 * Fix more invalid routes in specs * Pass parameter to omniauth spec * Add required ID parameter to types controller * Fix invalid omniauth URL * Fix project_id params in repository controller spec * Fix missing project id in projects controller spec * Fix missing params and failure url for omniauth * Fix invalid route name * Temporarily skip broken specs on dev [ci skip]	7 years ago
ulferts	c0b709530c	Fix/replace deprecations (#5533 ) * replace alias_method_chain * remove deprecation silencing * bump controller-testing * introduce permitted params for settings * replace various deprecations in controllers * remove deprecation silencing for legacy_specs * remove `puts` from spec * replace deprecated access to errors * remove unnecessary AR::Parameters usage in spec * specify error to expect * replace deprecations * replace deprecated action calls in legacy function specs * replace deprecations in functional controller tests * replace deprecations in controllers/controller_specs * remove params parser which does not seem to be in effect It is registered for the content type :exclude which makes no sense as it should deal with :json. The desired behaviour of the api dealing with parsing errors is working with or without the code. * replace deprecations in unit specs * replace alias_method_chain [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	616ec628b5	Rewrite with_setting specs And fix tests that do not expect settings to be cached during the request with RequestStore.	8 years ago
Oliver Günther	c5a33fc4fa	[ci skip] Remove reposman functionality. This commit removes the functionality provided by reposman.rb, and replaces that script with an empty placeholder printing only a deprecation warning (as to not throw errors in existing cronjobs). In detail, this commit does: * replace reposman.rb with an script printing a deprecation only. * Remove repositories creation API in SysController and corresponding specs * Update documentation guides concerning the deprecation of reposman * Remove packager scripts for creating a reposman.rb cronjob. * Adds a rake task to migrate repositories to managed type with a common * URL prefix.	9 years ago
Mohamed Wael Khobalatte	71c1092e21	Fix various legacy specs	9 years ago
Mohamed Wael Khobalatte	626779d92d	Use assert_select instead of deprecated assert_tag	9 years ago
Stefan Botzenhart	e6972f5f9d	Move legacy spec to separate spec folder Legacy specs interfere with the normal ones so they need to be isolated.	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - Configuration: Currently replaces the existing options in `configuration.yml`. - Implementation specifics: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Alex Coles	6129e9f41f	Remove functional spec rescue_action boilerplate Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	2efd6f4e45	Move legacy specs under spec/legacy Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3445baec04	Convert specs to RSpec 3.2.0 syntax with Transpec This conversion is done by Transpec 3.1.0 with the following command: transpec -f -c "bundle exec rspec -Itest" test/functional/account_controller_test.rb test/functional/activities_controller_test.rb test/functional/admin_controller_test.rb test/functional/application_controller_test.rb test/functional/attachments_controller_test.rb test/functional/boards_controller_test.rb test/functional/custom_fields_controller_test.rb test/functional/enumerations_controller_test.rb test/functional/groups_controller_test.rb test/functional/help_controller_test.rb test/functional/journals_controller_test.rb test/functional/mail_handler_controller_test.rb test/functional/messages_controller_test.rb test/functional/my_controller_test.rb test/functional/project_enumerations_controller_test.rb test/functional/projects_controller_test.rb test/functional/repositories_controller_test.rb test/functional/repositories_filesystem_controller_test.rb test/functional/repositories_git_controller_test.rb test/functional/repositories_subversion_controller_test.rb test/functional/roles_controller_test.rb test/functional/search_controller_test.rb test/functional/settings_controller_test.rb test/functional/sys_controller_test.rb test/functional/time_entries/reports_controller_test.rb test/functional/timelog_controller_test.rb test/functional/types_controller_test.rb test/functional/user_mailer_test.rb test/functional/users_controller_test.rb test/functional/watchers_controller_test.rb test/functional/welcome_controller_test.rb test/functional/wiki_controller_test.rb test/functional/wikis_controller_test.rb test/functional/workflows_controller_test.rb test/integration/api_test/disabled_rest_api_test.rb test/integration/api_test/http_accept_auth_test.rb test/integration/api_test/http_basic_login_test.rb test/integration/api_test/http_basic_login_with_api_token_test.rb test/integration/api_test/token_authentication_test.rb test/integration/application_test.rb test/integration/layout_test.rb test/integration/lib/redmine/menu_manager_test.rb test/integration/lib/redmine/themes_test.rb test/integration/routing_test.rb test/unit/activity_test.rb test/unit/attachment_test.rb test/unit/board_test.rb test/unit/category_test.rb test/unit/changeset_test.rb test/unit/comment_test.rb test/unit/custom_field_test.rb test/unit/custom_field_user_format_test.rb test/unit/custom_value_test.rb test/unit/default_data_test.rb test/unit/enabled_module_test.rb test/unit/enumeration_test.rb test/unit/group_test.rb test/unit/helpers/application_helper_test.rb test/unit/helpers/custom_fields_helper_test.rb test/unit/helpers/sort_helper_test.rb test/unit/helpers/timelog_helper_test.rb test/unit/issue_nested_set_test.rb test/unit/issue_priority_test.rb test/unit/journal_observer_test.rb test/unit/journal_test.rb test/unit/ldap_auth_source_test.rb test/unit/lib/open_project/database_test.rb test/unit/lib/redmine/access_control_test.rb test/unit/lib/redmine/ciphering_test.rb test/unit/lib/redmine/codeset_util_test.rb test/unit/lib/redmine/helpers/calendar_test.rb test/unit/lib/redmine/hook_test.rb test/unit/lib/redmine/i18n_test.rb test/unit/lib/redmine/menu_manager/mapper_test.rb test/unit/lib/redmine/menu_manager/menu_helper_test.rb test/unit/lib/redmine/menu_manager/menu_item_test.rb test/unit/lib/redmine/menu_manager_test.rb test/unit/lib/redmine/mime_type_test.rb test/unit/lib/redmine/notifiable_test.rb test/unit/lib/redmine/plugin_test.rb test/unit/lib/redmine/safe_attributes_test.rb test/unit/lib/redmine/scm/adapters/filesystem_adapter_test.rb test/unit/lib/redmine/scm/adapters/git_adapter_test.rb test/unit/lib/redmine/scm/adapters/subversion_adapter_test.rb test/unit/lib/redmine/unified_diff_test.rb test/unit/lib/redmine/wiki_formatting/macros_test.rb test/unit/lib/redmine/wiki_formatting/null_formatter_test.rb test/unit/lib/redmine/wiki_formatting/textile_formatter_test.rb test/unit/lib/redmine/wiki_formatting_test.rb test/unit/lib/redmine_test.rb test/unit/mail_handler_test.rb test/unit/member_test.rb test/unit/message_test.rb test/unit/principal_test.rb test/unit/project_nested_set_test.rb test/unit/project_test.rb test/unit/query_test.rb test/unit/relation_test.rb test/unit/repository_filesystem_test.rb test/unit/repository_git_test.rb test/unit/repository_subversion_test.rb test/unit/repository_test.rb test/unit/role_test.rb test/unit/search_test.rb test/unit/status_test.rb test/unit/time_entry_activity_test.rb test/unit/time_entry_test.rb test/unit/token_test.rb test/unit/type_test.rb test/unit/user_preference_test.rb test/unit/user_test.rb test/unit/version_test.rb test/unit/watcher_test.rb test/unit/wiki_content_test.rb test/unit/wiki_page_test.rb test/unit/wiki_redirect_test.rb test/unit/wiki_test.rb * 180 conversions from: it { should ... } to: it { is_expected.to ... } * 12 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: Klass.any_instance.should_receive(:message) to: expect_any_instance_of(Klass).to receive(:message) * 4 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	b8567d13ed	Remove spec controller boilerplate; Replace ivars Prefer methods provided by rspec-rails. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	1501012cf8	First spike porting Test::Unit tests to RSpec * Convert tests from Test::Unit to RSpec syntax, but keep Test::Unit- style assertions, configuring RSpec to support `:minitest` assertions * Update Helpers and backported Shoulda macros to work. Tests can be run with RSpec as follows: be rspec -Itest test/*/_test.rb Or by Suite: be rspec -Itest test/unit/*/_test.rb be rspec -Itest test/functional/*/_test.rb be rspec -Itest test/integration/*/_test.rb Tests should also be executable with the Rails Rake test tasks. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	b9b920e1d5	Fix formatting (w/ Rubocop) in test-unit tests Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	7f9822224b	Use 1.9+ Hash syntax in test-unit tests Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Martin Linkhorst	97580671b0	remove mocha from OpenProject as we can use rspec-mocks nowadays :)	11 years ago
Philipp Tessenow	a1e67dd460	new copyright header #1903	11 years ago
Jens Ulferts	21459a384f	provide every possible file with a short copyright notice This was done using the rake task: rake copyright:update	12 years ago
Philipp Tessenow	f24dc2f4f1	attempt to fix a constant not defined error when executing mysql unit tests	12 years ago
Martin Linkhorst	d03301b60e	there are so many side effects by using only a subset of the fixtures and also it creates lots of annoying noise in the test code. this commit changes individual requires to :all which fixes some tests when test files are run individually or in a different order.	12 years ago
Martin Linkhorst	9afb247beb	deprecation: require 'mocha/setup' instead of just 'mocha'	12 years ago
Holger Just	91070236db	Set source encoding to UTF-8	13 years ago
Holger Just	07185fb169	[#436 ] Remove trailing whitespace	14 years ago
Eric Davis	99507a0391	[#197 ] Upgrade the copyright in the code files	14 years ago
Jean-Philippe Lang	d71f4f2ef5	Do not actually try to fetch changesets from the subversion repository. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@5156 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Jean-Baptiste Barth	17f86d964f	Use absolute paths in test/*/ requires for Ruby 1.9.2 compatibility. #4050 git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@4509 e93f8b46-1217-0410-a6f0-8f06a7374b81	14 years ago
Jean-Philippe Lang	cf9bb2699f	Adds on optional API key to repositories management controller and reposman.rb. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3201 e93f8b46-1217-0410-a6f0-8f06a7374b81	15 years ago
Jean-Philippe Lang	3d317a435b	Adds an action to SysController to fetch changesets of one or all projects (#2925 ). Exemples: * /sys/fetch_changesets (=> fetches changesets for all active projects) * /sys/fetch_changeseys?id=foo (=> fetches changesets for project foo only) git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@3107 e93f8b46-1217-0410-a6f0-8f06a7374b81	15 years ago
Eric Davis	7b0cb6aba8	Upgraded to Rails 2.3.4 (#3597 ) * Ran the Rails upgrade * Upgraded to Rails Engines 2.3.2 * Added a plugin to let Engines override application views. * Converted tests to use the new classes: ActionController::TestCase for functional ActiveSupport::TestCase for units * Converted ActiveRecord::Error message to a string. * ActiveRecord grouping returns an ordered hash which doesn't have #sort! * Updated the I18n storage_units format. * Added some default initializers from a fresh rails app * Changed the order of check_box_tags and hidden_field_tags. The hidden tag needs to appear first in Rails 2.3, otherwise it will override any value in the check_box_tag. * Removed the custom handler for when the cookie store is tampered with. Rails 2.3 removed the TamperedWithCookie exception and instead Rails will not load the data from it when it's been tampered with (e.g. no user login). * Fixed mail layouts, 2.3 has problems with implicit multipart emails that use layouts. Also removed some custom Redmine mailer code. * Fixed a bug that occurred in tests where the "required" span tag would be added to the :field_status translation. This resulted in an email string of: <li>Status<span class="required"> </span><span class="required"> </span> Instead of: <li>Status: New</li> git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2887 e93f8b46-1217-0410-a6f0-8f06a7374b81	15 years ago
Jean-Philippe Lang	59dec17ddf	Fixes a failure when running rake test:coverage. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2543 e93f8b46-1217-0410-a6f0-8f06a7374b81	16 years ago
Jean-Philippe Lang	8cf3d7a492	Replaces the repositories management SOAP API with a simple REST API. reposman usage is unchanged but the script now requires activeresource. actionwebservice is now longer used and thus removed from plugins. git-svn-id: svn+ssh://rubyforge.org/var/svn/redmine/trunk@2435 e93f8b46-1217-0410-a6f0-8f06a7374b81	16 years ago

9 Commits (466b77be0093ed8e667a6c42e7ddb331e7c4a59d)