openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	3f3e831f6a	Add any name attribute filter to principal resource collection (#9170 )	4 years ago
Benjamin Bädorf	64143001fc	Set moment locale globally (#9040 ) * Set moment locale globally This sets the moment locale to the application locale globally, ensuring that moment uses the right translation strings wherever applicable. However, since we only work with languages (en), and not real locales (en-US), the first day of year calculation has to default to some option. This commit defaults to ISO 8601 for every language and locale. * Add setting to mark dayOfYear * Fix NaN check * Add spec for switching settings * Output uniq github specs Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f50297227b	[34444] Projects copy APIv3 (#9149 ) * Create copy project endpoint * Add representers * Add _meta representer for copy module information * Add Meta payload representer * Extract parsing of copy attributes into service * Extract enqueue job for projects copy * Keep request object available in the bodied endpoint this allows us to access grape (e.g., for redirecting) * Add DelayedModify endpoint that redirects to job status * Use DelayedModify endpoint for copying projects * Add api paths for form/copy * Disable cache on ProjectCopyPayload * Add spec * Add resource spec * Extend schema for meta * Extend docs * Don't pass service result, but state as meta to forms * Use copy dependencies for naming copy options in API * Add description property for counting * Remove unused action attribute * Skip writable checks on meta property for payloads * Use prepend to allow create(...) usage with meta * Extend copy spec with custom fields usage * Add spec for copy flags * Add todos * Pass errors correctly to copy settings * Remove invalid parameters to copy that are now caught through project service * Remove duplicated validation * Linting * Make count a human readable, formattable description string * Make source count string readable * Provide the source project for generating the counts * Extract copying of attachments into sepearate dependent services This will allow the API to dynamically generate a copy association schema from each dependent service * Add spec for copy schema representer * Add payload representer spec * Also validate the model to pass the validations when copying * Make description optional and add note to schemas.apib * Add send_notifications to representer * Allow to configure sendNotifications * Allow bodied to receive a state process callback That allows us to manage the meta state on the API level, not on the service level * Make other services compatible with BaseCallable * Fix params passing from BaseCallable Wrapping a single hash into kwargs obviously loses their key indifference and we can't expect all services to use a single params object. Older services use kwargs * Copy wiki page with parent_id This will save some memory instead of memoizing the entire wiki page * Fix typo * Default to true for all copy associations That means if only a true value is passed, all other options will still be true * Do not try to copy attachments if the base dependency wasnt copied * Ensure null identifier gets rendered * Fix paths to the form and commit * Change redirect to an URL * Extend documentation on meta properties as table * Ensure we pass a default params if incoming params are nil Now that SetAttributes needs to splat params, they do no longer correctly get the no-param-default behavior of Ruby, so we need to explictly assign a default params hash * Fix expect for trailing path	4 years ago
ulferts	3d60d26d8c	replace legacy spec	4 years ago
Philipp Tessenow	bd906716e5	[#36153 ] link manually created pull request to a work package using the GitHub integration plug-in (#9070 ) * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment	4 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157 ) * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
Oliver Günther	8f5006a51b	Rename ActiveRecord class to UserSession for clarity	4 years ago
Oliver Günther	aeec219bfb	Fix connection being memoized in sqlbypass class	4 years ago
Oliver Günther	daa0cfdee9	Ensure we're not memoizing the connection (#9153 )	4 years ago
Oliver Günther	5744dcd422	Explicitly require and use Sentry::SendEventJob	4 years ago
ulferts	8f01fa7dab	add action filter to capabilities query	4 years ago
Oliver Günther	693d01f8c7	Bump Sentry and implement log handling in core (#9133 ) * Bump Sentry and implement log handling in core * Manually insert the sentry middlewares * Also add user locale as tags * Add performance tracing * Update sentry host to sentry2 * Update frontend sentry-reporter to the new sdk * Silence delayed_job's own logger since activejob logs already Delayed::Job will otherwise always log all arguments, which we disable by design * Remove default sentry host	4 years ago
Benjamin Bädorf	2667cd1581	Refactor/app header (#9110 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Basic BEM changes * Remove old classes * Update more classes * Update togling logic * Fixed menu opening and some styles * Added op-menu * Fix some help menu styles * Add op-menu to help menug * Add avatar border * Fix auth_provider_spec * Fix zen mode * Fix static link help menu * Fixed top menu specs * Fix self registration specs * Fix logout spec * Fix bim revit navigation spec * Fixed menu permissions spec * Fix homescreen onboarding tour spec * Fix top menu item spec * Remove unused file * Fix a lot of mobile styles * Fix more mobile styles * Fixed build * Move quick add menu to right hand side * Improve quick-add-button styles, fix main-menu-toggle close icon * Remove add new project spec * Fix spec * Update project dropdown styles * Fix click handler for chrome mobile, update some styles Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	18320fcae6	Fix styling of LSG [ci skip]	4 years ago
Oliver Günther	0d71772c37	User SqlBypass sessions to avoid ActiveRecord for session storage (#9142 ) * Use SqlBypass sessions to avoid ActiveRecord for session storage * Set default host if Capybara.app_host does not exist	4 years ago
Oliver Günther	af65092348	[36796] Don't seed groups if any other exist https://community.openproject.org/wp/36796	4 years ago
Oliver Günther	ac049663a3	Add multiple option for project custom fields (#9125 ) * Allow multi-select CFs for projects * Render multiple custom values in project row * Output arrays from custom_value_attributes for multiselect values * Add spec for copying multi-value cf * Fix custom field multiselect form on new custom fields * Fix custom field builder specs * Add spec for creating/updating projects with multi select * Add spec to create new multi select project cfs * Add spec for projects index displaying of custom fields	4 years ago
Oliver Günther	6944affca8	[35527] Add quick-menu to top menu (#9058 ) * [35527] Add quick add button menu in top menu * Add quick menu item to top menu * Refactor top_menu.sass to follow BEM * Only render project-based path if persisted * Render project types when in project context * Add headline and determine if any types are visible * Hide quick add menu for unauthorized users * Fix login menu dropdown by adding class * Add schematic for correctly generating components * Add augment service for triggering invite user modal * Fix allowed_to? check in menu * Add spec * Highlight types and show all * Fix help menu overridden * Extend spec * Add parent_id to project in dropdown and expand advanced settings * Reload the page if the modal returned any data * Fix invalid url allowed check if there is no URL to check * Restrict top_menu sass * Remove unused imports * Reduce required permissions to show quick add * Spec review feedback * Rename project fieldset ID	4 years ago
ulferts	4bf7a26eb1	Capabilities API (#9083 ) * Capabilities API * introduce auxilliary capability model * capability model and query * render in sql * fix pagination * introduce sql representer * extract abstract sql representer class * remove yet unused methods * abstract sql collection representer * contract_actions as part of permissions * filter for capability id - used in GET * id filter validation * remove unused representer * remove unused wp representer * reuse renaming class * add spec for access control * add principal filter to capability * add context filter * extract capability sql into scope * admin gets all capabilities * require to have one filter set to keep performance bearable * consider active project modules for capabilities * limit capability based on principal visiblity and user state * rework capability to be tableless * spec not being allowed to see on request level * add actions to capability representer * add action api * extract sql index endpoint * remove unused class * prepare sending signaling error - not yet frontend exposed * extract show endpoint for sql rendered responses * use UNION for better performance * include navigation links on collections * remove string replacements * extract collection representer into hal sql module * no capabilities when blocked * remove commented out code	4 years ago
Oliver Günther	065dfbddc4	[36467] Add API users form and schema endpoints (#9090 ) * Add Users form endpoints * Avoid cache_if as it caches properties for new_record? as well * Add specs * Add missing custom_field_values method * Fix missing firstname lastname api conversions * Disable cached_representer on user payload * Add patch to allow using our custom setter in case of nil values https://github.com/trailblazer/representable/issues/234 * Add test for changing status * Fix expectation with changed attribute mapping * Disable rendering name property for users The name property is not accessible directly for users * Fix attribute names for first and lastname for writable * Ensure password is marked writable even though its not an attribute * Avoid explicitly setting to_ar_name conversion * Reuse AssignableCustomFieldValues concern * Fix structure of users.apib to be flat * Extend requests with custom fields * Output name, but dont mark as writable attribute * Fix id indentation * Rename schema email property * Fix param for user update form * Fix schema docs	4 years ago
Oliver Günther	22f022ff82	[36596] Fix group assignee returned non-active users (#9111 ) https://community.openproject.com/work_packages/36596	4 years ago
Oliver Günther	673d8528c3	Reload work package before destruction (#9116 ) https://sentry.openproject.com/sentry/saas-openproject-prod/issues/12403	4 years ago
Oliver Günther	8f0dfb21d7	[36688] Set default locale before checking authorization (#9114 ) We do set the user's desired (from HTTP headers) or saved language preference, but that is called after `check_if_login_required` so in some cases we return before setting localization https://community.openproject.org/work_packages/36688	4 years ago
Oliver Günther	e7bcf3105b	[36548] Avoid using batch PDF export if pdfunite missing (#9098 ) * [36548] Avoid using batch PDF export if pdfunite missing We cannot guarantee that pdfunite is installed through poppler-utils, for example in unsupported distributions. In this case, we'll want to revert to the default export of all work packages. https://community.openproject.com/work_packages/36548 * Add dependencies for centos installations * Review feedback	4 years ago
ulferts	7e68bd8ce1	avoid nil for wiki page slugs as they would be invalid (#9081 ) * avoid nil for wiki page slugs as they would be invalid Also explicitly enables having "!" for a wiki title but fails hard for all cases, which are not handled by default or custom. * move legacy specs over	4 years ago
Oliver Günther	12ceb6e7ab	Fix message-id regex in mail_handler	4 years ago
Oliver Günther	c358b071c5	Fix message-id regex in mail_handler	4 years ago
Oliver Günther	134552e95c	[35853] Extract formatting in PDF export for custom fields (#9095 ) https://community.openproject.com/work_packages/35853	4 years ago
ulferts	a7835ac072	avoid projects being displayed twice	4 years ago
schuemann	b577ed62ec	[#36518 ] respect hide mail preference in member list (#9072 ) * [#36518] respect hide mail preference in member list The member table should hide the email address if the user has the "Hide my email address" box checked in their profile. * [#36518] respect hide mail preference in member list Updating feature spec * Updating feature spec * Add transient preference object * Include preference to avoid n+1 query * Correctly pass user_id= to super * Fix now invalid usages of user_preference factory * Rewrite attribute check to include user attribute_present? does not return true for relations such as user_id * Only save a preference if the transient factory got used Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	e9f1781d2b	Use contracted member services and show only manageable projects in user administration (#9076 ) * Reuse contracted services in memberships controller * Show only manageable projects * Show only manageable projects in select box * Reject empty values in role_ids * Add spec for when user has no manage_members permission * Also handle delete through service * Extend spec for when user has no manage_members permission * Extend Members SetAttributesSpec * Make manageable_Members an instance method and add spec * hide buttons if user is not allowed to use them * Rename manageable_projects to assignable_projects * Build a membership for the contract * Fix url for global_roles to work with update and create methods Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	a023ccf372	[36517] Fix placeholder filter returning query object, not AR collection (#9071 ) We depend on the query for correct sorting by name. https://community.openproject.com/work_packages/36517	4 years ago
Oliver Günther	d329db23ff	Finish user invite modal (#9061 ) * Fix some ium stylings * Extend create service to also test with empty names * Add PrincipalLike type to pass around non-created placeholder refs * Add icon-context * Move principal rendering to its own module * Fix emit create new placeholder to principals * Revert op-principal for now * Add memberships form API to properly post * Fix types for returned principals * Move untilDestroyed in role * Filter input if not string in role-search * Pass correct inputs to success component * Return principal after saving membership * Fix small stuff around the ium * Fix the way HalResources are selected and passed * Move principal module to be exported by common * Disable quotemark in tslint until eslint is enabled * Fix image path in success * Adapt modal to run all steps in one within the modal helper component * Several fixes to modals * Fix ium success component styles, * Registration modal y-overflow * Add SMTP parameters to .env.example * Add disabled option to op-option-list, disabled placeholder users for non-ee instances * Add correct ee link to placeholder user option * Fix build * Removed unused sass files * Fix principal search not found indicator, added placeholder add image * Fix enterprise edition url, use dirty instead of touched check * Use backend class names for frontend principal types * Fix duplicate import and principal type usage * Also disable banners if with_ee is present in test * Extend specs for placeholders * Fix disabled attribute * Extend spec WIP * Improved inline-validation styles, fixed more PrincipalType usages * Add group happy path test, fix more PrincipalType usage * Fix a translation * Revert line deletion * Rewrite same spec examples into shared examples * Fix name of shared example * Dont run assets:clean to remove angular assets * Output whether assets are there at all * Fix placeholder path * Revert "Output whether assets are there at all" This reverts commit `42219c2755`. Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	4 years ago
ulferts	f0cf90d7e1	Fix the rails cell not using the content_tag helper of ActionView with escaping (#9067 ) * fixes show links for project members * Properly escapes the name. The cells gem does not escape strings unlike rails * Fixes the case statement for links and includes the link for placeholder users * Fix escaping of content_tag in rails cell and add spec for that Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Wieland Lindenthal	355e9db913	Fix: #36302 I18n strings for placholder user EE banner	4 years ago
Wieland Lindenthal	905017f478	Fix: #36302 I18n strings for placholder user EE banner	4 years ago
ulferts	ab6d98383b	fix member filter on principals (#9063 ) In case of the `!` operator, other memberships interferred. This was because of the left join leading to result sets that where not of interest. The now used not.in does not have that problem	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
Wieland Lindenthal	c4c2149d98	Fix: 36299 -- Allow to modify login when global permission :manage_users present (#9026 ) * Refactoring: Create shared examples for user contracts * Users::UpdateContract spec added * Add spec for updating the login of a user * Add spec for permitted params when global permission to :manage_user * Remove spec for :login updates for user UpdateContractSpec The writability of the login attribute is not part of the contract (yet). * Use user contract for checking writability of user attributes * Fixing user contract specs. * use persisted user in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	935cd02d33	[36294] Show authentication header only when any partial matches (#9044 ) * [36294] Show authentication header only when any partial matches * use collection_select for collection Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	0fa8b4a77b	Forward CSP extensions to login controller (#9047 ) * Forward CSP extensions to login controller * Extend spec for double auth code * stabilize spec On my machine, since I have an s3 bucket configured, the spec failed Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	65575d44f1	[36415] Add public filter to projects list (#9057 ) https://community.openproject.com/wp/36415	4 years ago
Aleix Suau	44cf9e0c5e	Epic/placeholder users frontend (#8977 ) * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Open invite user modal from user selection * Remove console and debugger calls * Opening modal from CreateAutocompleterComponent * Add new button added to select-edit-field * Permissions Service + show button if canInviteUsersToProject * Permissions Service + show button if canInviteUsersToProject * Codeclimate and TSLint errors * Failing test commented with TODO * Codeclimate fixes * Codeclimate fixes * Add initial invite user modal * Small change to invite user modal * Small use rmodal changes * Builds * Added invite user modal title translation * Changed modal to module * Figured out basic modal setup * Fixed build * Started adding option-list component * Adding reactive forms * vim * Reactive forms working for option-list * op-form-field is implemented, project-selection step works * Working on principal step * Basics of principal selection are done * Remove console logs * Added role step and role api bindings, updated directory structure * Added basics of message step * Added summary page * Add in-project check for selected principal * Add documentation for principal filters * Create modal-heading component * Fix principal emit * Add API calls to summary component * Work on translations, rework close fn * Added translations * Fixed styling * Add autofocus, fix typing * Improve typing * Add form-binding directive to fix form-field * Fixed typescript errors * Fix more translations * Refactor/op modal (#8978) * Initial modal refactoring * Updated modal imports * More modal module imports * Fix one more import * Fixed some styles * Fixed failing modal specs * Fix more spec selectors * Fix more specs * Updated backend modals * Improved code style * Fix export modal styles * Fix wiki export modal * Fix more specs * Fix webhooks modal * Added loading indicator back into modals * Fixed wp preview modal * InviteUserButtonComponent in * InviteUserButtonComponent in * InviteUserButtonComponent in MultiSelectEditFieldComponent and SelectEditFieldComponent * Remove extraneous module * Add Dragula import * Remove empty spec * Fix option-list component * Remove group creation from invite user modal * Write feature spec * Fix TS errors * Add Placeholder and Group apis to the frontend * Better api typing * Remove unnecessary interface * Remove group creation call Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com> Co-authored-by: Oliver Günther <mail@oliverguenther.de> Co-authored-by: Benjamin Bädorf <hello@benjaminbaedorf.eu>	4 years ago
Oliver Günther	8122d05a66	Add visible scope for placeholder users (#9042 )	4 years ago
ulferts	b8ca382d34	Group API (#9034 ) * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
ulferts	55acf25277	fix saving work package general settings	4 years ago
Oliver Günther	37bef43cea	Introduce visible scope to principals When a user has the manage_users permission in any project, they are eligible to view all users for inviting them to the project. This however is not reflected in the principals API, where only users in all visible projects are found.	4 years ago
Oliver Günther	34f8e9dff8	Validate admin guard for all settings writers (#9012 ) * Validate admin guard for all settings writers * Add spec to test access to all links under admin * Fix broken specs * Keep only UpdateContract and add spec * Move admin settings under their own namespace for clarity Move all admin related settings under ::Admin::SettingsController * Fix more paths and views for settings Adds another spec to ensure all links in admin can be viewed by admin * Fix wrongly changed settings path for repositories page * Use plugin name for plugin settings	4 years ago
ulferts	9edf745085	Fix/group mention links (#9036 ) * turn group mentioning into link * add profile button to group edit page * Include built ckeditor Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago

1 2 3 4 5 ...

18531 Commits (46b85e5a47f01c25250df8df39057f8d54a92a2f)