openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	4980b4fb4a	Allow LDAP filters and groups to individually sync users (#9031 )	4 years ago
Oliver Günther	9acd19de46	Revert removal of groups XML responses (#9024 )	4 years ago
ulferts	e832e626ab	use actual user display setting name `login` does not exist, `username` does	4 years ago
Wieland Lindenthal	ffa5ac84a8	Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018 ) * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	af35670694	Make placeholder users EE (#9003 ) * Add global permission to manage (but not delete) placeholders https://community.openproject.com/work_packages/35508 * Show EE upsale and disable creation of placeholders without it * Review feedback	4 years ago
ulferts	244eae534e	display postgresql version No longer displaying the database name as that will always be the same	4 years ago
Oliver Günther	bbeae32698	[35508] Add global permission to manage placeholder users (#9000 ) * Add global permission to manage (but not delete) placeholders https://community.openproject.com/work_packages/35508 * Restore breadcrumbs for non-show routes * Remove permissions to memberships for add_placeholder_user permission * Allow non-admins with global permission to access membership * Remove permissions to memberships for add_placeholder_user permission * Rename shared_examples for admin contract validations Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007 ) * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	47d4bdd036	Ensure before_actions are executed for settings writers	4 years ago
Oliver Günther	5f8a9a1868	[35157] Fix backlogs settings validations to disallow task = story (#9009 ) Refactors the settings controller into its own controller to allow checking the parameters before saving. Also removes a JS snippet that is no longer being executed since CSP is enforced. https://community.openproject.com/wp/35157	4 years ago
Oliver Günther	0c9fb9b1af	[36206] Make force_no_page for ldap configurable https://community.openproject.com/wp/36206	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Markus Kahl	2cab0bedd7	CustomStyle uses this uploader and doesn't have a content_type method.	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	109ade62da	Allow editing auth_source as a global user (#8954 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
Oliver Günther	a65992c354	Allow placeholder and group assignment to custom field (#8972 ) * Allow placeholder and group assignment to custom field * Review feedback	4 years ago
ulferts	e9692f85a5	add filtering for assignee with placeholder users	4 years ago
ulferts	441bb340ff	allow pageSize = 0 on manually sorted queries This allows fetching the query without the added burden of having to render the work packages. Rendering the work packages increases the response time heavily.	4 years ago
Oliver Günther	15a2716d95	[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976 ) * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods `5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190)` * turn scope classes into modules	4 years ago
Oliver Günther	e484804645	[35506] Avoid notifications for assigned/responsible placeholders Right now, placeholder users cannot be watchers nor authors nor meeting participants, so the only notifications that can happen are work package assignees or responsibles. https://community.openproject.com/wp/35506	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	32d4af0bba	Restore users/new toolbar	4 years ago
Wieland Lindenthal	3044b5ce5e	Align ModelContract validate/valid? methods with ActiveModel::Validations (#8955 ) * Align ModelContract validate/valid? methods with ActiveModel::Validations * Add BaseContract to allow contracts on non ActiveRecord resources * Avoid using alias_method as that won't work with subclasses Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	4d17b19783	[36026] Ensure project filter only searches for active projects https://community.openproject.com/wp/36026	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	e4c9506e56	[36081] Increase max lengths of user/group names (#8948 ) * Unset DB limits for user attributes * Validate groups in synchronized groups * Extend limitations and fix specs	4 years ago
Oliver Günther	769be47723	[35815] Add visible show page for all users to groups (#8949 ) To that end, move the show group routes out of /admin, that requires we use a different path helper for it as `group_path` will still link to the first admin resource.	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935 ) * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit `d93ff52a27`. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Markus Kahl	1c8aaf031f	Maintenance: ruby patch level update to 2.7.2 (#8951 ) * Update ruby to 2.7.2 * make sure to pull latest base image * minor comment update	4 years ago
luzpaz	4ff8169d33	FIx typo nucleous-> nucleus in app/ and modules/ (#8947 )	4 years ago
Markus Kahl	af48244ffd	make download URL expiry configurable, use safer default	4 years ago
Markus Kahl	51a40c97eb	set content type of attachments in S3 (#8938 ) * set content type of attachments in S3 * refactoring to allow amending and reading given metadata more easily * confirm attachment content type is sent to S3	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	8af2d6e582	fix version links on roadmap (#8936 ) * adds an id to the version link to be anchorable * adds an achor element to the link in the version list * whitelists the possible filter parameters for the version list links The solution has an insufficiency in that the browser unnecessarily reloads the page if the user had filtered before and then clicks on a link. I find that acceptable.	4 years ago
ulferts	2744673ec8	avoid updating the lock version on finishing an attachment upload (#8934 ) If the lock version is increased, it might happen while the user is still editing the description. The user might have added an image to the description and continues typing. In the backend, the FinishDirectUploadJob is run before the user presses the checkmark to send the updated description. In that case, a 409 conflict would be signaled if the lock version were to be updated in the meantime.	4 years ago
ulferts	38cae188ad	Fix/journals on direct uploads (#8933 ) * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file * correct journalizing on direct upload In case the container of an attachment is journalized, the container needs to have added a journal to it when an attachment is uploaded. Without that, the attachment is only picked up in the journals once the container is altered again (possibly by a different user). This will then lead to a history which does not reflect the actual upload.	4 years ago
ulferts	4ad9ebc6ee	Fix/filename on direct upload (#8928 ) * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file	4 years ago
Oliver Günther	abe024ec7f	[35949] Allow to override priority in incoming mail (#8930 ) https://community.openproject.com/wp/35949	4 years ago
Oliver Günther	4e21801ef5	Do not include global roles in memberships list (#8931 ) With a user and a global role set, the users/show method will fail as it tries to render a project for every membership.	4 years ago
ulferts	4d7d1cb791	prevent css styles of form--section to affect table (#8926 ) In the summary page, the report tables are wrapped within a div with the form--section class even though those reports are not actually part of a from. Ideally, a new class would be styled containing only the desired css rules. But as the view is deemed to be replaced anyway, the quick and dirty way is to simply take the table out of the form--field's dom structure	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	7e10047827	Fix removed LdapError error class	4 years ago
ulferts	58870a5406	correctly use attribute reference on I18n.t	4 years ago
Oliver Günther	0740070bca	By default, do not log arguments to background jobs	4 years ago
Oliver Günther	1ef61291f1	Bump Angular to 11.0 (#8913 ) * Bump Angular to 11 * Bump fullcalendar * Bump uirouter * bump typescript and rxjs fixup! bump typescript and rxjs * Run angular update migrations * Fix deprecated options in serve, they are kept in builder * Replace node-sass with sass and fix errors * Include all ts files again to fix warnings We have scripts that should be contained but are only loaded dynamically. It seems this trips up TS to print warnings that these files are unused, which they really aren't. * Address typescript compilation errors and warnings due to 4.0 upgrade * Link to styles.css not js with updated sass * Only reposition dropdown if appendTo is set * Initialize resource property in edit field component Correctly update field component and handler properties Always use the changeset schema Fix removed property in custom text	4 years ago
ulferts	bf6d0c727a	fix scheduling bug if predecessor dates are removed and follower only has due date set	4 years ago
Markus Kahl	652dbcc1ad	handle missing ImageMagick convert binary	4 years ago

1 2 3 4 5 ...

18531 Commits (46b85e5a47f01c25250df8df39057f8d54a92a2f)