90 Commits (48591e9bbdc83e7836a8f72f2d3da2b59501e3ef)

Author	SHA1	Message	Date
Oliver Günther	32472da1dd	Enforce strictNullChecks	8 years ago
Oliver Günther	d4885439f0	Enforce noImplicitReturns	8 years ago
Oliver Günther	e8595ac0a3	TypeScript: Enforce noImplictAny	8 years ago
Oliver Günther	0330ca3d96	Remove $broadcasts for dropdowns/context menus	8 years ago
Oliver Günther	056412263b	Editing functionality WIP	8 years ago
Roman Roelofsen	beadcc8b38	Refactoring: angular-rx-utils: ... - observe() -> observeOnScope() - added observeUntil()	8 years ago
Oliver Günther	25bbf71622	[24366] Show hidden fields as empty and forbid editing in table	8 years ago
Oliver Günther	2e51c140ad	Avoid additional watcher on display fields ... We can now simply wait for the cache service to return the WP + loaded schema	8 years ago
Oliver Günther	3b9b487406	Autoload the schemas from the schema states	8 years ago
Oliver Günther	611e42238c	[23896] Submit and close edit mode on enter for most edit fields ... When editing a single field (except select, checkbox), pressing enter triggers the `submit` handler of the surrounding form. This form submit is disabled when in edit mode, since the wp-edit-field uses that submit also for saving on blur, which we deliberately disable in this case. We can instead capture another event on those fields where it makes sense that submits the field after pressing enter, but only IN edit mode (since without it, submit handles it). https://community.openproject.com/work_packages/23896	8 years ago
Oliver Günther	d140d9616f	Notify click dropdown handlers even when click event not propagated ... [ci skip]	8 years ago
Henriette Dinger	52e53e09f3	Delete pristine value after cancel	8 years ago
Roman Roelofsen	62c5823d74	Use reactive fassade for the wp cache service implementation	8 years ago
Oliver Günther	5189dc9031	Workaround for Firefox blur event happening right after opening a field	8 years ago
Oliver Günther	3bba3c2c29	Fix occasional non-opening of edit field	8 years ago
Henriette Dinger	1fda26ca20	Focus first field when editing a WP	8 years ago
Markus Kahl	ef523d1e1e	only prevent hiding for fields with focus	8 years ago
ulferts	6a3496d26e	prevent editing a work package while saving takes place (#4658) ... Otherwise, especially in IE with their custom change handler for select boxes, it was possible to make a change, trigger saving and while saving takes place, change another attribute and change that. Only the first change would work while the second would fail because of optimistic locking.	8 years ago
Henriette Dinger	f99958aa68	Set focus after submit (#4550)	8 years ago
Oliver Günther	62ca484428	Allow tab read-only display fields, but highlight them ... This styles the background of read-only values when focussing or hovering them. Also, all fields regain a tabindex value of 0 to make them reachable. https://community.openproject.com/work_packages/23546/activity	9 years ago
Jens Ulferts	bc02799de9	allow refocusing when field is errorenous	9 years ago
ulferts	6ed3160937	do not focus an already active field (#4567) ... Otherwise, changes to a resource will lead to a reinitialization which will lead to a refocus	9 years ago
Jens Ulferts	4b06a41ba3	provide api independent error message for date format errors	9 years ago
Jens Ulferts	124987499a	submit date on blur when in accessibility mode ... As the accessibility mode has no date picker, we can submit it right away	9 years ago
Oliver Günther	74b52eaab8	[23300] Fix date fields not being updated (#4556) ... * Fix date fields not being updated For Milestone rows, start and due date are both mapped to `date` and thus collide with the wpEditForm#callbacks helper that propagate changes from the `wpCacheService` down to edit and display fields. This fails to update the last field since they registers callbacks based on their attribute name. This commit instead suggests to use the wpCacheService directly, since the scopedObservable will handle deregistration correctly on its own. * Remove no-longer-required wpEditForm	9 years ago
Jens Ulferts	ea745865ad	remove focusability/role on non editable elements	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529) ... * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
ulferts	cbd33707b8	don't submit field if we already know it to be erroneous (#4525) ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
Jens Ulferts	48200d3a5c	don't submit field if we already know it to be erroneous ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
ulferts	76e2a5e0ce	submit on user blur (#4513) ... Will also submit the work package when clicking somewhere else (blur).	9 years ago
Jens Ulferts	3bfc489a8e	remove html-class setting already present in the template ... There is already an ng-class statement setting the desired class upon editability. As the wp-edit-field directive is applied via an attribute, the $element is the dom element the directive is an attribute of. That way, the -editable class is applied twice.	9 years ago
Roman Roelofsen	e0bf811f77	Reduced watchers count, needs review!	9 years ago
ulferts	48ac7aa6f4	introduce strategy for displaying fields (#4469) ... In order improve the code structure and in order to enable plugins to add display strategies for fields, that are not covered by the core yet, a strategy pattern is introduced for displaying fields. The mechanism is identical to the way EditFields are handled. In fact, the DisplayFields and EditFields now inherit from a common superclass, Field. Also, the service and the factory inherit from a common superclass.	9 years ago
Oliver Günther	c223d6f108	Explicit setter for wpEditField.workPackage	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up ... The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	6589b6ba50	Initialize edit field when work package is updated in cache	9 years ago
Oliver Günther	ef94a15660	[23120,23121] Add required fields, labels to wp-edit-fields (#4421) ... * Add default label (name) to fields * Mark fields as required when schema says so * Work around xvfb :invalid state	9 years ago
Oliver Günther	9c7a368c05	Fix description focussing	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Oliver Günther	2bdf6ac776	Remove invalid description spec	9 years ago
Oliver Günther	a1755f3ef3	Avoid click propagation from active edit-fields (#4428) ... Avoid clicks within the form to bubble up to the row handler. Otherwise, clicks within wp-edit-fields may cause the split / full view to open.	9 years ago
Oliver Günther	5da8c31f40	Fix switching types in Edit all mode	9 years ago
Oliver Günther	760fc47c7f	Fix focus on first element on create	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed ... This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	b849514904	Separate methods for entering/cancelling by user events	9 years ago
Oliver Günther	426876a264	Fix enabling fields by default when switching	9 years ago
Oliver Günther	cd17492a44	Save $pristine values in work package resource	9 years ago
Oliver Günther	d34799a89a	Edit all on fullscreen view	9 years ago
Oliver Günther	650b5f4159	Implement edit-all through wpEditForm	9 years ago