164 Commits (4c6b3f7c0fc7ed1fe0af8715d9f57b0bbe1638e4)

Author	SHA1	Message	Date
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	8370c3099e	avoid n+1 queries on query requests by caching	5 years ago
Oliver Günther	a6a4031aa2	[31667] Fix ambiguous reference to project_id when group/sort ... Properly reference project_id to avoid ambiguous references to project_id when grouping by project_id and sorting by priority https://community.openproject.com/wp/31667	5 years ago
ulferts	aa3698d061	fix summing custom fields on wp table ... Before the fix, string values where returned and then the `+` method was called which lead to the strings being concatenated. A subsequent call of `integer?` failed. The fix performs the aggregation in the database which is not only correct then but can also be carried out considerably faster. The drawback is, that the casting breaks the abstraction introduced by the cf strategies	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	c4dc6e2c91	ensure sums are also sorted by group_by column	5 years ago
Oliver Günther	64e6fae1b8	[30442] Use formatted custom value in xls export ... This also fixes localized output of custom fields such as float https://community.openproject.com/wp/30442	5 years ago
Oliver Günther	731bbd4104	[30763] Use stable sort for manual position ... Only moved items are being sorted, to avoid sorting the entire page when that is not yet necessary. This is a design decision to ensure only the minimum number of positions are being assigned and helps when sorting a restricted set of work packages from a bigger set. To avoid having ambiguous sort results, ensure a second sort parameter by ID. https://community.openproject.com/wp/30763	5 years ago
Markus Kahl	cb6d28136d	allow editing estimated time for parents, show derived separately	5 years ago
Markus Kahl	530aa631d5	don't count children twice when summing estimated hours	5 years ago
Oliver Günther	7ac2805779	Save integer relative positions by computing spaces between	5 years ago
Wieland Lindenthal	1e3fe98640	Respect custom field attributes "is_filter" and "searchable" within the SearchFilter	5 years ago
Wieland Lindenthal	83c72b549b	Let Global search also search within custom fields of type string or text.	5 years ago
ulferts	5edb64b2df	use default filter behaviour for wps available for relations ... That way, we can treat the end point as just another wp endpoint with filter capabilities. Currently, there is a couple of custom logic still present but that is only due to wanting to not break the public API. In the long run, the whole end point could be removed as the same filtering is now available using /api/v3/work_packages with an appropriate filter.	6 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308) ... * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Henriette Dinger	1be834f382	Remove option to disable type highlighting in the WP table	6 years ago
Oliver Günther	d997d003a6	Fix duplicate join alias name	6 years ago
Oliver Günther	595a664753	[29683] Fix order statements of CF list ... Custom fields of type list have been refactored quite some time ago to contain a reference to a `custom_option` in their `custom_value.value`. The sort statements still sort by the `custom_value.value` without joining properly, which results in sorting the internal IDs and not the correct positions. https://community.openproject.com/wp/29683	6 years ago
Wieland Lindenthal	c4ac3aede2	Remove unused `joins` method	6 years ago
Jens Ulferts	17023c9394	optimize search filter by moving condition to join criteria	6 years ago
Oliver Günther	622e73664d	Remove hierarchy paths and migrate away from parent column	6 years ago
Oliver Günther	1cd325bd5a	Ensure sql join in manual filter and sort column is isolated in query ... We depend on ordered_work_packages association for determining sort and filter for manual sorting. We could restrict the join result with where(query_id: context.id) later but that prevents the execution planner from optimizing on the explicit join clause. This PR introduces a sql join that depends on the query_id and thus retrieves the correct order performantly.	6 years ago
Oliver Günther	8ab4f2a663	Boards module (#7008) ... * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Push boards on grid * Use base class in scope [ci skip] * Extend api for options * Hack spike to show D&D use case [ci skip] * Add ordered work packages * Save order on existing work packages * Boards WIP * CDK drag * Add dragula handler [ci skip] * Add filter to return all manual sorted work packages * Print icon on hover * Boards routing and list components * Better loading indicator on list with streaming result [ci skip] * Add new board and list buttons [ci skip] * Post new query [ci skip] * Added creation of new board lists with persisted queries [ci skip] * Render placeholder row in empty queries [ci skip] * Save queries in grids [ci skip] * Renaming queries [ci skip] * Add existing work packages to board [ci skip] * Introduce card view component for work packages * Extend grids to allow project scope for boards (#7025) Extends the grid backend to also be able to handle boards. In particular, it adds the ability of boards to be attached to projects and changes the page property of grids to a scope property that better describes that more than one board can belong to the same scope (e.g. /projects/:project_id/boards). For a fully featured board, though, widgets need to be able to store options, so that they can store queries. Those widgets might also need to have custom processing and validation. That part has not been implemented. * introduce project association for boards * have dedicated grid registration classes * update and create form for board grids * extract defaults into grid registration [ci skip] * Add drag and drop to card view [ci skip] * Add options to grid * Fix option migration name * Renaming boards [ci skip] * Frontend deletion of boards * Avoid map on NodeList which doesnt exist [ci skip] * Add inline create to boards [ci skip] * Smaller create button [ci skip] * Add navigation for boards * Make inner grid same height * Replace index page with table * Workaround for widget registration [ci skip] * Fixed height for cards and tables [ci skip] * Implement escape as cancel d&d action [ci skip] * Fix and extend grid specs for name and options * Extend board specs for required name * Fix migration for MySQL references https://stackoverflow.com/a/45825566/420614 * Make board list extend from widget Since we cannot configure widgets yet, it's not yet possible to use a board-list widget anywhere. * Fix specs * Fix escape listener removal [ci skip] * Fix renamed to_path in relation spec [ci skip] * Allow deletion of grids for boards * Avoid reloading resource multiple times with replays * Frontend synchronization on deletion [ci skip] * Delete through table * Use work packages board path * Use work packages board path * Fix augmented columns breaking re-rendering * Fix duplicated permission with forums * Strengthen tab switch in specs * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * private queries * Add hidden flag for project-context queries Allows the API to create a hidden query that will not be rendered to the user even if it is within a project context. * Move boards below work packages * Add Board configuration modal * Fix reloading with onPush * Saving / Switching of display mode [ci skip] * Extract wp-query-selectable-title into common component * Fix renaming of board-list * Fix auto-hide notifications in boards * Add permissions to seeders * Reorder lists in board * Linting * Remove default gravatar from settings * Show assignees avatar in the card view of WPs * Fix specs * Add missing method * Fix timeline icon * Use URL as input to be able to show avatars for groups, too * Fix test * Add further specs * Use correct data attribute to avoid unnecessary data base calls * Add further specs * Deletion of board lists * Pass permission via gon to decide whether we can create boards * Fix rename spec * Cherry-pick of 7873d59 and 30abc7f	6 years ago
Wieland Lindenthal	b060d83412	Feature/29218/search autocompleter (#6942) ... * Search autocompletion on work package subjects * cleaning up * Add status dot to autocompleter results * Add feature test for global search autocomplete * fix: remove update at from suggestions * Style search autocompleter results * fix: loading animation position * Extend search autocompletion to also search on work package IDs, too, allowing even the hash sign (#) to prefix an ID. * Move stop spinning into a separate method. * increase delay for search autocomplete * Travis debugging: reverse order of expectations * Travis: fix specs for search autocomplete * Fix spec for search auto completer * Ensure WP highlighting is always loaded, when needed. * fix spacing between animated bars of loading indicator [ci skip]	6 years ago
Wieland Lindenthal	bb1f09e9c5	Fix filter_configuration to always the `list` array	6 years ago
Wieland Lindenthal	c830c62177	- Move Or-logic to a Mixin instead to a base class. ... - User more solid FilterConfiguration	6 years ago
Wieland Lindenthal	fdb5fa7eac	Move `includes` method to OrBaseFilter.	6 years ago
Wieland Lindenthal	05bd97d877	Refactor SearchFilter to inherit from an OrBaseFilter	6 years ago
Wieland Lindenthal	5f72c654e9	Satisfy CodeClimate	6 years ago
Wieland Lindenthal	d800854de0	Fix bug. Wrong operator was set.	6 years ago
Wieland Lindenthal	ce6c208e7e	Add CommentFilter and include it into SearchFilter	6 years ago
Wieland Lindenthal	a48ef771d3	Add operator "everywhere" to SearchFilter. ... Remove duplicate listing of NotEquals operator.	6 years ago
Wieland Lindenthal	ee1fc0b34b	Fix SearchFilter input to be text	6 years ago
Wieland Lindenthal	2a47d8f512	Refactor SearchFilter to combine other filters.	6 years ago
Wieland Lindenthal	c64cbc38d1	Add DescriptionFilter for work packages	6 years ago
Wieland Lindenthal	4fc70d8951	Create SearchFilter on work packages that searches on: ... - subject - description - attachment file name - attachment file content	6 years ago
Oliver Günther	1d65582a50	[29184] Validate with old parent templated value ... https://community.openproject.com/wp/29184	6 years ago
Jens Ulferts	de2735f797	implement time entries widget	6 years ago
Oliver Günther	f86abae9eb	Enforce Arel.sql for string order, pluck	6 years ago
Wieland Lindenthal	fd88776ceb	Add relations tables to Types via form configuration (#6773) ... * WIP: PrecedesFilter and FollowsFilter for WorkPackages * Create Type Form Groups per Query Type * generalize filters on relations avoiding alias * fix flickering spec * Rename dependency represeners for Follower and Predecessor Filters * Allow configuring templated queries within query configuring modal * Use `{id}` as templated value, instead of a now deprecated `templated` string * Rewrite ParentFilter to follow same structure as other relation filters. * Set Follower and Predecessor filters as hidden in Frontend * Default query shall show closed WPs, too * Remove relation filter type selection from form configuration view as we extend query configuration modal instead. * Allow ExternalQueryConfiguration to be more specific and prepend relation filters in its modal. * Quick unrelated fix on the way: the instruction text should start below the columns input and not to the right of it * - Add all missing relation filters. - Use verbs for naming instead of nouns to stay consistent with UI. * fix typo * Add relation filters to hidden filters and fix a rebase bug * Typo in docs * Fix broken rebase conflict resolution * Add part of and includes filter * adding specs for relation filters * rename RelatesFilter to RelatesToFilter * Rename shared example as direction does not matter anymore. * Fix spec for IncludesFilter * Fix name conflict for `includes` by calling typed_dag's `direct` later. * Fix shared filter examples as the parent filter does not get added per default anymore. * Fix spec after renaming PredecessorFilter to PrecedesFilter * Fix integration spec for type configuration form * Add filter dependency specs * Differentiate between WorkPackageFormChildrenQueryGroup and WorkPackageRelationQueryGroup types * Create inline-create for relation tables * Rewrite filters to use actual relation_type as key * Reload relations on change, change symbols * Fix relation filter i18n strings * Test presence of all relation filters frontend. * Extend integration test for form configuration to not only cover hierarchy, but also undirectional and directional relation types. * Consistent naming of filter dependency representer files * Satisfy codeclimate * Add missing copyright notes * Fixing PartofFilter and its specs * Reverse relation direction when created inline * WIP integration test for Relation Query Component and Children Query Component. * Correctly reload children tables when refreshed * Fix FilterOnUndirectedMixin * Fix removing of relation from embedded table after reload * Adding intergration tests for removing and adding relation or children, initiated form either embedded table or relations tab. * Fix specs * Fix implementation of duplicates and duplicated They are reversed in typed_dag and causes confusion [ci skip]	6 years ago
ulferts	4209539da9	Feature/angular calendar (#6766) ... * replace rails based calendar with angular * render empty calendar * update query on month switch * introduce specific interval filter * show colors * remove now unused filter partial * start on retaining the view in the url * hide datesInterval filter * I18n for calendars title * stengthen explicity of expected filters * spec moving to the next month * fix FilterSerializer reference * remove outdated feature spec * rework calendar controller specs * avoid undefined columns * bump ng-calendar to 1.7.0 * Revert "fix FilterSerializer reference" This reverts commit 2bb2e574cdd664a02a4eb9c3e94b5a170aec0a67. * Revert "avoid undefined columns" This reverts commit bcbb381b34b095526d3ee1aa15d6263a658c03c0. * load initial query only after calendar has been loaded * implement month remembering * implement history back and forth * cleanup code * remove unused methods * remove order value from filters * replace rails calendar widget completely * fix shrinkwrap * move module into correct namespace * linting * remove unused js * calculate full calendar height dynamically * setting calendar locale from service * retain week on reload * show notification in case of too many results * show tooltip on hover * go to work package on click * deactivate tooltip before wp show * narrow down style to tooltip * [28885] Improve html title consistency when navigating to queries Currently, query names are not reflected in the HTML title. This results in 'wrong' titles being shown when entering a split or full view and then returning back to the list. https://community.openproject.com/wp/28885 [ci skip]	6 years ago
Jens Ulferts	eb726a41a8	provide the query as context for cf filters ... This is important e.g. * when determining validity of filter values * when querying for valid filter values in the filter schema representers	6 years ago
Oliver Günther	1a8090402f	try to save highlighted attributes	6 years ago
Oliver Günther	6541cbe073	Add highlightable column	6 years ago
Jens Ulferts	98ed6b521c	allow filtering by accountable group	6 years ago
Oliver Günther	14fd7d2eb4	[28475] Fix usage of value objects in subproject filter ... https://community.openproject.com/wp/28475	6 years ago
Oliver Günther	1c0a3cf82b	Avoid plucking only :id on a mapped query that orders by name ... This will fail in postgres	6 years ago
Oliver Günther	aae558cc7a	[28448] Avoid running into nil project on validation check ... The `Subproject` filter controls through `applicable?` that it is not applied to a valid subset when the given project is nil. However, when testing an existing query where the project is no longer existing (deleted, e.g.,), the filter validation will try to access `values`, which in this case runs into a nil project. We may want to consider moving this into a higher place, e.g., not running all validations when the filter is not `applicable?` https://community.openproject.com/wp/28448	6 years ago
Jens Ulferts	fa2b0fa1d9	clean up templated filter values	7 years ago