openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	e9d7c374cc	[37868] Whitelist for attachment mime types and extensions on upload (#9431 ) * Add setting for whitelist * Make attachments API BaseServices compatible * Add prepare service and contract * Correctly pass the filename to the UploadedFile * Add presence check to filename * Fix expected validation message * We no longer raise a multipart error when metadata is empty * Fix filesize validation on prepared uploads * Add parser error if invalid metadata json * When attachment is not saved, use filename property * Return correct error message on JSON parser erroro * Fix specs * Use attachment upload representer * Fix direct uploads mocks with new service layer * Lint * Fix export job using attachment service * Fix IFC controller using attachment prepare service * Fix export job * RenameRename params_getter to params_source * Fix mail handler using attachment service * Fix usage of attachment create service in documents * Reuse shared examples for document attachment spec * Fix stubbed attachment service in export job spec * Use admin user in backup spec * Fix export job for bim * Fix attachment integration spec * Fix issues_controller spec * Make budget resource spec reuse common examples * Fix attachment parsing representer spec * Replace prepare part of attachment spec into separate service spec * Clear cache for login spec * Convert document create/update into services * Budget services * Allow options to be passed to property twin * Remove setting author on budget initialize * Replace meetings update with services * Replace ifc models attachment handling with services * Don't check uploader if changed by system * Fix uploader being changed by system * Replace wiki page attach_files with attachable services * Replace avatar saving * Replace snapshot attach_files * Skip double validation when container present * Set snapshot through attachment service * Remove attach_files * Validate content type in contract * Enforce writing the content type without accepting user input * Expect changed content_type * Fix content of viewpoint image to get correct content type * Fix tsv spec * Add create contract spec * Bypass whitelist in internal services when conflicting with user * Fix expects in specs after whitelist bypass * Render contract errors for wiki * Add before_hook to bodied to allow to pre-authorize permissions * Budget errors from contract * Document errors from contract	3 years ago
ulferts	df5f899b2f	Fix/bump gems (#9435 ) * bump aws-partitions * bump dry-inflector & faraday & faraday-httpclient & faraday-patron & mime-types-data * bump newrelic_rpm * bump oj * bump rake * bump rdoc * bump rubocop * bump rubocop-rails * bump rubyzip * use rubocop-1-18-2 on codeclimate * remove rewrelic * bump oj * bump addressable * sentry-delayed_job & sentry-rails & sentry-ruby & sentry-ruby-core * bump danger * bump aws-partitions * bump git * use rubocop-1-18-3 on codeclimate * bump aws-sdk-sns * fix rubocop rule for Rails/ContentTag * bump aws-partitions * bump aws-sdk-core & aws-sigv4 * bump dry-core & excon * bump faraday & faraday-net_http_persistent * bump git * bump oj * bump parser * bump rake * bump recaptcha * bump rubocop-rails * bump sentry-delayed_job * bump sentry-rails * bump sentry-ruby & sentry-ruby-core * use rubocop-1-12-1 on codeclimate	3 years ago
Benjamin Bädorf	e87c9f94c4	Load full HAL collection resources (#9383 ) HAL Collections only load the first pages when `$load` gets called. This means that parts of the application that rely on the full list being available fail. One example of this are the multi select filters, specifically for users; only one page gets loaded initially, so when searching for users you don't see the full list. On large instances, this could result in long loading times. Though the calls are fully async and the UI will not block, this might surprise some users since we do not show a loading indicator. A better fix would be to rewrite the filter-toggled-multiselect-value component, but after an initial inspection this would require a ton of work. Long term, we're looking at removing HAL classes altogether, so if the loading times are reasonable this could be a reasonable workaround. Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	18553501dd	[32643] Use the watchdog feature of CKEditor to report errors (#9444 ) * [32643] Use the watchdog feature of CKEditor to report errors https://community.openproject.org/wp/32643 * Don't pass in original config as it's being cloned	3 years ago
OpenProject Actions CI	b5546e10d7	update locales from crowdin [ci skip]	3 years ago
Birthe	452df1fc8e	Updating texts for onboarding tour (#9393 ) * Updating texts for onboarding tour [#37656] Online Trial - Review onboarding guide -… …Demo project - English https://community.openproject.org/work_packages/37656 * Fix spec Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	dd9594bf13	Add github action for brakeman (#9451 )	3 years ago
Oliver Günther	71ae1cd4f7	Add CodeQL setup for javascript/typescript (#9450 )	3 years ago
ulferts	0666c89828	Feature/35708 wp typeahead filter (#9426 ) * breakup wp resource specs into separate files * introduce and employ typeahead filter on work packages Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Patrick Helm	5810190995	Speed up `bin/compose setup` significantly (#9404 ) With the proposed changes the time required to run `./bin/compose setup` is being reduced from ~18 minutes down to ~7 minutes on my machine. In addition a workaround is applied to reduce the size of the images. == Changes === Speed-Up `bundle install` The time spent withing `bundle install` takes a significant amount time during the `./bin/compose setup`. We could make use of two improvements, which both allows us to utitlize multiple CPU cures: * Make use of the bundle `--jobs` argument * Make use of the lesser known/used `MAKE` environment variable A significant amount of time spent during `bundle install` is actually compiling C-extensions, that's why the usage of the `MAKE` variable will drastically improve performence. === `useradd --no-log-init` Unfortunately there is a nasty bug when running `useradd` for a huge `uid`, which could result in excessive image sizes. See attached links for more information. === BuildKit BuildKit is the default builder toolkit for Docker on Windows and DockerDesktop on Macs. Using BuildKit will greatly improve performance when building docker images. == Links === Speed-Up `bundle install` * [One Weird Trick That Will Speed Up Your Bundle Install](https://build.betterup.com/one-weird-trick-that-will-speed-up-your-bundle-install/) === BuildKit * [Build images with BuildKit](https://docs.docker.com/develop/develop-images/build_enhancements/) * [Faster builds in Docker Compose 1.25.1 thanks to BuildKit Support](https://www.docker.com/blog/faster-builds-in-compose-thanks-to-buildkit-support/) === `useradd --no-log-init` * Best practices for writing Dockerfiles: [User](https://docs.docker.com/develop/develop-images/dockerfile_best-practices/#user) * golang/co: [archive/tar: add support for writing tar containing sparse files](https://github.com/golang/go/issues/13548)	3 years ago
Wieland Lindenthal	553cf861d1	Feature/37870 make in app notification center responsive to mobile sizes (#9413 ) * Shorten relative time strings in moment.js * Add user name as title and hide name from op principal * Lazy load momentJS config for short relative time strings * Hide modules menu on mobile in favor of in app notifcations bell * Many smaller layout improvements for the in app notification center * [IAN] Decrease size of clickareo of project name * [IAN] Smaller design fixes * Apply grid layout to better handle mobile sizes instead of using abbreviated texts for the relative time Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Oliver Günther	c528e92038	Bump ruby to 2.7.4 (#9448 ) This was introduced parallel to the Ruby version bump in release/11.3	3 years ago
Oliver Günther	980447ab51	Prevent backtracking regexp in MessagesController (#9447 )	3 years ago
Oliver Günther	889f7971cf	Merge remote-tracking branch 'origin/dev' into dev	3 years ago
Oliver Günther	64d34c4061	Merge remote-tracking branch 'origin/release/11.3' into dev	3 years ago
Oliver Günther	8365f575cb	Prevent backtracking regexp in MessagesController (#9447 )	3 years ago
Oliver Günther	c35c81d60b	[32867] Generalize me associated action for custom fields (#9443 ) https://community.openproject.org/work_packages/32867	3 years ago
Benjamin Bädorf	cd80bd4047	Switch to op-autocomplete for the time-entry wp autocompleter (#9434 ) * Switch to op-autocomplete for the time-entry wp autocompleter * Switch to HalResources for the select edit fields * WOrks better than ever before * Fix tabrow selected indication * Fix op-autocompleter spec * Fix search * Remove log statements Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
Oliver Günther	314495b306	Update shrinkwrap (#9445 )	3 years ago
Henriette Darge	daebe0e9e4	* Update modal class and remove old/obsolete styles (#9438 ) * Fix appearance of time entry configuration modal	3 years ago
OpenProject Actions CI	2a6bc3d495	update locales from crowdin [ci skip]	3 years ago
Andrej Sandorf	638ef7b368	Fix/docs (#9442 ) * fix(editorconfig): there's markdown in api yml - don't trim trailing whitespace * fix(markdown): adjust markdown for kramdown parser * fix(api-doc): adjust description markdowns, unify descriptions	3 years ago
Henriette Darge	c605bd475a	[37939] Missing cancel button on project create page prevents me from going back (#9439 ) * Add cancel button to dynamic form * Add confirm dialog when the user has entered some data	3 years ago
Oliver Günther	8e82477f0f	Update README.md	3 years ago
Henriette Darge	d34b4517d9	[37939] Pagination style is lost (#9433 ) * Apply BEM styling rules for paginations && fix styling for ruby-created paginations * Add class for actual clickable element in the pagination * Introduce modifiers for positioning items at the start or end	3 years ago
bsatarnejad	ab8b54801b	change the styles of wp-embeded view	3 years ago
bsatarnejad	8bf215678b	change styles of members widget	3 years ago
OpenProject Actions CI	c8b515127a	update locales from crowdin [ci skip]	3 years ago
OpenProject Actions CI	c572d4aeda	update locales from crowdin [ci skip]	3 years ago
OpenProject Actions CI	570e5de984	update locales from crowdin [ci skip]	3 years ago
Oliver Günther	d8027ebc38	Bump ruby to 2.7.4 (#9437 ) * Bump ruby to 2.7.4 * make sure to pull latest base image during tests too Co-authored-by: Markus Kahl <machisuji@gmail.com>	3 years ago
OpenProject Actions CI	dd4c5d7105	update locales from crowdin [ci skip]	3 years ago
Benjamin Bädorf	3a877457ad	Feat/frontend linting (#9424 ) * Change eslintrc config * Try esprint fix * Run linter fix * Set most of the typescript linting rules to warn, run with --fix * Fix some linting errors * Optimize imports * Build works again * Remove fixes that didn't fix anything * Make imports lint-conform again && disable trailing underscores as it is part of Angular and our convention * Remove wrong automated fix * Rename components with suffix "Component" for linting * Linting, refactor reorder-delta-builder to a more functional style * Update delta reorder specs * Add exceptions for "++" in loops and bracket expressions in arrow functions * Some linting fixes * Fix some more linting * Optimize imports Co-authored-by: Henriette Darge <h.darge@openproject.com>	3 years ago
Benjamin Bädorf	89bd15516d	Fix several app-header search styling issues on mobile (#9416 ) After introduction of the new op-autocompleter component for the app-search component, there were a couple of styling issues related to the ng-select default styles. * Correctly set max-width to 679px, so that the tablet breakpoint starts at 680px exactly. There were some issues with overlapping queries or queries that ignored the exact 680px point * Disable line wrapping in menu items. The "sign in" button was getting line wrapped on certain screen sizes * Fix text vertical alignment in the search input	3 years ago
OpenProject Actions CI	e376f69aa0	update locales from crowdin [ci skip]	3 years ago
OpenProject Actions CI	3114ed42f5	update locales from crowdin [ci skip]	3 years ago
OpenProject Actions CI	9ca6f8e4b5	update locales from crowdin [ci skip]	3 years ago
Andrej Sandorf	f4fb76209a	Fix/docs-markdown [skip ci] (#9436 ) * fix(docs): no hot-linking * fix(docs): escape < and > in normal text	3 years ago
ulferts	8be49d1c62	only store notification resons for in app (#9419 ) We currently only diplay it for in app. This might change once digests are introduced	3 years ago
Benjamin Bädorf	ce7a499f5a	Improve work package autocompleter styles (#9423 ) * Improve work package autocompleter styles * Fix long project names in wp autocompleter, add highlighting	3 years ago
Oliver Günther	52a5424614	Fix FormService spec after merging from release/11.3	3 years ago
Wieland Lindenthal	66a1ef0546	Add missing i18n for notification subjects	3 years ago
OpenProject Actions CI	fccfbdef9c	update locales from crowdin [ci skip]	3 years ago
OpenProject Actions CI	9082fcce0f	update locales from crowdin [ci skip]	3 years ago
Markus Kahl	0c02836f2c	make sure all needed docs files are present	3 years ago
Markus Kahl	d171c5a489	ignore all docs except OpenAPI spec!	3 years ago
ulferts	bd3f182c3d	adapt specs	3 years ago
Oliver Günther	5ea68fd95d	Add a title to the project details widget This shows the full name in case of ellipsis	3 years ago
Oliver Günther	8fae2d1427	Fix table header widths exceeding the td's 300px max width This can happen due to the longer CF names	3 years ago
Oliver Günther	a8652d7483	Remove length restriction on CustomField#name	3 years ago

... 6 7 8 9 10 ...

59729 Commits (50feb54ffa8e82a9576706e2de652878d9b3635d) All Branches Search

59729 Commits (50feb54ffa8e82a9576706e2de652878d9b3635d)

All Branches