openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	6cda6ad4fd	enforces dependent project modules being active (#9311 ) Project modules, e.g. calendar can define dependencies, e.g. work packages. An error message is now displayed if a user enables a project module without the dependency being active in the project as well. Also fixes a serious bug in the Shared::ServiceContext module. Whenever a failing service result is returned, every change to the database is to be rolled back. This was not true when a model was provided since the changes where carried out within an inner transaction	4 years ago
ulferts	5cb227796c	Fix/hook service to openproject (#9214 ) * move specs from legacy * move Hook into OpenProject namespace * replace class variables	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136 ) * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	174427fc05	Remove duplicate not_locked scope (#9166 ) * Remove duplicate not_locked scope The enum itself creates scopes but they do not include not_builtion. So instead, let's create these scopes ourselves * Change enterprise spec to no longer test for builtin users	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958 ) * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	4bf7a26eb1	Capabilities API (#9083 ) * Capabilities API * introduce auxilliary capability model * capability model and query * render in sql * fix pagination * introduce sql representer * extract abstract sql representer class * remove yet unused methods * abstract sql collection representer * contract_actions as part of permissions * filter for capability id - used in GET * id filter validation * remove unused representer * remove unused wp representer * reuse renaming class * add spec for access control * add principal filter to capability * add context filter * extract capability sql into scope * admin gets all capabilities * require to have one filter set to keep performance bearable * consider active project modules for capabilities * limit capability based on principal visiblity and user state * rework capability to be tableless * spec not being allowed to see on request level * add actions to capability representer * add action api * extract sql index endpoint * remove unused class * prepare sending signaling error - not yet frontend exposed * extract show endpoint for sql rendered responses * use UNION for better performance * include navigation links on collections * remove string replacements * extract collection representer into hal sql module * no capabilities when blocked * remove commented out code	4 years ago
ulferts	7ecf08e005	rework changed_by_system (#9043 ) Before, it was implemented by passing the changed attribut keys over to the contract to whitelist them. This lead to: * The contract interface becoming bloated * Having to rely on the knowledge of the developer not to falsely whitelist an attribute. The developer would also have to make sure to not perform a mass assignment after the attribute has been whitelisted The new approach it to integrate the behaviour into the model which is first altered in the service before it is scrutinized in the contract. The information about the changed attributes is now stored inside the model which removes the necessity to flag the whitelisted attribute separately. Additionally, the exact change is tracked. So if an attribute is set to one value inside a whitelisted block there is no risk in later on performing a mass assignment. This comes at the cost of extending the models which is weird also it is build into the default SetAttributesService so child classes do not have to worry. One might include the module into every AR model but currently we only need it for a very specific use case.	4 years ago
ulferts	9edf745085	Fix/group mention links (#9036 ) * turn group mentioning into link * add profile button to group edit page * Include built ckeditor Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987 ) AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code Found via `codespell v2.1.dev0`	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	69fd5d6d86	avoid pre + code dom structure (#8896 )	4 years ago
ulferts	f453772ed8	avoid duplicate toc numberings (#8891 )	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	7f34799a33	Chore/reimplement global roles (#8730 ) * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter	4 years ago
ulferts	8c554ba0c9	Feature/mentions rewrite (#8853 ) * update ckeditor * output user-mention link on mention tag * spec revisiting a user mention * amend mention recipients by tag * handle wp mentions	4 years ago
Oliver Günther	8d2da3f6d8	[33648] Add value macros for referencing label and values of project and work packages (#8578 ) * Add macros for attribute values and labels of HAL resources * Implement label macro with help text For that, we need to move help texts out of the work package module. The fields module appears to be best suited for it. * Load the current project for project attributes * Don't render things that only matter in writable situations Such as the project dropdown indicator or the spent time modal * Throw if ID was not correctly provided * Bootstrap the inserted html of a custom text * Expand errors if user cannot see/load expected macro resource * Add text formatting spec * Add feature spec to test both loadable and failing macros * Reference only subjects in the current project if not referenced by id * Extend documentation * Refactor loading switch * Add macro for work package quickinfo (previously ## and ###) * Extend spec to double and triple hash macros * Ensure we allow numeric strings as IDs Was testing for isNumber, which only checks for actual number types * Fix showing the placeholder when not empty * Add error span to the quickinfo macro * Better styling and title help for macros	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580 ) * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	62d76b32c7	Fix specs	4 years ago
Oliver Günther	ff4d430eb0	Fix case of task list with link after text node	5 years ago
Oliver Günther	6dabfa5628	Fix case of task list with link after text node	5 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230 ) Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
ulferts	b5a7c1fd9c	add necessary method to stub	5 years ago
Oliver Günther	4b5d3c3e41	[31628] Downcast todo lists in tables to markdown Tables are saved as HTML, thus avoids any frontend turndown within it. This means todo lists are kept as is, with the CKEDitor frontend style. Currently, they will be sanitized after turned to markdown in the backend. We can easily downcast the todo list part into text. This ensures that the todo list does not get sanitized, and will correctly be found by the todo list filter. https://community.openproject.com/wp/31628	5 years ago
ulferts	112f8c1be3	hide bim permission group in role view if bim disabled	5 years ago
ulferts	399e8c3ed9	rename according to zeitwerk	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	8511aca939	add noopener tag to all anchor tags to prevent tabnabbing	5 years ago
Markus Kahl	20ed40be1e	only 2 out of 3 builtins are actvie (deleted is blocked)	5 years ago
Markus Kahl	ddb40187ba	added regression spec for active users and fixed anonymous user's status	5 years ago
Oliver Günther	269d91cfb9	[31583] avoid parsing strings to yaml If a configuration/ENV value has YML-incompatible contents, it is broken due to the `YAML.load` approach. However, if the outcome of `YAML.load` is a string, we can expect the input to be an actual string, not something YAML should parse. Thus as a workaround until proper configuration types are added (or better, settings and configuration is joined into one), this avoids breaking passwords in ENV configuration inputs. https://community.openproject.com/wp/31583	5 years ago
ulferts	8d35a9b5f0	rely on api for configuration instead of gon Replaces all configuration fields currently supported by the api to be fetched from the api instead of from gon. Reduces the information passed to gon. Only the date/time format fields are left for gon to pass as those are not yet available via the api. Adding the fields should be easy.	5 years ago
Oliver Günther	ca97e60e0f	Revert "Merge remote-tracking branch 'origin/fix/remove_dependency_from_gon' into dev" This reverts commit `ed8082ecfd`, reversing changes made to `f47a75d153`.	5 years ago
ulferts	f7df4b222a	rely on api for configuration instead of gon Replaces all configuration fields currently supported by the api to be fetched from the api instead of from gon. Reduces the information passed to gon. Only the date/time format fields are left for gon to pass as those are not yet available via the api. Adding the fields should be easy.	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	e7263fcedb	migrate to rails 6.0.0	5 years ago
ulferts	08391c7807	replace my_project_page by grid implementation	5 years ago
Oliver Günther	29657fbaf1	[30839] Avoid leaking subject in cached WP links https://community.openproject.com/wp/30839	5 years ago
ulferts	3f102dd802	show error message for existing macro occurrences	5 years ago
Henriette Dinger	086a80edb4	Fix references to revisions and adapt tests	5 years ago
Henriette Dinger	d0cbd450eb	Do not hide the WP preview modal when hovering over the modal itself	5 years ago
Oliver Günther	24caede763	[30370] Fix not allowed scope for relative URL root If a relative URL root was set, no scope for boards was every writable. https://community.openproject.com/wp/30370	6 years ago
ulferts	5c46d66b41	redirect attachments calls to api v3	6 years ago
Oliver Günther	466c33a2b7	Restore indentation of table of contents This got lost with the migration to markdown https://community.openproject.com/wp/30245	6 years ago

1 2 3 4 5 ...

276 Commits (5d52ac0a262c62eaaccdc47e31260c648a1e105d)