openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	202bd63ebb	Merge release/11.4 into dev	3 years ago
Oliver Günther	1715d3ec89	[38813] Ensure embedded tables load their own columns Previously, if `showFilters` was false, the embedded tables would not load their own query form but piggyback on the globally loaded form. This however does not work when: 1. Opening a work package in a deep link (global query form never loaded) 2. The embedded table resides in a subproject (different query form necessary) That's why this PR moves the available states into the isolated query space and ensures the form is always loaded. https://community.openproject.org/wp/38813	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
Henriette Darge	731ea6c76f	Show tab counter only when the number is larger than 0	3 years ago
Oliver Günther	d4bba680a3	[38121] Fix logic when datepicker today link is shown When the end date is empty, always show the start date today button and vice versa. https://community.openproject.org/wp/38121	3 years ago
Behrokh Satarnejad	133c0136c1	Using BEM methodology to change the styles (#9401 ) * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * change some of stylesheets * change the style naming * resolve the error * improving the previous commit with Ben's comments * improve the styles of breadcrumb * change the stylesheet related to status button * refactoring css stylesheets of wp single card * fixing the errors of PR, correct selector * resolve the error on PR related to boards onboarding * wp relation and list view style changes * resolve the errors of previous commit * fix error in selecting wp relation * fix the errors of wp relations ruby tests * change the stylesheets of autocompleter and wp calendar * change the style of grid page * Some improvements to the BEM styling * Prefix draggable-autocomplete BEM block with op- * Fix spec selector * Fix spec selector Co-authored-by: Benjamin Bädorf <b.baedorf@openproject.com>	3 years ago
Henriette Darge	daebe0e9e4	* Update modal class and remove old/obsolete styles (#9438 ) * Fix appearance of time entry configuration modal	3 years ago
Oliver Günther	46599dd90e	[37274] Remove accessibleClick (#9355 ) * Remove accessibleClick from wp-single-card * Remove accessibleClick directive itself * Fix context menu with button * Add common mixin for unset-button-styles * relations button * Editable query and toolbar * Resizer button * Replace wp-create button * Replace relation description value * Replace type form * Replace pagination links * Replace button styles for attachment dropzone * Replace accessibleClick in tile-view * Replace inline create * Replace display container with button * Replace text in notification on boards error * Replace global search component * Fix pagination spec * Fix specs * Fix triggering display field on enter * Make search toggle a button * Review feedback	3 years ago
Oliver Günther	e363d2f2fd	Remove accessible-by-keyboard a11y component (#9331 ) * Replace accessible-by-keyboard * Replace messed up inplace styles with work-package-comment bem block The styles are not used anymore except for work package comments anyway * Replace split view icons with buttons * Make back-button its own bem block * Replace button in hide-section component * Replace activity buttons * Replace notification icon * Replace collapsible-section * Replace config-menu * Make attribute help text trigger a button * Ensure all buttons are role=button * Replace inplace save controls * Replace relations buttons * Replace relation toggle button * Replace relation row buttons * Replace breadcrumb parent * Replace activities toggler * Remove accessible-by-keyboard component * Fix button role to button type * Fix indent * Bemmify media query * Fix specs	3 years ago
Oliver Günther	5956ede030	[37107] render tabs in component (#9236 ) * Render work package tabs in one component * Move standard tabs into tab service * Move tab-count styles mostly into its own component style * Fix frontend specs * Remove unused texts * Fix routing to split view from button * Fix context menu not opening the tabbed view * Fix watcher tab counter not receiving an rxjs subscription * Fix selector * Fix clicking on relation link to fullscreen * Make WP tabs an instance of scrollable-tabs * Convert the tabs from .tabrow to its own BEM block * Refactor other usages of tabrow into op-tab-row * Fix frontend specs * Make wp modal tabs use scrollable-tabs * Fix disabled tab selectors * Restore scrollability of tabs * Fix import and change detection of graph modal * Fix selector in wp relations spec * Rename tab-count to match component style * Remove narrow style * Fix bem modifier style * Fix styles of scrollable tabs * Fix tab for time entry autocompleter	4 years ago
Oliver Günther	76c828d8d5	[37157] Fix float value rendering with zero value (#9255 ) https://community.openproject.org/work_packages/37157	4 years ago
Oliver Günther	e811d8b6f7	Don't clear the datepicker input resulting in an endless loop Clearing the datepicker when it is not set will result in an endless loop since flatpickr already unsets it properly. Instead just emit the empty value	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Benjamin Bädorf	e848d44dea	Fix/update wysiwyg styles (#8844 ) This is a refactoring of the CSS classes in the WYSIWYG editor. The classes now use proper BEM and are almost completely independent of other CSS. It also includes small style refactorings, like a reduction of heading size in attribute fields, and an increase in heading size in all other instances. * Initial class definitions * Added more classes * Added Table of Contents basics * CkEditor applying custom CSS classes to p, h1, h2, h3, h4, h5, h6, li and blockquote * CKEditorInspector removed * op css class for headings * op css class for paragraphs * op css class for code/code block * adapt specs to altered markdown/html generation * adapt grid/budget representers to altered signature * op css class for lists * op css class for toc * op css class for links * Start working on typography css * op css class for tables * Fixing more typography, trying out larger headers * Applying custom classes to li, a, blockquote, figure, table, tr, td, th, image, codeblock, figcaption and macros * adapt specs to altered link classes * op css class for images * apply user content container class throughout application * CSS alignment custom classes applied to table * op css class for task list checkbox * Added task checkbox class * amend list checkbox class in backend * op css class for table thead element * adapt specs on image html generation * Updated table and typography styles * Update typography and figure styles * Figure overflow handling * Table alignment styles + ckEditor styles removed * rename wiki-anchor to op-uc-link_permalink * wrap table in div as well as figure * Updated code-block * Update permalinks * Fixed a lot about tables * Removed Description header from work-packages page * Fix frontend styles * Add placeholder styling, fix toc * Fixed figure print * working with table aligns * Custom class add to task lists * Custom classes applied to theads * op-uc-container custom class added to container * Codeblocks inside pre elements * Fix: single <code> and <a> tags * explicitly require overwritten gem class Apparently, the gem is not loaded yet when it is registered as a filter when in eager loading mode * adapt spec expectation to altered toc rendering * CkInspector removed * Latest ckeditor changes * remove highlight css class from wiki content * allow html pipleline to handle macros with additional classes * Fixed a lot of print css for tables * Add general print css back in * Update Table of Contents styling * Custom classes on ul, ol, li and task-lists * Revert "Custom classes on ul, ol, li and task-lists" This reverts commit `0d27d28137`. * Custom classes on ul, ol, li and task-lists * Custom classes on column's th * remove placeholder class when rendering * WOrking on task lists * Changing task-list classes, changed tests * Updated list styles * Remove unused todo list styles * remove checked in binstubs * Fix table of contents * adapt todo list handing in backend pipeline * adapt specs to altered css classes * Add numbers to table of contents * Better comments in table of contents * Fix: wrap single <table> with a <figure> * Fixes to todo list design * Updated todo list scss to fix nested lists * adapt selectors in table spec * Update table styles * Improve table borders more * Custom classes specs * Fix: no need to remove regular list classes when its type changes * Add modifier for inline headings * Update table editing styles * Remove break-word tests * wrap images just like tables * Update figure content styles * Fix: All tests passing (ul.op-uc-list_task-list) * div.op-uc-figure--content wrapping tables * Specs for figures wrappers div.op-uc-figure--content * Fix: add custom classes to links and codes again * Table wrapper div reverted + specs * Fix inline palceholders * Custom macro type classes * Add basic macro placeholder changes * Move heading permalink after text * Fix word-break spec * Sending figure styles to the backend (width) * extend test to take ckeditor placeholder into account * avoid adding bem classes multiple times * attempt to fix flickering spec * Removing image spinner when uploading finishes * adapt spec expectations Co-authored-by: Aleix Suau <info@macrofonoestudio.es> Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Benjamin Bädorf	5f45ee07ab	Move development docker-compose file to the main directory (#8798 ) * Move development docker-compose file to the main directory This requires us to move some other files around, like the pullpreview and example docker-compose file for production setups. This commit also does some housekeeping, like removing some old files and deduping configuration. * Updated to selenium grid * Fix in-Docker Selenium tests The Selenium tests now run inside a Docker Chrome Container. Backwards compatability with non-docker setups is not guaranteed, though it should not be hard to implement with a couple of small fixes. * Updated docker development documentation * Improved test timings, changed the documentation * Updated docker testing again * Run npm in the frontend directory * Really run npm in the frontend directory * Also run npm in frontend when setting up travis cache * Change directory for one command only * Change default test driver name * CI test change fixes * Fixed syntax error * Added dev check * Trying to fix firefox resizing * Trying to get tests running * Stop resizing firefox * Fixed apple icon spec * fix host in url helpers for omniauth spec * Fix omniauth specs * Fix docs * Small fixes to docker tests * Added package.json back in * Change env variables Co-authored-by: Markus Kahl <machisuji@gmail.com>	4 years ago
Aleix Suau	5ea357c750	Bump CKEditor5 to v21 (#8570 ) * Bump to v21 * Upgraded to v21, really * Todolist spec fixed * Update fixes for child pages macro * Fix code block conversion Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	8805ea74c9	Use combined schema for combined date field Introduces a combined property schema for the combined date field of work packages. To that end, the way the schema is referenced is moved from calling the schema on the HalResource (i.e. work package) to fetching it from the SchemaCacheService. As the backend only provides generic Schema resources for all resources (e.g. TimeEntry, WorkPackage), the difference in behaviour (i.e. determining whether a property is editable is performed within a proxy handler. That handler is applied whenever a schema is fetched from the Service.	4 years ago
Oliver Günther	a92575e3ec	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	c6b9c8ff02	Use distinct(*) on aggregated journal to avoid duplicate raw journals https://community.openproject.com/wp/33744	4 years ago
Henriette Darge	65af828ff2	Add test case for selecting the same day as start and end date	4 years ago
Henriette Darge	d7b5289681	Add test case for "Today"-Link	4 years ago
Henriette Darge	67a56cca7b	Adapt test to WP date field showing two months in the datepicker modal	4 years ago
Henriette Darge	b3dd61946e	[32880] Display scheduling mode in work package view (full, split & table) (#8410 ) * Show icon next to start date depending on the scheduling mode * Show modal when opening date edit fields which shall be able to change the dates and the scheduling mode * Introduce flatpickr as a datepicker for the modal of the dateEditField * Use new datepicker within opDatePickerComponent * Reuse existing Datepicker class for better code abstraction * Set dates only when Instance is ready * Let augmentedDatePicker use generic DatePicker class, too. * Remove jQuery UI datepicker specific styles as they do not apply any more. * Use localized strings in new datepicker * Close datepicker only on click outside * Allow single and multi selection of dates and save changes * Update schedulingMode button correctly && remove unused method * Show combined field for start and end date within the WP single view * Show normal datepicker for most date fields and the modal with the extended datepicker only for startDate * Add datepicker edit field and component helper * Correctly save start and end date * Show correct default value for dateEditFields && Adapt some tests to new datepicker and combined date field * Fix date editor spec * Fix expecting datepicker for start/due date as milestone * Prevent overflow on body by using modal-portal class && make edit input for combinedDates visible again to show something in a create form * Only output one debounced change event for op datepicker * Show combined datepickerModal for dueDate in table, too && save correct scheduling value * Hide modal if the showing component gets destroyed * Correctly check for closed datepicker * Add spec for toggling scheduling mode * Fix setting dates to modal * Avoid too many (unnecessary) close events and use keydown instead * Fix date setting and add custom field date spec * Change layout of combined date picker modal * Switch from a range date picker to a multiple selection in order to be able to set only start or due date && Highlight date field that is changed next * Highlight range manually * Highlight dueDate initially when the user clicked on the due date field && handle special case that one of the values is not set yet. In this case we don't want to keep both values but only the newly clicked. * Move helper functions to own class && Improve the range selection to be able highlight ranges over multiple months && Prevent that a start date > due date can be chosen by setting minDate and maxDate * Adapt test to new way of changing the scheduling mode * Handle case that the user clicks on a already selected date and thus deselects it Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	ed5e2c186d	Change spec expectation that now calls the service	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	85390687b7	adapt specs	5 years ago
Oliver Günther	7d042838b0	Change spec now that space selects an autocomplete item	5 years ago
Oliver Günther	afeb1a42af	[31859] Save date with confirm button when empty https://community.openproject.com/wp/31859	5 years ago
Oliver Günther	4a8eb0225f	Add firefox headless to test the broken chrome float input	5 years ago
Oliver Günther	f4f1e98b20	[32156] Use backlogs sorting of versions date for work packages - Adds a null_handling option to the property columns to allow `NULLS FIRST/LAST` to be handled - Adds a query specific SortCriteria that can work with null_handling - Fixes sorting of allowed_versions to reuse that sort order https://community.openproject.com/wp/32156	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Henriette Dinger	7167a85cb0	Fix specs by correcting the project settings paths and do some minor selector changes	5 years ago
Oliver Günther	1c6ed3671a	[30920] Fix links in task lists They were broken due to the way todo list labels and inputs are nested differently when links are present: CKEditor converts todo lists differently when they contain a link <ul class="todo-list"> <li> <label class="todo-list__label"> <input type="checkbox" disabled="disabled" checked="checked"> <span class="todo-list__label__description">4 teaspoons baking powder </span> </label> </li> <li> <a href="https://example.com"> <label class="todo-list__label"><input type="checkbox" disabled="disabled"> <span class="todo-list__label__description">1/4 teaspoon salt </span> </label> </a> </li> </ul> which is why we need to override the list item rule for turndown to address this and replace the todo list on our own. https://github.com/opf/commonmark-ckeditor-build/pull/45 https://community.openproject.com/wp/30920	5 years ago
Henriette Dinger	2a14443840	Adapt test to new placeholder	5 years ago
Henriette Dinger	751caed2e0	Attempt to stabilise description_editor_spec.rb	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Henriette Dinger	f47a75d153	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726 ) * Check edit fields for Work package dependencies * Make EditForm, NotificationService, EditContext indepenedent of Work Packages * Make EventsService independent of WorkPackages * Start renaming WpNotificationService (WiP) * Fix more references * Fix typescript errors * Add basic halEditingService * Rename to global halResourceEditingService (WiP) * Move typing from class to methods (WiP) * Fix typescript errors * Remove space in type * Add test project widget && generalize the editFieldGroup * Rename editing portal service [ci skip] * Rename WpEditFieldComponent * Rename WpDisplayFields * Rename display-XX-field to XX-display-field [ci skip] * Add WP specific ID field to distinguish between resources * Re-add state in work package resource * Generalize display field renderer * Rename spent-time to wp-spent-time and fix highlight specifics [ci skip] * Actually load the project schema and make field editable * Make edit-field-group.component an edit-form.component and subclass EditForm * Remove edit context in favor of specialized EditForm * Add special cases for work package editing * Fix edit actions bar * Fix codeclimate issues * Use WorkPackageNotificationService if necessary * Override NotificationService for WPs to allow WP specififc notifications (WiP) * Correctly provide wpNotification service Because the ui-router doesn't seem to correctly use the parent element's injector, we need to provide the wpNotification service not in the wp-base, but rather the wp-list component as well as in the isolated query space. * Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage) * Remove superfluous cell class constant * Start renaming selectors for wp-edit-field into generics * Remove wp-table--cell-span in favor of display field selector * Consolidate other display and edit field styles * Provide specialized service for transitions in active edit forms * Remove superfluous overflowSelector * Accept that date field contains some work package specifics * Ignore unreadable files * Provide the changeset for work packages as a hook Since hal resource editing service is provided per query space, we cannot register them once (would only work globally) * Fix dangerfile * Remove another todo in halResourceNotification service * Fix npm TestBed for changed dependencies * Show inplace edit field in project details widget * Fix highlighting in single view * Provide HalResourceEditingService outside of project context * Used typedState for single-view * Also provide wpNotification service in split view * Correct check for resource type in eventsService * Fix getSchemaName in display field renderer * Fix passing ids into `halEditing.stopEditing` * Do not globally inject the halResourceEditingService There's a bug(?) in ui-router that gives you the global service before the parent injected service for a ui-view * Fix wpCreate service on copying and parallel creation * Remove test project widget * Revert changes for project details widget	5 years ago
ulferts	ce50beb2f9	attempt to fix flickering spec	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	a3317eb748	bump capybara	5 years ago
Oliver Günther	59bc26a7d4	Fix broken tests due to chromedriver update	5 years ago
Oliver Günther	8fe8dc6491	[30941] Use same icon for drag & drop https://community.openproject.com/wp/30941	5 years ago
Oliver Günther	3ae39f8bb4	[30928] Fix clicking on WP links since hover card visible The click with an open hover card prevents the default action of the link, preventing the click to result in page changing.	5 years ago
ulferts	e97883cdd8	attempt to fix flickering activty spec by less ambivalent input	5 years ago
Oliver Günther	85398d71df	Change selector to not fail on first attempt Since we insert the tasklist, angular seems to have a temporary pass that is brekaing these specs. However, the failing screenshots always show the correct comment so I suspect it's a timing issue. This PR changes the expectation to run in a retry_block without retrying the entire spec	5 years ago
ulferts	f46c58faf9	use the wp payload instead of the resource That way, local changes will not be ported over between states except when the user has explicitly made them. E.g. changes by the user to the subject should be ported over, but changes to the description, caused by a default description, should not	5 years ago
Oliver Günther	872fba5892	Fix styling of task lists	5 years ago

1 2 3 4 5 ...

282 Commits (60436e37cb6496701ef7cc857a5e03a914f976e1)