912 Commits (61d742afef7ec6fea846cfa09ac0797eed72aea8)

Author	SHA1	Message	Date
Jens Ulferts	32b3b9ab9b	replace html path in api representer ... The html path is no longer required as we now have a proper api endpoint a client can call	9 years ago
Jens Ulferts	af09bf7017	cache root_path in apiv3 api helper ... A lot of time was spent determining the root path.	9 years ago
Oliver Günther	d49ba37e0a	Remove explicit required label for impaired users ... Denote inputs with `aria-required="required"` instead of a separate span within the label, which causes double mentions of the field being required (once through the html5 attribute when the screenreader is compatible) as well as in the label span.	9 years ago
Oliver Günther	bbfe941e77	Refactor required star into separate spans ... Seperate spans for visible and impaired users allows us to replace the spelled out Asterisk from pseudo content with a proper aria-label.	9 years ago
Oliver Günther	86a061b6e7	Add separate span with error message for the current field	9 years ago
Oliver Günther	ce503e3306	Add error handling to form labels ... This re-enables an `-error` state for labels when the associated field is erroneous. Also shows an error icon next to the label and changes the font style.	9 years ago
Oliver Günther	412becb62e	Fix icon-add missing spec	9 years ago
Oliver Günther	67e06ee2b2	Remove double escaping ... With OpenProject 5.0, we moved to Open3 pseudo-shell, which no longer requires escaping seperate arguments (unless the whole command is passed as a single string, which will result in an actual shell that would require escaping). The `shell_quote` functionality was still used though and causes issues with remote subversion passwords, which will be improperly escaped.	9 years ago
Jens Ulferts	fc49e2a7b7	use linked parent resource instead of parentId ... The parentId field should be removed. But we shouldn't do it in a minor version.	9 years ago
Jens Ulferts	9668e7e99e	fix addChild path in work package resource	9 years ago
Jens Ulferts	966d749e45	add parentId field to schema ... This is somewhat debateable. Having a parentId field is wrong in itself. It should be a linked resource. But as the field is also present in the resource, it also needs to be part of the schema for consistency sake.	9 years ago
Oliver Günther	8dc9b592c4	Fix merge hickup	9 years ago
Henriette Dinger	48f593645c	Add small icons for timelines and start fixing specs	9 years ago
Henriette Dinger	463aa185da	Update icon classes from 'not-watch' until 'pulldown-arrow4'	9 years ago
Henriette Dinger	844663fef2	Change icon classes from 'attention1' until 'headphone'	9 years ago
Markus Kahl	7f88ba5b22	removed attachments#show; only #download remains	9 years ago
Oliver Günther	8b01984cc2	Adjust test to check activities are not embedded	9 years ago
Jens Ulferts	e2f8db9497	eager load colors together with the type	9 years ago
Markus Kahl	5324b2cc07	drop my first_login; redirect to work packages if possible	9 years ago
Jens Ulferts	8284933a5a	mark spentTime and percentDone as optional	9 years ago
Oliver Günther	69fae7bc54	Remove other remnants	9 years ago
Oliver Günther	876203c096	Add writable to other custom field injectors ... This was missed in https://github.com/opf/openproject/pull/3728 and properly disguised by a faulty spec fix from my side.	9 years ago
Stefan Botzenhart	ba3c727dcc	Remove pending specs	9 years ago
Jens Ulferts	2264d5a345	format floats in journals accoriding to the locale	9 years ago
Oliver Günther	82fd196030	Allow writable? in customField spec double	9 years ago
Jens Ulferts	27e2cce32b	add priority to list of attributes inherited from children	9 years ago
Mohamed Wael Khobalatte	0e72ec4243	Move to ruby1-9 syntax once and for all	9 years ago
Jan Sandbrink	85f60d8bbc	Also allow to add attachments to a WP with permission to add WPs ... This is neccessary to allow adding attachments, after creating a new work package. The undesired part is, that it also allows you to add attachments long after creating the WP.	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Stefan Botzenhart	89c982f003	Remove manual spec retries	9 years ago
Oliver Günther	acb4431d8a	Implement UserPreferences endpoint ... Provides the implementation to the user preferences endpoint.	9 years ago
Oliver Günther	cd7ec57ee6	Empty check for newer Git versions ... Git recently introduced a new format for outputting warnings on empty repositories in ce11360467 This commit extends the empty test for this output	9 years ago
Mohamed Wael Khobalatte	03cce5e25d	Avoid defining same constants in multiple specs	9 years ago
Stefan Botzenhart	292c872079	Increase retry wait time to 10 secs for watchable routes spec	9 years ago
Stefan Botzenhart	1c01b5801e	Use login_as helper method throughout all specs	9 years ago
Stefan Botzenhart	de14bf43b9	Add retry parameters for randomly failing specs	9 years ago
Jonas Heinrich	fc4b2b4676	Adds specs for configuration	9 years ago
Markus Kahl	da58898c29	clear subscription spec	9 years ago
Alex Coles	294b0ded6d	Update expected HTML in RevisionRepresenter spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	164a60ffa8	Use #be_html_eql matcher in TextFormatting spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	acb2aa7eb1	Fix TabularFormBuilder HTML matching ... Use #be_html_eql matcher in TabularFormBuilder spec (see 1f42f127) to avoid relying on specific order of attributes. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fb82c9c1ba	Replace anonymous class in ActsAsOpEngine spec ... Rails 4.2 is not able generate an appropriate `railtie_name` (aliased to `engine_name`) for anonymous classes - this, in turn, breaks initializer definitions. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	2fc2ea3ae5	Update expected HTML in FormTagHelper spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	0702683116	Fix bad method call for version custom fields ... exploring the down sides of isolated unit testing :(	9 years ago
Jan Sandbrink	6e9ed008fb	Enforce passing of current_user into representers ... Thereby permission checks will no longer silently fail if no user was passed. This uncovered a lot of places where we actually expected a user to be passed, when it wasn't. This was especially true for collections. The basic idea is, that virtually all representers could change their behaviour based on the current user. Representers where this is not the case (e.g. Digest), can still explicitly opt-out.	9 years ago
Jan Sandbrink	ab9d502009	Allow to delete work packages via APIv3	9 years ago
Jan Sandbrink	3f269e43ae	Add link to delete an attachment to its representer	9 years ago
Jan Sandbrink	e7a6ae629e	Add specs for update links with missing permissions ... - also (for now) remove title text which was not localized - consistently use link helpers for the corresponding specs	9 years ago
Jan Sandbrink	e7291fba8c	Unify permission handling in representer spec	9 years ago
Jan Sandbrink	aad39544f5	Hide addAttachment link when user is not allowed	9 years ago