912 Commits (61d742afef7ec6fea846cfa09ac0797eed72aea8)

Author	SHA1	Message	Date
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	2b39d8fbdf	Cleaning up, Rubocop	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Jan Sandbrink	55a2cf9f51	replace references to Redmine::VERSION ... - we now live in OpenProject for quite some time - kept legacy specs because they are... legacy	9 years ago
Jan Sandbrink	8a0a60445b	update root representer ... - add it to the documentation - only provide links to resources that can be directly used (i.e. without templating) - provide useful general instance information	9 years ago
Jan Sandbrink	992888df2a	add configuration endpoint to APIv3	9 years ago
Jan Sandbrink	68d521ca85	add link for adding attachments to work package	9 years ago
Jan Sandbrink	1f7485d5bf	fix HTTP 500 in WP form ... - occured when an invalid type was provided by the client	9 years ago
Jan Sandbrink	1b5bb5ba98	use AR errors as mock	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	bc30b28558	extract attribute name conversion into extra class ... - consider special renaming rules for well known attribute names -> currently covering wp attributes and createdAt, updatedAt	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	138d3dba29	fix some specs ... - error messages now contain punctuation - when :save returns false, there should be errors present - errors in form representers are now API errors	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	c586a9cc8c	mock the model in model_contract_spec	9 years ago
Jan Sandbrink	13b9042293	treat all 422 errors the same for forms ... That means: Do render the form for all HTTP 422 errors, problems are highlighted within the form	9 years ago
Jan Sandbrink	8f110d8b93	adapt specs to new contract behaviour ... - also refine specs for done-ratio to check for non-fail when not changed - use shared examples for parent properties also in done ratio specs	9 years ago
Jan Sandbrink	ac9cffe741	remove tautology and add apropriate specs	9 years ago
Jan Sandbrink	e9059a97ee	style ... [ci skip]	9 years ago
Jan Sandbrink	ce0b906d91	dirty trick to allow using a Hash as mock ... also removes default value from initializer, which was never sane	9 years ago
Jan Sandbrink	0b7b4bf329	extract error merging into contract	9 years ago
Alex Coles	0436446257	Revert "DRY WorkPackageSchema#available_custom_fields spec" ... This reverts commit 8e47f600b0.	9 years ago
Alex Coles	8e47f600b0	DRY WorkPackageSchema#available_custom_fields spec ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	837265c257	Fix API v3 WorkPackageSchema for AR::Relation ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	61d77c721b	Fix TextFormatting#format_text specs w/requests ... * Make intent slightly clearer with a shared context. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jan Sandbrink	baaf452cbd	style ... [ci skip]	9 years ago
Jan Sandbrink	e50e18dba1	fix spec ... the actual hashes provided by grape have string keys	10 years ago
Jan Sandbrink	4054c2ae22	add a removeWatcher link to work packages	10 years ago
Jan Sandbrink	6406b640b7	remove redundant spec ... one could argue that I learned from @0xF013 to delete inconvenient specs ;-) But in this case the spec is really made redundant by the two specs below [ci skip]	10 years ago
Jan Sandbrink	db5d633850	update factories to new default preference ... also use boolean type instead of DB values	10 years ago
Florian Kraft	ccb2a6032e	repair legacy specs ... fix the application helper legacy spec fix text formatting spec to reflect anchors only mode w/o request Signed-off-by: Florian Kraft <f.kraft@finn.de>	10 years ago
Alexander Bach	88bd8756b4	Add test descriptions	10 years ago
Alexander Bach	ef88ca1339	Move out of place parenthesis back into position	10 years ago
Alexander Bach	8ae33c9d0f	Simplify test setup	10 years ago
Alexander Bach	a1ad5b92bf	Refactor test to use helper_class	10 years ago
Alexander Bach	21ee97b19f	Move test to proper location and benefit from it	10 years ago
Alexander Bach	e7f080efbb	Check link content as well	10 years ago
Alexander Bach	90ed907657	Ditch regex for more readable string	10 years ago
Alexander Bach	02cbe0165b	Improve test setup and checks	10 years ago
Alexander Bach	16f67e8fb3	Clarify spec purpose	10 years ago
Alexander Bach	f99b000ae8	Cleanup test	10 years ago
Alexander Bach	5d7a1d2cb4	Remove model_ prefix	10 years ago
Alexander Bach	ce81b7f4f2	Add specs for create form api	10 years ago
Alexander Bach	0e9e986f7f	Style fixes	10 years ago
Alexander Bach	c88cb306dd	Add all the specs	10 years ago
Alexander Bach	134dd61000	Fix spec once again	10 years ago
Alexander Bach	3ee80e98e8	Correct work_package_contract filename	10 years ago