330 Commits (673d8528c361b4c1886c3f77ec268ed9e58efc2f)

Author	SHA1	Message	Date
Markus Kahl	487811aa86	fix custom field validation on unpersisted record (#9050) ... * fix custom field validation on unpersisted record For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail * adapt spec to have the members created in setup Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	bc238d62be	fix custom field validation on unpersisted record (#9048) ... For unpersisted records, the customized value on a custom field is not yet set even though the custom field has been constructed using customized.custom_fields.build This needs to be countered by setting the customized explicitly. Without this, e.g. validations that depend on the customized fail	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	3094329287	explicitly allow polymorphic attributes	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765) ... * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
ulferts	c383c5821f	Fix/remove cucumber (#8847) ... * replace very last cuke with spec * remove cuke support files * remove cucumber gems * remove traces of cucumber * remove no longer required route * forcefully clear parallel_test features task * attempt removal of binstub * attempt to stabilize spec	4 years ago
ulferts	a842f44bda	[22048] Destroy journals after destroying journalized ... * clenaup journal data upon aaj model removal * remove unused methods * simplify aaj options handling * delete orphaned journaled data via migration Existing instances might already have journal data for which the journal itself is deleted. This migration removes them.	4 years ago
ulferts	bf89e934b3	set the default value for newly build custom values ... Most of the time, the getter #custom_field_values is used with unbeknown to the caller will build custom values for not covered custom values. This method always assigned nil to the value of the newly build custom value when it should have used the default value. Once that is fixed, all models including acts_as_customizable will again have set the default values for custom fields correctly. This is true regardless of wether the custom value is added before or after the creation of the model. Only for work_packages is the additional method #set_default_values! required as the availble_custom_field might change during a request upon a switch in project and/or type.	4 years ago
ulferts	8dfc5e8803	fix touching the customizable on removing custom_values ... Before the commit, the existing custom_values where attempted to be reused but there was no deterministic behaviour with which reusing them was attempted. Additionally, the existing values where always changed (or they would receive the current value again) whenever values where provided, regardless of whether those values actually changes. There was no explicit flag that a value was removed. This poses a couple of problems: * Even if no new values where provided the order of the custom values as stored in the db might change leading to journal entries that where not actually caused by the user. * If values where only removed, due to the missing explicit removal flag, it became luck whether an existing custom value was actually changed. Only then would the customized object be touched leading to an update of cached fragments, i.e. representers. * Because the values where updated all the time, the performance would suffer. * Removed custom values where removed right away and not only after save. This commit introduces an explicit flag for removal and does not alter existing custom values. This might have the drawback of creating a custom value even when a value, chosen to be removed by the user, could be reused but this should be negligible. It also has the drawback of introducing a flag to be maintained.	4 years ago
ulferts	8969afe617	close time entry modal on enter (#8653) ... * close time entry modal on enter As the time entry is saved anyway once the user saves the form, e.g. by pressing enter in the hours field, we can close the whole modal along with it. The "Save" and "Cancel" buttons do not make sense then anymore * attempt to stabilize flickering spec * fix ruby 2.7.1 hash parameter deprecations	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images ... Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
ulferts	75b308d154	fix permission checks for edit_own_work_package_notes	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
Markus Kahl	e4bd453be5	use double splat as not using it is deprecated	5 years ago
ulferts	1773a89c5e	return true to signal success	5 years ago
ulferts	2ed7a69943	rely on caller to reset the journal notification setting ... By forcing the caller to disable mail sending via a block, we can also ensure that the value is reset. But by it, we can allso allow disabling mail sending for multiple save_hook runs which was not possible before.	5 years ago
ulferts	67ade5002d	extract journal notification setting to separate class	5 years ago
ulferts	64d0f57d85	Feature/aggregated activities (#8221) ... * use cte for aggregated journal * Revert "use cte for aggregated journal" This reverts commit 5fedefefdd. * add another subselect that could later on be provided from the outside * allow passing a nukleous sql to aggregated journals * wip - using aggregated journal for activity * new sql for aggregated journals * start implementing new aggregated query * additional documentation * consolidate activity functionality * simplify by turing into instance methods * move activity fetcher out of redmine * remove verb verification made obsolete Without catchall routes, the dispatching handles it * remove duplicate authorize check * refactor activities controller * refactory activity fetcher * cache avatar file * sort choosable events * remove legacy spec covered by contemporary * speed up aggregated journals via CTE * instance var might never have been set * ensure the event_types are always transmitted * correctly reset the avatar cache * fix avatar fetcher expectation regarding wiki pages * adapt spec [ci skip]	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275) ... * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
ulferts	f99cf94249	Revert "save sql request by differentiating between create and update" ... This reverts commit ee2401c55e.	5 years ago
ulferts	7f811f7931	restructure aaj configuration	5 years ago
ulferts	5b5c110a77	remove unused method	5 years ago
ulferts	d6f73461bb	remove unused aaj Versions module	5 years ago
ulferts	d7b316c903	remove usused aaj options module	5 years ago
ulferts	1f2b0b1dd7	remove unused/outdated reset functionality	5 years ago
ulferts	7cd51d6443	remove unused users module	5 years ago
ulferts	830451d9f9	remove unused changes module	5 years ago
ulferts	f8d349b0b6	extract method	5 years ago
ulferts	ee2401c55e	save sql request by differentiating between create and update	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	211ccf3472	avoid attempting to reclaim already claimed attachments	5 years ago
ulferts	2bc34e5006	deprecate attach_files	5 years ago
ulferts	0cda1869a8	employ advisory lock for all update services	5 years ago
ulferts	e9fe3ede11	restict tsv extraction to work package	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	5869966f12	relay available_custom_fields call to cacheable class method ... That way, we avoid n+1 queries for the available custom field especially in scenarios like schemas and api collections where a set of models is queried for their custom fields	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
ulferts	18d0450ee9	use default rails autosave ... If the custom values are saved (i.e. created) in an after save block, their saved_changes are empty	5 years ago
ulferts	18c7e42633	replace legacy watcher spec	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	e7263fcedb	migrate to rails 6.0.0	5 years ago
ulferts	58e3e7c80c	linting	5 years ago
Oliver Günther	64e6fae1b8	[30442] Use formatted custom value in xls export ... This also fixes localized output of custom fields such as float https://community.openproject.com/wp/30442	5 years ago
ulferts	05a5a0fec6	custom text widget on my page	5 years ago