4327 Commits (6a7f9a2535d1df101559cd94e164953d3230a946)

Author	SHA1	Message	Date
Oliver Günther	ec56455edd	[37124] Handle the case when estimated hours was set to 0.0 (#9280) ... https://community.openproject.org/wp/37124	4 years ago
ulferts	9edc7244a9	fix displaying `multi` toggle in cf form (#9269)	4 years ago
Oliver Günther	1ac2de19ff	[35328] Allow more default overrides (#9262)	4 years ago
Oliver Günther	6c75e16dc4	[37140] Use acts_as_url to generate unique slug for identifier (#9250) ... * Use acts_as_url to generate unique slug for identifier * Re-enable project identifier spec now handled in backend * Add integration spec for set attribute service * Adapt spec for new empty identifier * Avoid double error messages for empty identifier acts_as_url may return an empty string depending on the name, but the empty presence validation will suffice in this case, we don't need the invalid validation * Fix stubbed errors object accessed by acts_as_url * Avoid trying to get the upstream unique attribute in case of errors * Remove sequential_project_identifiers setting * Adapt spec to review feedback	4 years ago
Oliver Günther	af4922ebf6	[37124] Add formatter classes for estimated hours and generalize (#9252) ... Only xls exporter had formatter classes which are generic enough to replace all other exporter formating methods. https://community.openproject.org/wp/37124	4 years ago
Oliver Günther	fa3481523b	Avoid running oauth cleanup job after every authentication (#9241) ... * Avoid running oauth cleanup job after every authentication * Also run attachments job as 'cron' job	4 years ago
Markus Kahl	6156d4b837	fixed attachments deletion in backup_job, and more (#9221)	4 years ago
ulferts	5cb227796c	Fix/hook service to openproject (#9214) ... * move specs from legacy * move Hook into OpenProject namespace * replace class variables	4 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202) ... * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
Oliver Günther	2896afe6c4	Assign project identifier in backend (#9196) ... * Introduce localizable slug url Stringex currently works only with english strings for wiki. But that default is actually confusing. Instead, add an explicit localizable helper that receives the locale and sets the stringex backend locale temporarily * Generate a default identifier in the backend * Remove JS based identifier updating * Remove identifier attribute * Add button to change identifier * Adapt tests to changed identifier * Linting * Fix invalid selector	4 years ago
Oliver Günther	6086f320e8	[37036] Always return user attributes when sync_users enabled ... When a synchronized group has sync_users enabled, we want to synchronize the user to OpenProject even if the connection doesn't have onthefly_register enabled. But currently, the user attributes (name, mail, etc.) are only returned if onthefly_register is set so the synchronization will never work without it being set on the connnection https://community.openproject.org/wp/37036	4 years ago
Markus Kahl	8c8b8bbfa7	create backups via UI (#9136) ... * create backups via UI * Fix import of modal service * introduced backup token and addressed remaining comments * allow disabling permissions * improvements - only make user wait to use backup token in if really necessary - notify admins of new backup token - disable 'include attachments' option in UI if unavailable - documentation - misc * spec fixes * fixed feature spec * allow setting capybara host in every case * removed unused style file * addressed review feedback, added further feature specs * polish (code climate) * Avoid empty attachments * Don't raise filesize validation for internal exports Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	0bec3cb8c2	fix namespace of actions (#9195) ... The actions are now more rubyish again which will reflect in the urls where we also have an underscore based pattern	4 years ago
ulferts	21f1cd2cc3	Feature/project action filter (#9194) ... * define action for copy projects permission * introduce filtering project list by current user action	4 years ago
Oliver Günther	5920ace376	[37024] Make system user permanent admin (#9192) ... * [37024] Make system user permanent admin https://community.openproject.org/wp/37024 * Yield self from run_given * Fix count for admin in bim seeder	4 years ago
ulferts	651f115300	limit any_name_attribute filter operators ... `=` and `!` used to be supported but resulted in comparing the concatenation of first/last-name, login and mail as a whole and not individually. As the filter is mostly used as a fuzzy search, it is ok to only support contains and not contains.	4 years ago
Oliver Günther	174427fc05	Remove duplicate not_locked scope (#9166) ... * Remove duplicate not_locked scope The enum itself creates scopes but they do not include not_builtion. So instead, let's create these scopes ourselves * Change enterprise spec to no longer test for builtin users	4 years ago
ulferts	9fa5599392	Feature/member notifications (#8958) ... * spec with correctly scoped links * move db check into own file - fix deprecation * basic spec for member creation service * use constants for all notifications * send an OP notification after member has been created * send an OP notification after member has been updated * mails on group member added Depending on whether the membership existed before or not, an updated or a created notification is send. This is done asynchronously. * move all mail sender background jobs into namespace * wip * wip * correct handling group member notifications * add setting enable/disable mail sending on member alterations * use services in members controller * move Notifiable to OpenProject * remove member after save hooks * cleanup/testing/linting * render member mails in receiver locale * remove add_member! method * use mailer layout for all mailers * Update app/services/groups/cleanup_inherited_roles_service.rb Co-authored-by: Oliver Günther <mail@oliverguenther.de> * use around callback to avoid prepending * handle nil params Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Benjamin Bädorf	3f3e831f6a	Add any name attribute filter to principal resource collection (#9170)	4 years ago
Philipp Tessenow	bd906716e5	[#36153] link manually created pull request to a work package using the GitHub integration plug-in (#9070) ... * Receiving and Parsing GitHub webhooks * added services for upserting PullRequests, GitHub users, and, checks. * added the datamodels for storing these entities * added logic to parse GitHub webhooks and save the entities above * fix some specs, added model specs * let UpsertPartialPullRequest return the upserted PR * added the last missing specs * avoid double-posts when editing pull requestsx * attempt to reduce flakiness * added pull requests API endpoint * handle edge case of converting partial PRs to full PRs * name raw input of an upsert service 'payload' to differentiate it from the prepared params * handle edge case: partial upsert after full PR creation * github_user does not reference users anymore * fixed a doc comment * use enums instead of custom validations * WIP * pairing with jens and some cleanup and test writing * better migration, clear up old PRs with a cron job * handle case of non-edit events which do not introduce new linked work packages, but still require a comment	4 years ago
Oliver Günther	2d22930bdb	[36746] Unset plain password accessor after saving (#9157) ... * [36746] Unset plain password accessor after saving Otherwise, this password remains and is validated again due to "user.register!" which then fails with an exception https://community.openproject.org/wp/36746 * Don't try to use user.password after saving it now gets cleared * Remove user.password usage in specs The user password attribute is an accessor that now gets deleted after saving so tests can no longer depend on it being present after created from a Factory * Also retain user password in mail handler	4 years ago
Oliver Günther	8f5006a51b	Rename ActiveRecord class to UserSession for clarity	4 years ago
Oliver Günther	aeec219bfb	Fix connection being memoized in sqlbypass class	4 years ago
Oliver Günther	daa0cfdee9	Ensure we're not memoizing the connection (#9153)	4 years ago
ulferts	8f01fa7dab	add action filter to capabilities query	4 years ago
Oliver Günther	0d71772c37	User SqlBypass sessions to avoid ActiveRecord for session storage (#9142) ... * Use SqlBypass sessions to avoid ActiveRecord for session storage * Set default host if Capybara.app_host does not exist	4 years ago
Oliver Günther	ac049663a3	Add multiple option for project custom fields (#9125) ... * Allow multi-select CFs for projects * Render multiple custom values in project row * Output arrays from custom_value_attributes for multiselect values * Add spec for copying multi-value cf * Fix custom field multiselect form on new custom fields * Fix custom field builder specs * Add spec for creating/updating projects with multi select * Add spec to create new multi select project cfs * Add spec for projects index displaying of custom fields	4 years ago
ulferts	4bf7a26eb1	Capabilities API (#9083) ... * Capabilities API * introduce auxilliary capability model * capability model and query * render in sql * fix pagination * introduce sql representer * extract abstract sql representer class * remove yet unused methods * abstract sql collection representer * contract_actions as part of permissions * filter for capability id - used in GET * id filter validation * remove unused representer * remove unused wp representer * reuse renaming class * add spec for access control * add principal filter to capability * add context filter * extract capability sql into scope * admin gets all capabilities * require to have one filter set to keep performance bearable * consider active project modules for capabilities * limit capability based on principal visiblity and user state * rework capability to be tableless * spec not being allowed to see on request level * add actions to capability representer * add action api * extract sql index endpoint * remove unused class * prepare sending signaling error - not yet frontend exposed * extract show endpoint for sql rendered responses * use UNION for better performance * include navigation links on collections * remove string replacements * extract collection representer into hal sql module * no capabilities when blocked * remove commented out code	4 years ago
Oliver Günther	22f022ff82	[36596] Fix group assignee returned non-active users (#9111) ... https://community.openproject.com/work_packages/36596	4 years ago
Oliver Günther	e7bcf3105b	[36548] Avoid using batch PDF export if pdfunite missing (#9098) ... * [36548] Avoid using batch PDF export if pdfunite missing We cannot guarantee that pdfunite is installed through poppler-utils, for example in unsupported distributions. In this case, we'll want to revert to the default export of all work packages. https://community.openproject.com/work_packages/36548 * Add dependencies for centos installations * Review feedback	4 years ago
ulferts	7e68bd8ce1	avoid nil for wiki page slugs as they would be invalid (#9081) ... * avoid nil for wiki page slugs as they would be invalid Also explicitly enables having "!" for a wiki title but fails hard for all cases, which are not handled by default or custom. * move legacy specs over	4 years ago
Oliver Günther	12ceb6e7ab	Fix message-id regex in mail_handler	4 years ago
Oliver Günther	c358b071c5	Fix message-id regex in mail_handler	4 years ago
Oliver Günther	134552e95c	[35853] Extract formatting in PDF export for custom fields (#9095) ... https://community.openproject.com/work_packages/35853	4 years ago
schuemann	b577ed62ec	[#36518] respect hide mail preference in member list (#9072) ... * [#36518] respect hide mail preference in member list The member table should hide the email address if the user has the "Hide my email address" box checked in their profile. * [#36518] respect hide mail preference in member list Updating feature spec * Updating feature spec * Add transient preference object * Include preference to avoid n+1 query * Correctly pass user_id= to super * Fix now invalid usages of user_preference factory * Rewrite attribute check to include user attribute_present? does not return true for relations such as user_id * Only save a preference if the transient factory got used Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	a023ccf372	[36517] Fix placeholder filter returning query object, not AR collection (#9071) ... We depend on the query for correct sorting by name. https://community.openproject.com/work_packages/36517	4 years ago
ulferts	ab6d98383b	fix member filter on principals (#9063) ... In case of the `!` operator, other memberships interferred. This was because of the left join leading to result sets that where not of interest. The now used not.in does not have that problem	4 years ago
Wieland Lindenthal	c4c2149d98	Fix: 36299 -- Allow to modify login when global permission :manage_users present (#9026) ... * Refactoring: Create shared examples for user contracts * Users::UpdateContract spec added * Add spec for updating the login of a user * Add spec for permitted params when global permission to :manage_user * Remove spec for :login updates for user UpdateContractSpec The writability of the login attribute is not part of the contract (yet). * Use user contract for checking writability of user attributes * Fixing user contract specs. * use persisted user in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	65575d44f1	[36415] Add public filter to projects list (#9057) ... https://community.openproject.com/wp/36415	4 years ago
Oliver Günther	8122d05a66	Add visible scope for placeholder users (#9042)	4 years ago
ulferts	b8ca382d34	Group API (#9034) ... * include group members into resource * GET /api/v3/groups endpoint * POST /api/v3/groups * PATCH /api/v3/groups/:id * DELETE /api/v3/groups/:id	4 years ago
Oliver Günther	37bef43cea	Introduce visible scope to principals ... When a user has the manage_users permission in any project, they are eligible to view all users for inviting them to the project. This however is not reflected in the principals API, where only users in all visible projects are found.	4 years ago
Oliver Günther	4980b4fb4a	Allow LDAP filters and groups to individually sync users (#9031)	4 years ago
ulferts	e832e626ab	use actual user display setting name ... `login` does not exist, `username` does	4 years ago
Wieland Lindenthal	ffa5ac84a8	Allow deletion of placeholder users when permission of :manage_placeholder_user give (#9018) ... * Refactoring: Rename permission :add_user and :add_placholder_user to :manage_user and :manage_placeholder_user * Add deletion to :manage_placeholder_user permission label * WIP: Check :manage_placeholder_user permission before deletion Specs still missing * In controller rely on authorize_global for deleting placeholder users * Add deletion_info for placeholder users * Extend specs * Set placeholder users to locked when deleting * Review feedback Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	f4dfd6c6c6	[36238] Extract and fix user references in other objects (#9007) ... * Move replacing invalid references into separate job for principals * Write migration to remove existing invalid custom values and responsible * Fix other specs * Fix other specs * rewrite replacing user in records * consolidate principal deletion * include placeholder users in spec Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
Oliver Günther	0c9fb9b1af	[36206] Make force_no_page for ldap configurable ... https://community.openproject.com/wp/36206	4 years ago
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944) ... * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973) ... * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago