4327 Commits (6a7f9a2535d1df101559cd94e164953d3230a946)

Author	SHA1	Message	Date
Oliver Günther	4bb47cd935	[33750] Ensure default statuses can not be set read only ... https://community.openproject.com/wp/33750	4 years ago
ulferts	50daff5062	Fix/archived projects via api (#8625) ... * minor code cleanup * allow access to archived projects via api for admins The visibility check will not work in this case as no permission is active on archived projects. We therefore need to return all projects for admins at least	4 years ago
Oliver Günther	24005a9e6d	[34000] Ensure user custom fields can be copied ... User CFs were not copiable because they depend on project members being copied. They need to be overridable in the copy form however, so we need to be able to set this before and after members are copied. The only option is to allow visible members to be selected there. https://community.openproject.com/wp/34000	4 years ago
ulferts	a9dfb35150	avoid modifying frozen string from nil	4 years ago
Oliver Günther	5d43198a88	Fix joining of integer values in escaped template ... This results in an internal error if trying to add multiple filter values. Let rails handle the escaping instead. [ci skip]	4 years ago
ulferts	e2961fba14	replaces reform & custom error handling ... Replaces reform by a simple layer of Disposable + ActiveModel::Validations for contracts. Additionally removes the custom error handling where OpenProject added symbols to keep the ability to identify faulty attributes while having non standard format (deviates from `%{attribute} %{message}`). Changes to active record now allow us to define the format of a message on i18n level, e.g. `%{message}`. Therefore the patching can be removed. Reform plans to remove support for ActiveModel::Validations in version 4.0 at the latest but even today, support for it is hapazard. As we do not need the full stack of Reform anyway, we can solely rely on Disposable.	4 years ago
ulferts	2154701a02	hide derived_* from form configuration	4 years ago
ulferts	7e7b9132e3	Fix/child scheduling restrictions (#8584) ... * allow free scheduling children of manualy scheduled parents If a parent has a follows relations with another work package, that relationship also limites children of the work package. But if the work package is scheduled manually, this creates a scheduling barrier. Children of a manually scheduled work package are not hampered by the follows relationships of the parent or other ancestors. * simplify soonest_start query * eager load * extract to scope	4 years ago
Oliver Günther	e1a88a9a40	[34001] Ensure filters always receive the query context ... In the mentioned project, the query copy service fails to execute because a filter has lost its context right after `query.save`. There is a hook for `after_commit` which is not relevant here since we're in a transaction, but the context is lost regardless. Instead, we could ensure whenever accessing the filters, the context is set correctly. https://community.openproject.com/wp/34001	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
Oliver Günther	c369a71f4d	Allow project help texts on the rails form ... Renders help texts on a project core attributes and custom fields	4 years ago
ulferts	6826f90ee2	Feature/remove timelog (#8557) ... * rename costs, introduce budgets * move files from costs to budgets * rename cost_object to budget * remove unused code * move hook - should be turned into standard code in the long run * move type attributes change over to budgets * move patch to work_package proper * move budget menu item up * combine reporting, time and cost module * remove rails based time_entries & reports code * rename cost object filter * adapt menu spec expectations * use cost project module name in administration * include timeline labels in migration * properly place budget linking method * fix permitted params * remove outdated routing spec * adapt budget request specs * ensure order of descendent updates * remove outdated specs * fix checking for reporting to be enabled * fix displaying spent units * fix time entries activity event url * reenable current rate tab * fix path on budget page * allow bulk editing of budgets only in one project scenario * fix sanitizing reference in controller * include module required for format_date * fix reference to correct units from work package spent units * linting * remove outdated spec * remove outdated views and permission references * remove acts_as_event from time_entries There is no atom link for time entries * remove acts_as_event from projects There are no atom links for projects * introduce budget filter for cost reports * remove actions added to removed controller * move time entries to the costs module * factor in view_own permission when calculating time entry visibility * linting * move mounting of time entries * include budgets into api v3 documentation	4 years ago
Markus Kahl	0c582c4f35	use create to be sure we have an id later	4 years ago
Markus Kahl	5e795a844a	remove unnecessary redefinition of order_by_name scope	4 years ago
Markus Kahl	0792ed6443	fixed fog file uploader path in pending attachments	4 years ago
Markus Kahl	b85380f068	handle pending attachment validation errors	4 years ago
Markus Kahl	b483e6cd35	consider validation errors during pending attachment creation	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	655f021b92	add derived dates to the work package resource ... The derived dates are the minimum/maximum of the descendant's dates. As long as the work package is scheduled automatically, the derived and non derived dates should be equal althoug the derived dates will be null in case non descendants exists. But if the user decides to activate manual scheduling the dates can deviate. The derived dates can then help to display the deviation to the user. This commit however does not alter the front end. The dates are eager loaded on the work package index commit using the same mechanims already introduced for spent time. The patched cost attributes, which are also eager loaded, are now eager loaded in the core as well so the patch is removed. As those attributes are now part of the core (although in a different module) it no longer makes sense to rely on patching for this.	4 years ago
bsatarnejad	1fbc75b96d	writing a test for estimated-hours filter with none and zero values	4 years ago
bsatarnejad	27d93a30c4	show data which is zero when we filter 'none'	4 years ago
Oliver Günther	f37d6d563d	[24343] Allow PDFs to be served inline ... It still depends on the browser whether inline PDFs are allowed. In Firefox, you can configure this manually what should happen. In Chrome, I'm not sure if there is such an option. https://community.openproject.com/wp/24343	4 years ago
bsatarnejad	5f0b48617c	writing a test for estimated-hours filter with none and zero values	4 years ago
ulferts	829648e1ad	remove operators not applicable to only subprojects filter ... The none operator does not make sense as it means that no work package will be returned. And the all operator will be the same as not having the filter at all. There is a minor change in the UI in this change in that the order of the opertors of the subproject filter is altered. But this should not be a problem for the user and leads to a simpler implementation.	4 years ago
ulferts	3a3a48e267	journalize changes to the scheduling mode	4 years ago
bsatarnejad	a0a5d9c88b	show data which is zero when we filter 'none'	4 years ago
Oliver Günther	d43d9e6e00	Add subproject boards and extract common board action class	4 years ago
Oliver Günther	6663a3e404	Don't raise error if to-destroy groups are not found	4 years ago
ulferts	7065c162fd	disregard manually scheduled nodes when scheduling work package graphs ... Instead of fetching all work packages from a subset of the whole graph constructed by hierarchy and follows relationships upon scheduling, only work packages eligible for automatic rescheduling are returned. In order to avoid quering the database multiple times, the whole subgraph is returned at once using a recursive CTE.	4 years ago
ulferts	5633b901db	remove unused service	4 years ago
Oliver Günther	a92575e3ec	Use distinct(*) on aggregated journal to avoid duplicate raw journals ... https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	c6b9c8ff02	Use distinct(*) on aggregated journal to avoid duplicate raw journals ... https://community.openproject.com/wp/33744	4 years ago
Oliver Günther	2fed3ee301	Add filter to select only (non-) milestones	4 years ago
Oliver Günther	2feaec1101	[33678] Priority needs to be a require field ... Priority was marked non-required for it to turn up in the attribute form configuration. But priority _is actually required_. This results in the frontend adding an optional placeholder `-` value, which makes the resource unsavable. This commit adds priority to the form, but keeps it required as it should be. https://community.openproject.com/wp/33678	4 years ago
Oliver Günther	38e913cb00	Skip schedule_manually in attributes ... [ci skip]	4 years ago
Oliver Günther	b1a99353e2	Extend attribute help text for projects and allow images ... Attribute help text so far could only be added to work packages. This commit adds support for projects and adds the help texts to widget headers for status and description modals in the overview tab as well as extending the attachable mixin to allow uploading images. Uploaded attachments are to be expected to be visible regardless of permissions, thus this also adds an option to make attachments visible to all	4 years ago
Oliver Günther	95e3aaa511	Avoid definition of acts_as_list ... This is going to reorder items as they are being inserted, and we don't even use acts_as_list for ordered work packages	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	e63f102c82	Restore custom style rendering with css variables ... Uses the css variables to set the default values instead of using the previously ruby-defined variables	4 years ago
ulferts	0e4ce2f829	extract common sql into method ... This prevents errors like the one fixed in the commit before	4 years ago
ulferts	2b126dd064	allow using index scan on sorting by list cf ... Without the additional condition on the customized_type, a `Bitmap index scan` is used. With it, an index scan on custom_values_customized can be employed, reducing the rows significantly	4 years ago
Henriette Darge	b7ab9483ed	Remove too much spaces from the project name before saving it. Otherwise the spaces will cause problems later, e.g when trying to delete the project	4 years ago
Oliver Günther	f7d4439f65	Rewrite status as module	4 years ago
Oliver Günther	0bf2070741	Remove job reference in status	4 years ago
Oliver Günther	0ca1865dd9	Add reference to user in status, extend enum, and add payload ... - Adds the user reference directly to a job status, this avoids having a separate object for many cases - Adds a payload object to the status to transport information - Extends the enum with a type when the job was cancelled	4 years ago
ulferts	e20910a2c9	remove unused service ... The last call to the `reschedule_after` method was removed in #690e0ffc60.	4 years ago
ulferts	75b308d154	fix permission checks for edit_own_work_package_notes	4 years ago
ulferts	e14679d0b3	avoid loading aggregated journals repeatedly when patching	4 years ago
ulferts	7f39a3b08f	allow fetching activities by an id referencing a subsumed journal ... AggregatedJournals might contain a set of native journals. This change allows fetching an aggregated journal the id of any journal included in the aggregated. This provided clients with more available references to an aggregated journal. This is particularly helpfull in case the aggregated journal includes more journals than the client expects. This might happen when the journable is updated in the meantime. E.g. a user adds a screenshot to the last comment within the time frame available for aggregation; a user adds a comment, alters an attribute and wants to change the comment. At the same time, this change limits the aggregated journals created in the database to a particular journable. This has a severe performance impact as without the focus on a particular journable, potentially millions of journals will be aggregated to then only fetch one individual result.	4 years ago
Oliver Günther	e691340169	Add templated filter to project query ... fixup! Add templated filter to project query	5 years ago