19860 Commits (6fb65dad6a7b380edaddee3264da3386a4728cbc)

 

All Branches   

Search

Author	SHA1	Message	Date
Mihail Maxacov	6fb65dad6a	hound	10 years ago
Mihail Maxacov	42fd9237b5	switch frontend to new format	10 years ago
Jan Sandbrink	925a1fb706	don't pick the (random) last journal ... pick the first (and hopefully only) journal that has customizable journals	10 years ago
Jan Sandbrink	d1e3e2d543	simplify loop	10 years ago
Jan Sandbrink	264c58980b	change expectation back to falsey ... be_false == be_falsey, both expect falsey results alternative would be "be false", which expects real false... *confused*	10 years ago
Jan Sandbrink	a59df82ca1	only create CF accessor methods on demand	10 years ago
Jan Sandbrink	29a4c0ce67	test inclusion of property name	10 years ago
Jan Sandbrink	36e071087e	some renaming ... we are generifying the interpretation of the parameter we receive... added some words about assumptions...	10 years ago
Jan Sandbrink	9986466e15	use direct CF accessors in CF injector	10 years ago
Jan Sandbrink	e3537be022	add methods to directly access custom fields	10 years ago
Jan Sandbrink	1bf1cf2c1b	ignore custom values that are to be deleted ... - fixing the last failing test	10 years ago
Jan Sandbrink	1aa234ae58	fix another broken spec	10 years ago
Jan Sandbrink	afdd089080	add patch hint to full_message ... this hopefully makes clear which parts were changed by us and which belong to ActiveModel	10 years ago
Jan Sandbrink	4f9e93526e	avoid variable shadowing ... though unproblematic in this case	10 years ago
Jan Sandbrink	6f90674440	include more schema details for custom fields	10 years ago
Jan Sandbrink	7219eebee5	fix failing test unit tests ... requires to run validations for custom values every time, so we do it there was no clear indication on why they should not run always, it was not apparent either	10 years ago
Jan Sandbrink	f945585938	fix expectations	10 years ago
Jan Sandbrink	0dcd0a0c84	fix weird specs ... probably only worked because of unintended validation error from automatic validation: - testing to pass nil as value, though nil-values were explicitly ignored - assuming a single journal entry, though the WP is saved twice really needed to be fixed, because of new implementation: - valdiation errors now indicate CF id and are more specific	10 years ago
Jan Sandbrink	e4ee92aa3e	forbid validation of associated custom values ... this SHOULD already be the default, however specs failed here because of additional validation that took place. Those validations stopped by adding the validate-parameter. Better don't ask why I guess... Development and Production mode behaved as documented though (validate false by default)	10 years ago
Jan Sandbrink	36bb955f7c	add custom value errors to customizable ... - allows to relate error messages to their custom field - allows to use errors.full_message correctly for custom values - might break specs... we will see that soon	10 years ago
Jan Sandbrink	28e0ec21c0	use variable names	10 years ago
Jan Sandbrink	ec4d228956	split method	10 years ago
Jan Sandbrink	ff72c7760c	embed CF versions, users and string objects	10 years ago
Jan Sandbrink	2e1a999c6c	extract current_user into Single ... a current_user known by representers is an unfortunate concept, that we are using across multiple representers, so we should include it in the top level class for our representers.	10 years ago
Jan Sandbrink	9e88d73022	move creation logic into injector class ... helpers should be quite reusable across customizables	10 years ago
Jan Sandbrink	1a25e19c2f	remove 'true?' helper from custom_value	10 years ago
Jan Sandbrink	937fa2fba7	use class side instance variable	10 years ago
Jan Sandbrink	2e32e120f7	better naming	10 years ago
Jan Sandbrink	cd51dd98bc	style ... must have gone wild when I removed the "self."	10 years ago
Jan Sandbrink	943e01c978	use fancy ruby shortcuts	10 years ago
Jan Sandbrink	3161b9ca7b	remove unneccessary return statements ... this is how ruby style works... apparently	10 years ago
Jan Sandbrink	5ba53b49b9	various small fixes	10 years ago
Jan Sandbrink	2fb0e370ad	only perform validation if it is possible ... IMO the best way to deal with that ugly inter-validation dependency. You just can't meaningfully test whether a value is valid, when you don't know its format.	10 years ago
Jan Sandbrink	25dec31c5a	extract some case statements into fancy strategies ... - 17 new files - lots of new lines of code - specs! - same functionality as before	10 years ago
Jan Sandbrink	3f72769f1a	add required and writable into parameter ... - are set on all instance creations anyway - still optional in case you do not want to set it	10 years ago
Jan Sandbrink	3565137789	sty13	10 years ago
Jan Sandbrink	d61c2ff4aa	add remaining specs for CF injector	10 years ago
Jan Sandbrink	ed32c6594e	fix broken specs	10 years ago
Jan Sandbrink	05884417f7	let custom values return typed values ... this allows to have type-correct JSON output, e.g.: 12 instead of "12" true instead of "1"	10 years ago
Jan Sandbrink	a5e58dc8d0	add more specs for the CF Injector ... - fixing the worst typo ever - failing for bool, float and int...	10 years ago
Jan Sandbrink	1278ea221b	make a formattable of text custom fields	10 years ago
Jan Sandbrink	ef17eb8135	stop overriding new	10 years ago
Jan Sandbrink	0be2c94e49	update method doc	10 years ago
Jan Sandbrink	9532c39c5e	add another case to repair list custom fields ... Genius idea to require the parameter of a method to carry totally different information, depending on internal state of the object	10 years ago
Jan Sandbrink	5c3eae32f6	style	10 years ago
Jan Sandbrink	ac655ac789	validate user and version custom fields	10 years ago
Jan Sandbrink	95299bda36	remove obsolete specs ... - were disabled (and outdated) anyway - are both already implemented elsewhere in the same test file	10 years ago
Jan Sandbrink	1ab1f65f0d	fix specs	10 years ago
Jan Sandbrink	e1948206fa	extract method into ResourceLinkParser ... - similar code was already used in two different places - now the error message makes sense for both occurences	10 years ago
Jan Sandbrink	03c6fcdf6f	rewrite ResourceLinkParser ... - use own RegExp instead of borrowing the ones from Grape routes - add specs	10 years ago