openproject

Commit Graph

Author	SHA1	Message	Date
Alex Dik	a6170eb164	Move WorkPackageService to new components location	9 years ago
Oliver Günther	c6a01459a4	Split view: Add watch, unwatch buttons	9 years ago
Jens Ulferts	7577385057	first stab at updating form on type switch	9 years ago
Oliver Günther	bd1247d376	Strip notify from frontend The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Oliver Günther	1d789b0fba	Globally disable CachService in run block Avoid checking the state of the cache in every resource loading, but rather disable it upon startup.	9 years ago
Oliver Günther	ce759d3725	Allow more than one cache	9 years ago
Oliver Günther	0b77d9a389	Disable CacheService for testing	9 years ago
Oliver Günther	d3d6cd60ee	Temporarily store promises until they are resolved The original commit simply stored promises into the cache, which seemed to work in browsers but failed with karma/PhantomJS. I'm not yet certain why that is, but I wanted to get rid of complex objects in sessionStorage anyway, so this commit does: * temporarily store running promises for a given key * cache the resolved data directly	9 years ago
Oliver Günther	64d5b399c5	Experiment with angular-cache One prominent example where we can employ frontend-side caching is the fetching of associated users in activities. For a large number of comments of the same user, that user is retrieved once per activity, which causes a drastic overhead. This commit introduces a simple wrapper around angular-cache to store values in the sessionStorage.	9 years ago
Oliver Günther	868671475c	Use correct manual work package form path The new controller builds its own API resource using the static `/projects/:identifier/work_packages/form` path, which was expanded with the `/api/v3` prefix until `0c768829e7`. With this commit, the resource was invalid and causes new work packages to be broken. In order to restore the manual path, a new path helper was created.	9 years ago
Alexander Bach	cb890e60ac	Added addNotice for consistency	9 years ago
Jens Ulferts	0c768829e7	rely on fully qualified uris for HALAPI As we should more and more rely on the links provided by the API, it makes less and less sense to construct the urls by ourselves. We can simply use the links, the api offers. There are still a lot of places that construct the uri manually. The HALAPIRessource adds to that manual construction by adding [appBasePath] + /api/v3 to every path provided to it. The callers do now have to care for that. The current callers have been altered so that they do by relying on the PathHelper which should reduce the places in which uris are constructed.	9 years ago
Oliver Günther	9ad48023ed	Always allow attachment upload for new work packages `af73d60773` introduced a check whether the work package contains a link addAttachment (i.e., the user is allowed to :edit_work_packages). For new work packages, this link is not available, thus we need to provide some alternative as for now, when adding work packages it is always possible to add attachments (given the :add_work_packages permission).	9 years ago
Stefan Botzenhart	4e3a0050ec	Provide bulk destroy functionality for work package This is considered to be hacky and needs to be removed soonest.	9 years ago
Tim Habermaas	8554125f63	Move isInitialActivity to ActivityService.	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jens Ulferts	38cc9ff716	remove outdated comment	9 years ago
Oliver Günther	de96916dac	Minor corrections This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Oliver Günther	528e2f92e2	Load preselected work package when required	9 years ago
Florian Kraft	07058738a1	handle injections to watchers service properly and add tests Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64daddf767	remove dead code and provide helpers for the array sets Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64ba83a718	make watchers removable Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f47418de07	provide a method of adding watchers Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	6025a1b0e5	add a lookup directive Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	3ff36d9247	prepare the directives and load both available and watching users Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	f4b820553a	allows for creating error notifications with only an error message	9 years ago
Jens Ulferts	6658334bb3	specs for api-notifications-service	9 years ago
Jens Ulferts	bff5374075	separate NotificationsService and ApiHelper	9 years ago
Jens Ulferts	2862fbfa1c	replace flash-message directive by NotificationsService The NotificationsService renders the flash-message directive irrelevant and it additionally displays the notification much nicer than the directive. Additionally, an ApiNotificationsService is introduced that is able to cover error formats provided by the experimental api-	9 years ago
Florian Kraft	2fe9e49b47	correct test for new error notification Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	889056ec4b	fix added menu items after query save as - links would be wrong on subdirectory installations	9 years ago
Florian Kraft	0578ad4b90	correct the conversion service to actually work Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	acedeb9604	do not ask the api for attachments when nothing changes Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	cac48d3bae	wrap the size definition into a helper method the directive should not really care about whether an attachment is kB or MB in size. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	55466d97a0	show file uploads in kilobytes Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	c9ac13197a	check for filesize Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	bfd4ed19d1	rebased against new notification styles This will introduce some changes throughout the notifications. Upload notifications can now group the uploads and the new notification system can now receive removal commands. In addition, I took the liberty of adding some minor animations Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	647ba83876	emit a message when uploads are pending Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	31e6d58a4c	add notification service with a centralized directive this will enable notifications to be sent from anyone using the service, displayed by the directive. It currently uses the $rootScope which is pretty inefficient and should probably refactored to an pub/sub pattern style implementation Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	d1929f5a17	add a basic upload service Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jan Sandbrink	178a03218a	remove unused argument	9 years ago
Jan Sandbrink	093a8acf6f	replace type access via APIv2 by APIv3	9 years ago
Jan Sandbrink	670a571ca0	replace priority access via APIv2 by APIv3	9 years ago
Jan Sandbrink	5476c6fbe4	replace status access via APIv2 by APIv3	9 years ago
Florian Kraft	73b58e2d32	simplify work pacakge creation method Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	7c5de3669a	refactor the HALAPIResource Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago

1 2 3

138 Commits (71d96ccb69ab641d70536c231e178ae4f822af02)