204 Commits (7450c77e88f0cbf214cf0c2a0483b1aeda53ad89)

Author	SHA1	Message	Date
Oliver Günther	e5dec2dc31	Add notification group_by for projects with transformed keys	3 years ago
Oliver Günther	3b455b8129	Move base filter and order into their namespaces	3 years ago
Oliver Günther	ccfa29c728	Move license and copyright docs to root, fix names and references	3 years ago
ulferts	0666c89828	Feature/35708 wp typeahead filter (#9426) ... * breakup wp resource specs into separate files * introduce and employ typeahead filter on work packages Co-authored-by: Oliver Günther <mail@oliverguenther.de>	3 years ago
ulferts	ce5e06dde2	Fix/non matching pagination (#9202) ... * fix duplicates returned for wp list on multiple matching attachments/comments LEFT JOIN leads to potentially having multiple records returned if a search string is present in more than one attachment/comment. This is not a problem if we fetch work packages directly out of the query results but becomes problematic if only the id is fetched and then used to get the work packages by a subquery. * attachment filters no longer differentiate on tsv_where concatenation As EXISTS and NOT EXISTS is now used, the full string is always to be searched for so `and` concatenation is now always employed. * adapt spec Work packages that have no attachment at all are now also considered to match the filter if a "doesn`t contain" operator is used * less strict rspec rubocops for feature specs * cleanup code	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
ulferts	e9692f85a5	add filtering for assignee with placeholder users	4 years ago
ulferts	cc4ed56e2a	use AR`s scope method instead of singleton class method (#8976) ... * use AR`s scope method instead of singleton class method By using the scope method, all of Rails` checks and method definition usually done on a method are now also performed on the extracted scope methods 5f3ff60084/activerecord/lib/active_record/scoping/named.rb (L154-L190) * turn scope classes into modules	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961) ... * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	4d17b19783	[36026] Ensure project filter only searches for active projects ... https://community.openproject.com/wp/36026	4 years ago
Wieland Lindenthal	efbd3e9b41	Placeholder user backend (#8935) ... * Add missing copyright note to AnonymousUser [ci skip] * Addin PlaceholderUser model and its associations * Ensure PlaceholderUser do not "leak out" uncontrolled * Extract Associations for User and PlaceholderUser. - remove obsolete #assigned_issues - remove obsoete #:responsible_for_issues - add specs and factory for PlaceholderUser Adding specs to PlaceholderModel * Migration: enforce uniqueness of lastname for Group and PlaceholderUser * Remove obsolete callback `after_add` on groups association. The association of principals and groups still had a callback `after_add` that called a method `user_added` on the group. That method was not defined anymore as it was removed in commit d93ff52a27. * Move validation for #groupname to the right spec. * Cleanup placeholder and group specs * Remove Setting `workpackage_group_assignment` * Refactoring: Extract assignable scope from Project to Member * Refactor: Add Member scope not_locked. * deprecate hacky scope * remove wp_group_assignment specific test case Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	bf9bc70bb1	fix grouping by cf while summing (#8881)	4 years ago
ulferts	38d2707946	Fix/wp sums in db (#8580) ... * remove apparently unused methods * have specs for wp query sums * grouped sums in sql * sql for total sums * alter interface of all_grouped_sums Since we now fetch all sums in one sql statement it no longer makes sense to fetch the group sums individually * remove now unused method * extract method * Add material_costs to summing * add labor_costs to group sums * add overall costs to sum * fix sum grouping descision * fix summable? check * remove work_package_list_summable_columns setting Now all summable columns are always summed. The user no longer needs to select summing up in the settings. Selecting the column to be displayed and activiating sums will suffice * fix flickering spec	4 years ago
bsatarnejad	1fbc75b96d	writing a test for estimated-hours filter with none and zero values	4 years ago
bsatarnejad	5f0b48617c	writing a test for estimated-hours filter with none and zero values	4 years ago
ulferts	829648e1ad	remove operators not applicable to only subprojects filter ... The none operator does not make sense as it means that no work package will be returned. And the all operator will be the same as not having the filter at all. There is a minor change in the UI in this change in that the order of the opertors of the subproject filter is altered. But this should not be a problem for the user and leads to a simpler implementation.	4 years ago
Oliver Günther	d43d9e6e00	Add subproject boards and extract common board action class	4 years ago
Oliver Günther	2fed3ee301	Add filter to select only (non-) milestones	4 years ago
ulferts	33099d666c	use integer/float value for summing	5 years ago
ulferts	a0565b435e	fix cf sums integer overflow	5 years ago
Henriette Darge	ebc3f6fe18	Prevent that the backend changes the order of filter attributes (sorted by id). Otherwise there is a visible change in the filter attributes in the frontend.	5 years ago
ulferts	abac033cd4	adds the `not equals` operator to subprojects	5 years ago
Oliver Günther	977deb4782	[32808] Allow null handling in custom fields based on direction ... Due to the way the order statements are constructed, we cannot provide null handling from within `order_statements.rb`, since the direction is append behind it, and null handling in postgres needs to be behind the direction. Thus we can provide a null handling that is based on the direction only https://community.openproject.com/wp/32808	5 years ago
ulferts	0b15db3c9a	rename fixed_version to version	5 years ago
ulferts	125d51c2b8	enable SortCriteria to handle sort bys Procs	5 years ago
ulferts	4002be7c58	adapt spec expectation	5 years ago
ulferts	900711cdab	remove unnecessary order	5 years ago
ulferts	d65cd0d211	reuse sql string	5 years ago
ulferts	3ed9e45a95	semver sorting/group_by for wp table	5 years ago
ulferts	95fd58cff7	replace order_by_date with order_by_semver_name	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
Oliver Günther	fa33b8c296	[32296] Also ensure versions are sorted by name ... If versions are not sorted by date, the default work_packages.id sort will break up grouped versions if they have no date. https://community.openproject.com/wp/32296	5 years ago
Oliver Günther	1160cf972c	[32190] Switch filter requires/required for queries ... It was the wrong way around, causing required work packages to be found in the requires filter and vice versa. https://community.openproject.com/wp/32190	5 years ago
Oliver Günther	c18ae83b9e	Sort versions in roadmap in the same fashion	5 years ago
Oliver Günther	f4f1e98b20	[32156] Use backlogs sorting of versions date for work packages ... - Adds a null_handling option to the property columns to allow `NULLS FIRST/LAST` to be handled - Adds a query specific SortCriteria that can work with null_handling - Fixes sorting of allowed_versions to reuse that sort order https://community.openproject.com/wp/32156	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	8370c3099e	avoid n+1 queries on query requests by caching	5 years ago
Oliver Günther	a6a4031aa2	[31667] Fix ambiguous reference to project_id when group/sort ... Properly reference project_id to avoid ambiguous references to project_id when grouping by project_id and sorting by priority https://community.openproject.com/wp/31667	5 years ago
ulferts	aa3698d061	fix summing custom fields on wp table ... Before the fix, string values where returned and then the `+` method was called which lead to the strings being concatenated. A subsequent call of `integer?` failed. The fix performs the aggregation in the database which is not only correct then but can also be carried out considerably faster. The drawback is, that the casting breaks the abstraction introduced by the cf strategies	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	c4dc6e2c91	ensure sums are also sorted by group_by column	5 years ago
Oliver Günther	64e6fae1b8	[30442] Use formatted custom value in xls export ... This also fixes localized output of custom fields such as float https://community.openproject.com/wp/30442	5 years ago
Oliver Günther	731bbd4104	[30763] Use stable sort for manual position ... Only moved items are being sorted, to avoid sorting the entire page when that is not yet necessary. This is a design decision to ensure only the minimum number of positions are being assigned and helps when sorting a restricted set of work packages from a bigger set. To avoid having ambiguous sort results, ensure a second sort parameter by ID. https://community.openproject.com/wp/30763	5 years ago
Markus Kahl	cb6d28136d	allow editing estimated time for parents, show derived separately	5 years ago
Markus Kahl	530aa631d5	don't count children twice when summing estimated hours	5 years ago
Oliver Günther	7ac2805779	Save integer relative positions by computing spaces between	5 years ago
Wieland Lindenthal	1e3fe98640	Respect custom field attributes "is_filter" and "searchable" within the SearchFilter	5 years ago
Wieland Lindenthal	83c72b549b	Let Global search also search within custom fields of type string or text.	5 years ago