openproject

Commit Graph

Author	SHA1	Message	Date
Oliver Günther	269d91cfb9	[31583] avoid parsing strings to yaml If a configuration/ENV value has YML-incompatible contents, it is broken due to the `YAML.load` approach. However, if the outcome of `YAML.load` is a string, we can expect the input to be an actual string, not something YAML should parse. Thus as a workaround until proper configuration types are added (or better, settings and configuration is joined into one), this avoids breaking passwords in ENV configuration inputs. https://community.openproject.com/wp/31583	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
ulferts	e7263fcedb	migrate to rails 6.0.0	5 years ago
Oliver Günther	2e335b62ca	Prepare for core integration	6 years ago
胡海星	8ffe3eba85	Fix the spec failings and add some test for the patch	6 years ago
胡海星	e50a604944	Fix the spec failings and add some test for the patch	6 years ago
Jens Ulferts	8cb99466fd	isolate configuration specs	7 years ago
Oliver Günther	fa76452233	Allow :none authentication as empty smtp_authentication setting (#6210 ) We have users that need SMTP without authentication present, e.g., in an internal network. When passing :none to the smtp settings, this results in an authentication error since it tries to use that authentication method. The correct way is to remove the authentication setting in order to use none. https://stackoverflow.com/a/26093613 https://community.openproject.com/wp/27284 [ci skip]	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171 ) [ci skip]	7 years ago
Oliver Günther	fc50bb72a1	[26237] Add configuration option for default comment order (#5896 ) https://community.openproject.com/wp/26237 https://community.openproject.com/wp/25932 [ci skip]	7 years ago
Oliver Günther	342a30f7eb	Make configuration hash indifferent (#5893 ) [ci skip]	7 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	ab62a6717b	Fix empty ENV overrides to be parsed as false YAML parses '' as false, but empty ENV variables will be passed as that. To mitigate that, we first check for an explicit empty string. To specify specific values, one can use !!str (-> '') or !!null (-> nil) return value if value == ''.	8 years ago
Cyril Rohr	c387e51509	Hide email configuration in UI when using legacy configuration	9 years ago
Oliver Günther	638340e7b6	Fix rubocop issues	9 years ago
Cyril Rohr	1507bf018d	Do not clear cache in tests, since it appears it breaks other tests	9 years ago
Cyril Rohr	f27bce492a	Add tests for new methods to configure email settings	9 years ago
Oliver Günther	02b5b8dda1	Add simple YAML extraction of ENV overrides Allows users to pass arrays or hashes via `[foo,bar]` and `{ foo: bar }` notation via inline YAML syntax.	9 years ago
Jonas Heinrich	fc4b2b4676	Adds specs for configuration	9 years ago
Jens Ulferts	11b906dfd7	introducing a setting to disable cf class caching The setting is not yet used.	10 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	944b89d83e	Convert specs to RSpec 3.2.0 syntax with Transpec This conversion is done by Transpec 3.0.7 with the following command: transpec -f * 34 conversions from: it { should ... } to: it { is_expected.to ... } * 14 conversions from: obj.stub_chain(:message1, :message2) to: allow(obj).to receive_message_chain(:message1, :message2) * 7 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 4 conversions from: be_true to: be_truthy * 3 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: failure_message_for_should { } to: failure_message { } * 2 conversions from: failure_message_for_should_not { } to: failure_message_when_negated { } * 1 conversion from: Klass.any_instance.stub(:message => value) to: allow_any_instance_of(Klass).to receive_messages(:message => value) * 1 conversion from: be_false to: be_falsey * 1 conversion from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: stub('something') to: double('something') * 1 addition of: RSpec.configure { \|c\| c.infer_spec_type_from_file_location! } For more details: https://github.com/yujinakayama/transpec#supported-conversions	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 [ci skip]	10 years ago
Markus Kahl	63957c55f7	more flexible prefix	10 years ago
Markus Kahl	ea52b14756	don't hardcode ENV as source for config override	10 years ago
Markus Kahl	661d89f5fe	allow nested config env override and addition of new values	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
kgalli	3e2cdf1ca7	Add quick fix for load_config_from_file The whole test should be refactored. I suggest using a real life example of the configuration.yml instead of stubbing its content.	10 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers updates more copyright more copyright headers	11 years ago
Michael Frister	a8d0fb73ab	Fix compatibility with old mail configuration Previously, the compatibility code wrongly assumed that delivery_method was always set when using the old mail configuration format, although it has the default value :smtp.	11 years ago
Michael Frister	c24a2803bf	Make Configuration spec independent of YAML files, test env vars	11 years ago
Michael Frister	0f1a96fbe3	Add configuration spec	11 years ago

33 Commits (7fbb262e07d76201dd30cc82985a8d639a0d4baa)