98 Commits (8be10d1e806800e22689b9a12a727e6fb7458132)

Author	SHA1	Message	Date
Alex Dik	65bf87bf61	Move EditableFieldsState to inplace-edit directory	9 years ago
Jens Ulferts	7bf647281d	remove no longer used constant	9 years ago
Jens Ulferts	2726d84bf9	add author to "people" list	9 years ago
Oliver Günther	952d38ec21	Look at correct place for empty duration (PT0S)	9 years ago
Jens Ulferts	35906c1a00	remove merge remains	9 years ago
Jens Ulferts	7fcc59af2a	avoid unspecific error message	9 years ago
Oliver Günther	bd1247d376	Strip notify from frontend ... The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Alex Dik	5aeccc2d2c	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	e582c304f3	Reference field names via newly introduced field object	9 years ago
Alex Dik	bd86311e26	Refactor inplace-edit directory structure ... [ci skip]	9 years ago
Alex Dik	e92a154725	Implement cancel button for fullscreen edit ... Input values are set to their initial values when one restarts editing.	9 years ago
Alex Dik	42e27e41a3	Make user input stay when switching between views	9 years ago
Alex Dik	5c9975fd64	Implement WP-edit save button	9 years ago
Alex Dik	99348cadb7	Refactor EditableFieldsService and EditPaneController ... Move isActiveField and getPendingFormChanges to EditableFieldsState service.	9 years ago
Alex Dik	c751e0c23c	Disable WP edit buttons for users without update permissions	9 years ago
Alex Dik	40167485a9	Add work package edit actions toolbar (save & cancel) ... Saving the work package does not work as of yet.	9 years ago
Alex Dik	aa01eb1f79	Implement work package editing in fullscreen view	9 years ago
Jens Ulferts	f4b90d61f1	render a duration according to the user's locale	9 years ago
Jens Ulferts	dbfcfb49b7	Revert "Merge pull request #3646 from furinvader/16364-fullscreen-edit" ... This reverts commit cddeebbf43, reversing changes made to 44ba79e900.	9 years ago
Alex Dik	b422907206	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	13c664371b	Reference field names via newly introduced field object	9 years ago
Alex Dik	0faeeff74c	Refactor inplace-edit directory structure ... [ci skip]	9 years ago
Alex Dik	5ab24dc7a6	Implement cancel button for fullscreen edit ... Input values are set to their initial values when one restarts editing.	9 years ago
Alex Dik	92009a1dd7	Make user input stay when switching between views	9 years ago
Alex Dik	be5beca5ca	Implement WP-edit save button	9 years ago
Alex Dik	9b290d18f3	Refactor EditableFieldsService and EditPaneController ... Move isActiveField and getPendingFormChanges to EditableFieldsState service.	9 years ago
Alex Dik	7d86b2977c	Disable WP edit buttons for users without update permissions	9 years ago
Alex Dik	b9bf6d0274	Add work package edit actions toolbar (save & cancel) ... Saving the work package does not work as of yet.	9 years ago
Alex Dik	c662325ba8	Implement work package editing in fullscreen view	9 years ago
Oliver Günther	a676cc65c6	Use events to refresh a single work package ... Avoids exposing the `refreshWorkPackage` function on the root scope.	9 years ago
Alex Dik	ae6698ca2c	Undo removal of dc9ad0c and fix the condition ... This fixes an internal server error appearing when changing a work package field.	9 years ago
Alex Dik	7c49e69903	Remove faulty condition from work package field directive ... Values of some editable fields (e.g. assignee and responsible) appear correctly now.	9 years ago
Alex Dik	84e66ca050	Remove JS errors appearing in public work package detail view	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Florian Kraft	3ff36d9247	prepare the directives and load both available and watching users ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	0e3dc2c14c	initial splitoff of watchers into separate service ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	b3553b0121	remove left over console.log	9 years ago
Florian Kraft	728efb6372	check for the existance of files in a work package ... This will check for existing files first. It will also cache the initial call and force reload only on demand Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	bb3f9fdc6c	consolidate duplicate code	9 years ago
Jens Ulferts	3232a3d21b	sort version by name	9 years ago
Florian Kraft	29e5916067	show an error notification instead of prolonging the file list ... this will show files which cannot be uploaded in an error list in a notification instead of using the file list. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	acedeb9604	do not ask the api for attachments when nothing changes ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	cac48d3bae	wrap the size definition into a helper method ... the directive should not really care about whether an attachment is kB or MB in size. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f410d43500	add a download link for attachments ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	55466d97a0	show file uploads in kilobytes ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago