65 Commits (8c8b8bbfa75858b6e8b21776baf690a72f207f65)

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
Oliver Günther	2cde433326	Remove usages of AnyFixture (#8987) ... AnyFixture will create once instance of a factory for reuse in a number of specs. This will work fine until we require a clean slate for a specific example. As we have numerous tests that test like the database is empty, we get a number of disadvantages: - After an example with `with_clean_fixture` metadata, the fixture will only be regenerated after the next example that uses it. This means the order of execution will change the number of objects in the DB. - The more `with_clean_fixture` we have, the smaller the performance advantage of AnyFixture will result in. - You cannot use an AnyFixture in a spec that needs a clean slate. This should be obvious but was overlooked by myself.	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	9f6ea0812c	use acts_as_url for new wiki page (#8878)	4 years ago
Oliver Günther	7015ce441f	[33302] Redirect user to TOC if new wiki page is not editable ... https://community.openproject.com/wp/33302	4 years ago
Oliver Günther	53f2d694ff	Use AnyFixtures to generate fixtures from factories (#7230) ... Uses FactoryBot to keep and maintain specific records in a special transaction that does not get removed after each spec. They automatically are created whenever first hitting them. This makes an excellent time saver for items that are commonly used, such as an admin user account	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
Oliver Günther	693bd7760a	Replace deprecated `update_attribute` with `update` ... `update_attributes` was deprecated in Rails 6	5 years ago
Oliver Günther	4c147f0af4	[24167] Set back reference wiki id for setting parent from links ... https://community.openproject.com/wp/24167	5 years ago
Oliver Günther	183ad1480e	Replace deprecated controller success? with succesful?	6 years ago
Oliver Günther	eac3b7db3b	Fix toolbar in wiki index/toc page ... https://community.openproject.com/wp/28307	6 years ago
Wieland Lindenthal	2acb314363	fixing pretty uncomprehensive specs	6 years ago
Jens Ulferts	97ad5e0008	reenable previews	6 years ago
Wieland Lindenthal	abee0edfa5	fix wiki_controller_spec.rb	7 years ago
Oliver Günther	059770f533	FactoryGirl => FactoryBot ... Removes the deprecation	7 years ago
Oliver Günther	6ef4211e77	Bump copyright to 2018 (#6171) ... [ci skip]	7 years ago
Oliver Günther	a799de0157	Remove invalid wiki menu children nodes if the slug already exists ... They will be unable to be selected and/or removed by hand anyway, so we should just delete them.	8 years ago
Oliver Günther	7cf11bb689	Update copyright notice	8 years ago
Oliver Günther	92aebdcec4	Fix params deprecation ... Fixes in spec/controllers: ``` DEPRECATION WARNING: ActionController::TestCase HTTP request methods will accept only keyword arguments in future Rails versions. ```	8 years ago
Oliver Günther	8593ad1c24	Replace deprected matcher implementation	8 years ago
Oliver Günther	6a91e4a32a	Fix wiki controller item specs	8 years ago
Henriette Dinger	5c8056cbee	Fix broken tests	8 years ago
Oliver Günther	65c3ebaa2d	Fix specs	8 years ago
Oliver Günther	556f5072f0	Fix specs	8 years ago
Oliver Günther	bb53e2bf0d	Fix Wiki const lookup	9 years ago
RobinWagner	547a0b5da8	Change button text wiki ... Change button text for wiki create button.	9 years ago
Henriette Dinger	b14e9c8f12	Rename button, adapt styling on small screens and fix some specs	9 years ago
Henriette Dinger	ef8a0a5c5f	Fix broken specs	9 years ago
Oliver Günther	3c89e99ed0	Fix tests	9 years ago
Jens Ulferts	2538eddce7	consolitate wiki paths	9 years ago
Jens Ulferts	606232d81f	remove no longer necessary constraint on the wiki page title	9 years ago
Mohamed Wael Khobalatte	626779d92d	Use assert_select instead of deprecated assert_tag	9 years ago
Alex Coles	ce93701029	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Florian Kraft	1a2ea133f2	fix tests for wiki and permitted params	10 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	a73e71cde5	Amend MenuItem to append -menu-item class suffix ... Keep CSS class names more tightly scoped. Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5afc11f19e	Fix syntax (w/Rubocop) in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	03978767be	Use 1.9+ Hash syntax in specs ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	e137ed8135	Convert specs to RSpec 2.99.0 syntax with Transpec ... This conversion is done by Transpec 2.3.1 with the following command: transpec * 72 conversions from: describe 'some controller' { } to: describe 'some controller', :type => :controller { } * 57 conversions from: describe 'some model' { } to: describe 'some model', :type => :model { } * 49 conversions from: describe 'some view' { } to: describe 'some view', :type => :view { } * 34 conversions from: obj.should to: expect(obj).to * 27 conversions from: describe 'some routing' { } to: describe 'some routing', :type => :routing { } * 8 conversions from: describe 'some feature' { } to: describe 'some feature', :type => :feature { } * 7 conversions from: describe 'some helper' { } to: describe 'some helper', :type => :helper { } * 5 conversions from: be_true to: be_truthy * 5 conversions from: describe 'some request' { } to: describe 'some request', :type => :request { } * 2 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 2 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 1 conversion from: before { example } to: before { |example| example } * 1 conversion from: describe 'some mailer' { } to: describe 'some mailer', :type => :mailer { } For more details: https://github.com/yujinakayama/transpec#supported-conversions	11 years ago
Hagen Schink	40847c0a6e	Add preview object authorization specs	11 years ago
Hagen Schink	b986fce447	Add specs	11 years ago
Alex Coles	0bdbdcac35	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec * 1414 conversions from: obj.should to: expect(obj).to * 646 conversions from: == expected to: eq(expected) * 376 conversions from: obj.stub(:message) to: allow(obj).to receive(:message) * 107 conversions from: obj.should_not to: expect(obj).not_to * 70 conversions from: obj.should_receive(:message) to: expect(obj).to receive(:message) * 45 conversions from: =~ [1, 2] to: match_array([1, 2]) * 27 conversions from: lambda { }.should to: expect { }.to * 13 conversions from: Klass.any_instance.stub(:message) to: allow_any_instance_of(Klass).to receive(:message) * 8 conversions from: === expected to: be === expected * 7 conversions from: expect { }.not_to raise_error(SpecificErrorClass) to: expect { }.not_to raise_error * 6 conversions from: =~ /pattern/ to: match(/pattern/) * 2 conversions from: obj.should_not_receive(:message) to: expect(obj).not_to receive(:message) * 1 conversion from: < expected to: be < expected * 1 conversion from: obj.stub!(:message) to: allow(obj).to receive(:message) * 1 conversion from: stub('something') to: double('something')	11 years ago
Hagen Schink	0ee278c484	Add preview object authorization specs	11 years ago
Hagen Schink	8fabfe76a8	Add specs	11 years ago
Johannes Wollert	8b096975fe	updates copyright headers ... updates more copyright more copyright headers	11 years ago
Hagen Schink	f2d7c1408a	Fixes specs	11 years ago
Till Breuer	4dcc97d544	Add menu items generalized from wiki menu items	11 years ago