172 Commits (8df966abff127ec6980244d892403798294971ee)

Author	SHA1	Message	Date
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994)	4 years ago
luz paz	3683042c9b	Fix typos in user facing and non-user facing code ... Found via `codespell v2.1.dev0`	4 years ago
ulferts	2744673ec8	avoid updating the lock version on finishing an attachment upload (#8934) ... If the lock version is increased, it might happen while the user is still editing the description. The user might have added an image to the description and continues typing. In the backend, the FinishDirectUploadJob is run before the user presses the checkmark to send the updated description. In that case, a 409 conflict would be signaled if the lock version were to be updated in the meantime.	4 years ago
ulferts	38cae188ad	Fix/journals on direct uploads (#8933) ... * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file * correct journalizing on direct upload In case the container of an attachment is journalized, the container needs to have added a journal to it when an attachment is uploaded. Without that, the attachment is only picked up in the journals once the container is altered again (possibly by a different user). This will then lead to a history which does not reflect the actual upload.	4 years ago
ulferts	4ad9ebc6ee	Fix/filename on direct upload (#8928) ... * linting * use Carrierwave's replacement for filename This avoids having the name altered by Carrierwave later on in the Attachments::FinishDirectUploadJob job where the file is fetched and then the attachment is stored. * separate cases for no attachment and no local file	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925) ... Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
Oliver Günther	0740070bca	By default, do not log arguments to background jobs	4 years ago
ulferts	9df4ede3cc	adapt interface of mailer #perform to adhere to rails 6.2	4 years ago
Wieland Lindenthal	fd2b2a3f2a	Feature: Optimize memory for pdf exports with attachments (#8861) ... * Change design of WP list PDF export to batches In order to keep memory consumption low when exporting WP as list in PDF, we split the work in batches of 100 work packages. In every batch we resize the attached photos and create a PDF. When all batches have been processed, we merge the PDF files via the command line tool `pdfunite` which fortunately comes with a package that we already require for text extraction. Only at the end, when the merged PDF is ready (and small) we load it into the ruby process to return the PDF's content with service's success. In every batch, we make sure that we remove all minimized images afterwards. And after merging the batch PDF files to the final PDF we also delete all batch PDFs. * Don't load the merged PDF file into the ruby process * Rename tempfile to final file name before storing. * Improve code structure.	4 years ago
ulferts	ae2edad19b	Fix/copy project wiki notifications (#8777) ... * rename to convey applicability to all journal notifications * adapt journal completed job to handle wiki content * remove empty module * create wiki_content mail service * introduce copy/create service and contract for wiki pages * specify set attributes and create contract for wiki pages * copy the content attributes * use wiki page create service when copying wiki * introduce specifc service for copying wiki pages The contract disables checks for permissions on the wiki page. The copy_projects permission should suffice to copy everthing in a project * copy wiki pages top down to rewrite hierarchy * limit copied attachments to copied type	4 years ago
Oliver Günther	b7f93b96cf	Better error handling if project copy dependencies fails ... The project copying can succeed but with errors of some dependencies, this commit modifies the modal to show these errors instead of automatically redirecting.	4 years ago
Oliver Günther	e1a88a9a40	[34001] Ensure filters always receive the query context ... In the mentioned project, the query copy service fails to execute because a filter has lost its context right after `query.save`. There is a hook for `after_commit` which is not relevant here since we're in a transaction, but the context is lost regardless. Instead, we could ensure whenever accessing the filters, the context is set correctly. https://community.openproject.com/wp/34001	4 years ago
Markus Kahl	c1b82bad00	direct uploads to S3 for attachments including IFC models ... Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
Oliver Günther	605f6b8355	Refactor copy project into service	4 years ago
Oliver Günther	45fc54b7e0	Allow jobs to define a title for the job status modal	4 years ago
Oliver Günther	88cb21a594	Fix export spec	4 years ago
Oliver Günther	27268568f8	Set retry_on options for some jobs	4 years ago
Oliver Günther	d0c0fdd871	Correctly upsert statuses in all cases ... In case of tests, jobs never are running through the 'queued' step. This causes jobs to be missing in later updates. To avoid this, ensure that we just use upsert, which is faster anyway.	4 years ago
Oliver Günther	373b673f1a	Replace export modal with job status modal	4 years ago
Oliver Günther	58562e7379	Let CopyProjectJob redirect to the target project	4 years ago
Oliver Günther	f7d4439f65	Rewrite status as module	4 years ago
Oliver Günther	b8bc50bb8d	Make copy project job store a status	4 years ago
Oliver Günther	2df57ceebd	Refactor statused jobs to test whether job is statused	4 years ago
Oliver Günther	57beed0316	Add some debugging information to the notifications	4 years ago
Oliver Günther	ba6465f106	Listen to the notifications in a separate listener class	4 years ago
Oliver Günther	7612e34964	Allow jobs to define to store status even without a reference	4 years ago
Oliver Günther	0ca1865dd9	Add reference to user in status, extend enum, and add payload ... - Adds the user reference directly to a job status, this avoids having a separate object for many cases - Adds a payload object to the status to transport information - Extends the enum with a type when the job was cancelled	4 years ago
Oliver Günther	6c6a05c784	Ensure we set templated to false when copying	4 years ago
Oliver Günther	c94c1951b9	[33413] Use around hook to reload config in jobs ... https://community.openproject.com/wp/33413	5 years ago
ulferts	983709db89	rewrite acts as journalized to create journals in sql	5 years ago
ulferts	1e6c1e7d72	introduce a presisted status for delayed jobs (#8299) ... This is currently only employed for work package export jobs but is intended to be used more broadly, e.g. to signal the status of copying a project. [ci skip]	5 years ago
Oliver Günther	f10e5bcafc	[33111] Always assign query_props to change persisted queries ... In case of a persisted query, the export job only received that query without any (unsaved) query_props, resulting in changes to it never being applied. Since a saved query is only passed for manual sorting, the problem only occurs there. https://community.openproject.com/wp/33111	5 years ago
ulferts	4cb0d0ff91	Feature/delayed bcf export (#8275) ... * delayed bcf export * remove unnecessary eager loading * Update rxjs polling statement with loading indicator * Avoid error handling due to JSON parsing * delay all wp list exports Co-authored-by: Oliver Günther <mail@oliverguenther.de> [ci skip]	5 years ago
Oliver Günther	6ded4e6852	Add cron job functionality to delayed_job	5 years ago
ulferts	9e2287bfcc	rename and inflect according to zeitwerk	5 years ago
ulferts	201b6f4898	remove unnecessary begin/resuce blocks	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
Yegor Tovstik	b503f579e0	PR fixes	5 years ago
Yegor Tovstik	bb4a7bdfb4	CI fixes	5 years ago
Yegor Tovstik	ee2762e8ef	Send email on watcher being removed	5 years ago
ulferts	3dabb46dd9	allow copying projects without parent project reference	5 years ago
Oliver Günther	7a09d8fcdd	delay all jobs	5 years ago
ulferts	67e3a7a15a	let mail sending rely on notifications ... That way, the two are no longer intermingled and we can build on the notifications in other use cases like it is already done for the webhooks	5 years ago
ulferts	e86d757cb5	limit notification disabling to mail only	5 years ago
ulferts	d37bdb71f0	extract methods	5 years ago
ulferts	f6226524dd	extract shared code into module	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Oliver Günther	3aa3dea512	Allow `deliver_later` using a custom ApplicationJob ... We're getting more and more reports on synchronous Timeouts and SMTP errors causing internal errors for users when trying to send mail in the request of the browser. With rails 5.2, we can assign a custom job that handles the `deliver_later` delayed sending. We can hook this into the ApplicationJob with delayed_job. Since rails now also has GlobalID serialization of ActiveRecord, we don't even need to do the serialization ourselves!	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch ... This reverts commit b05a8f7b54. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
ulferts	05ac3af1ee	add projects delete end point to api	5 years ago