openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	87eac68ce3	attempt to stabilize flickering spec	5 years ago
ulferts	aa3698d061	fix summing custom fields on wp table Before the fix, string values where returned and then the `+` method was called which lead to the strings being concatenated. A subsequent call of `integer?` failed. The fix performs the aggregation in the database which is not only correct then but can also be carried out considerably faster. The drawback is, that the casting breaks the abstraction introduced by the cf strategies	5 years ago
Oliver Günther	1c6ed3671a	[30920] Fix links in task lists They were broken due to the way todo list labels and inputs are nested differently when links are present: CKEditor converts todo lists differently when they contain a link <ul class="todo-list"> <li> <label class="todo-list__label"> <input type="checkbox" disabled="disabled" checked="checked"> <span class="todo-list__label__description">4 teaspoons baking powder </span> </label> </li> <li> <a href="https://example.com"> <label class="todo-list__label"><input type="checkbox" disabled="disabled"> <span class="todo-list__label__description">1/4 teaspoon salt </span> </label> </a> </li> </ul> which is why we need to override the list item rule for turndown to address this and replace the todo list on our own. https://github.com/opf/commonmark-ckeditor-build/pull/45 https://community.openproject.com/wp/30920	5 years ago
ulferts	0c5aeb4cdf	remove outdated styles	5 years ago
Oliver Günther	a7ed2e9da0	Rewrite jobs to use ActiveJob syntax	5 years ago
Oliver Günther	02a15be3f0	Fix drag & drop after subcomponent was introduced	5 years ago
Henriette Dinger	2a14443840	Adapt test to new placeholder	5 years ago
Henriette Dinger	751caed2e0	Attempt to stabilise description_editor_spec.rb	5 years ago
Henriette Dinger	6f92035ccc	Rename EditField classes used for tests and remove WorkPackage reference	5 years ago
Henriette Dinger	f47a75d153	[31023] Preparation for project edit fields: Generalize edit and display fields currently work package specific (#7726 ) * Check edit fields for Work package dependencies * Make EditForm, NotificationService, EditContext indepenedent of Work Packages * Make EventsService independent of WorkPackages * Start renaming WpNotificationService (WiP) * Fix more references * Fix typescript errors * Add basic halEditingService * Rename to global halResourceEditingService (WiP) * Move typing from class to methods (WiP) * Fix typescript errors * Remove space in type * Add test project widget && generalize the editFieldGroup * Rename editing portal service [ci skip] * Rename WpEditFieldComponent * Rename WpDisplayFields * Rename display-XX-field to XX-display-field [ci skip] * Add WP specific ID field to distinguish between resources * Re-add state in work package resource * Generalize display field renderer * Rename spent-time to wp-spent-time and fix highlight specifics [ci skip] * Actually load the project schema and make field editable * Make edit-field-group.component an edit-form.component and subclass EditForm * Remove edit context in favor of specialized EditForm * Add special cases for work package editing * Fix edit actions bar * Fix codeclimate issues * Use WorkPackageNotificationService if necessary * Override NotificationService for WPs to allow WP specififc notifications (WiP) * Correctly provide wpNotification service Because the ui-router doesn't seem to correctly use the parent element's injector, we need to provide the wpNotification service not in the wp-base, but rather the wp-list component as well as in the isolated query space. * Allow to filter halEvents for specific resourceTypes (e.g. WorkPackage) * Remove superfluous cell class constant * Start renaming selectors for wp-edit-field into generics * Remove wp-table--cell-span in favor of display field selector * Consolidate other display and edit field styles * Provide specialized service for transitions in active edit forms * Remove superfluous overflowSelector * Accept that date field contains some work package specifics * Ignore unreadable files * Provide the changeset for work packages as a hook Since hal resource editing service is provided per query space, we cannot register them once (would only work globally) * Fix dangerfile * Remove another todo in halResourceNotification service * Fix npm TestBed for changed dependencies * Show inplace edit field in project details widget * Fix highlighting in single view * Provide HalResourceEditingService outside of project context * Used typedState for single-view * Also provide wpNotification service in split view * Correct check for resource type in eventsService * Fix getSchemaName in display field renderer * Fix passing ids into `halEditing.stopEditing` * Do not globally inject the halResourceEditingService There's a bug(?) in ui-router that gives you the global service before the parent injected service for a ui-view * Fix wpCreate service on copying and parallel creation * Remove test project widget * Revert changes for project details widget	5 years ago
ulferts	ce50beb2f9	attempt to fix flickering spec	5 years ago
ulferts	57131fa32b	continue adapting to altered project properties	5 years ago
ulferts	4e5b9afef5	rename project attributes	5 years ago
Oliver Günther	dc21d85285	[31148] Correctly refresh attachments in attachment-list The attachment resource is updated, but the attachment-list never is notified about that change. https://community.openproject.com/wp/31148	5 years ago
ulferts	c83ba63640	Revert revert unwanted in dev branch This reverts commit `b05a8f7b54`. The release/10 branch received a revert that was applied after changes from dev unwillingly where merged into it. But when merging release/10.0 back into dev, that revert was also applied to dev where the changes are indeed wanted. So we revert the revert for dev.	5 years ago
ulferts	f98c935373	show pagination range on manual sort Per page options are still hidden as the user will not be able to alter the per page options. Also removes the forcePerPageOption introduced in #c2115bbc43/#3b30a7838f when wp tables where auto calculating how many wps to display given the available height. As this is no longer necessary (#4ac48a88ae) so isn't the option.	5 years ago
Oliver Günther	02f9e5cf92	[31095] Fix double saving query title due to blur The blur event causes another save that is only caught for new queries https://community.openproject.com/wp/31095	5 years ago
Oliver Günther	3ab46b65d7	[31093] Save query after switching to manual sort Only works for a persisted query however as detailed in the ticket https://community.openproject.com/wp/31093	5 years ago
Oliver Günther	b05a8f7b54	Revert "[31080] Trigger wpEvent after custom action"	5 years ago
Oliver Günther	fad88c5886	[31078] Correct order when inserting new element to end of table https://community.openproject.com/wp/31078	5 years ago
Oliver Günther	693bd7760a	Replace deprecated `update_attribute` with `update` `update_attributes` was deprecated in Rails 6	5 years ago
ulferts	a3317eb748	bump capybara	5 years ago
Oliver Günther	5a9c08036d	[30994] Update empty changesets to match the latest resource If a work package changeset is openend, and then some other action happens that does not run through a changeset (updating a parent id e.g.,), the old changeset will still be present and returned by the editing service. This results in getting an older lockVersion for the edit, even though the work package is up to date. https://community.openproject.com/wp/30994	5 years ago
Oliver Günther	59bc26a7d4	Fix broken tests due to chromedriver update	5 years ago
Oliver Günther	6dad71fb49	Fix custom action current-date https://community.openproject.com/wp/30949	5 years ago
Oliver Günther	8fe8dc6491	[30941] Use same icon for drag & drop https://community.openproject.com/wp/30941	5 years ago
Oliver Günther	40f18aec52	Fix navigation spec for bim	5 years ago
Oliver Günther	e0f5dee13d	Show an error when WP cannot be loaded	5 years ago
Oliver Günther	3ae39f8bb4	[30928] Fix clicking on WP links since hover card visible The click with an open hover card prevents the default action of the link, preventing the click to result in page changing.	5 years ago
Oliver Günther	39ca58368a	[30921] Correctly update view button https://community.openproject.com/wp/30921	5 years ago
ulferts	e97883cdd8	attempt to fix flickering activty spec by less ambivalent input	5 years ago
Oliver Günther	85398d71df	Change selector to not fail on first attempt Since we insert the tasklist, angular seems to have a temporary pass that is brekaing these specs. However, the failing screenshots always show the correct comment so I suspect it's a timing issue. This PR changes the expectation to run in a retry_block without retrying the entire spec	5 years ago
ulferts	f46c58faf9	use the wp payload instead of the resource That way, local changes will not be ported over between states except when the user has explicitly made them. E.g. changes by the user to the subject should be ported over, but changes to the description, caused by a default description, should not	5 years ago
Oliver Günther	872fba5892	Fix styling of task lists	5 years ago
Oliver Günther	f72a4f074f	Provide tasklists with ckeditor-list and tasklist filter	5 years ago
Oliver Günther	0450b192ae	Don't show indentation option for cards	5 years ago
Oliver Günther	580e9a27ad	[30786] Indent and outdent work package hierarchies in context menu https://community.openproject.com/wp/30786	5 years ago
ulferts	08391c7807	replace my_project_page by grid implementation	5 years ago
Oliver Günther	ec43dc2f29	[30762] Fix missing drag-and-drop icon after refreshing https://community.openproject.com/wp/30762	5 years ago
Oliver Günther	8391ca60e0	[30832] Don't clear stale states when updating parents This might result in timing issues where a parent work package is no longer cached despite the table relying on it being cached due to being rendered. The stale work package is safe to keep in cache until loaded. https://community.openproject.com/wp/30832	5 years ago
Henriette Dinger	c813d18294	Adapt tests to removed "click"-confirmation for relations	5 years ago
Oliver Günther	0ddc079cf7	[30777] Replace most usages of refresh service with global eventing service We are increasingly having one problem: Notifying a parent querySpace of changes within another embedded query space (e.g., a nested embedded children table adding new relations, which should re-render the table). As the `WorkPackageTableRefreshService` is rightfully part of the query space, it cannot be used for these notifications. This PR suggests to add a global `WorkPackageEventService` which is called for specific events that can be registered to and events can be received in buffered mode with a debounce. From these events, the table is then refreshed if a visible work package is present in the table. https://community.openproject.com/wp/30777	5 years ago
Henriette Dinger	f850aca7b8	Merge release/9.1 into dev	5 years ago
Oliver Günther	e9d707023f	[30757] Blur editable title after save Ensures field is no longer focused after saving https://community.openproject.com/wp/30757 [ci skip]	5 years ago
Oliver Günther	c5a745141c	[30675] Don't reload table when switching between layouts All information is present so we don't need to reload the results. Also, ensure we re-use the manual sort order if it was overridden https://community.openproject.com/wp/30675	5 years ago
Oliver Günther	dd618d4568	[30761] Fix changed table.container no longer containing timeline The scroll container was changed for the table likely due to drag & drop. This means that `table.container` no longer includes the timline which breaks some event scopes such as `contextmenu`. A new clearer container was added that contains both https://community.openproject.com/wp/30761	5 years ago
Henriette Dinger	72ced01427	Rename "move" to "change project"	5 years ago
Oliver Günther	d30f8a5e3e	[30734] Wait for results and schemas to be present to show status button https://community.openproject.com/wp/30734	5 years ago
Henriette Dinger	d8aa2470e4	Merge branch 'release/9.1' into dev	5 years ago
Henriette Dinger	b9d30749f0	Fix bulk action tests && add test for switch to split/full screen from the card view	5 years ago

1 2 3 4 5 ...

903 Commits (8e5e4c1433f2e687fcf5d92964ff93c7d288ec89)