306 Commits (90cd8b2f2494d4e8bf2f575db23acbad1ebdde72)

Author	SHA1	Message	Date
Tim Habermaas	88f8bf7f70	Remove link to new work package from sidebar menu.	9 years ago
Jan Sandbrink	79e72e7556	Increase default lock timeout	9 years ago
Jan Sandbrink	067f903008	Resolve stackoverflow ... new_connection -> our patch -> determine adapter type -> ActiveRecord::Base.connection -> new_connection	9 years ago
Jan Sandbrink	fb33d8368e	Enforce default isolation level of READ COMMITTED ... This sets the session (== ActiveRecord connection) wide default transaction isolation level. Specific reason: For advisory based locking over journals in MySQL to work correctly, we need to ensure that the SELECT that determines the maximum version reads from the most recent committed data. However, by default MySQL would use REPEATABLE READ, which snapshots the database at the first SELECT of a transaction. Generic reason: Until now we did not expect any specific isolation level, this might be bad as MySQL and PostgreSQL already use different defaults. It is also possible to reconfigure a DBMS for a different default, so we would either need to require our customers to configure a specified isolation level OR we set one for our own sessions... Now we know for sure that our transactions are using READ COMMITTED unless specified otherwise on the transaction.	9 years ago
Jan Sandbrink	9d68773b05	Use an advisory lock that is released on COMMIT/ROLLBACK ... for MySQL this seems to be the only available workaround that is not destroying running transactions. Note that TransactionalLock is a self-developed gem, that will emulate PostgreSQL style advisory locks, that are automatically released at transaction end.	9 years ago
Markus Kahl	42506dacf6	moved invitation email sub to initializer	9 years ago
Markus Kahl	505a83d52c	added :view_members permission	9 years ago
Markus Kahl	2f5018c1d0	extract members tab; invite members via email	9 years ago
Oliver Günther	91aa16b1f8	Consistency in homescreen / menu labels ... Provides consistency in labels: * types -> work package types * go to my page -> my page * manage groups -> groups * advanced settings -> settings	9 years ago
Oliver Günther	fecd3b3b3e	Simple API for managing the homescreen content ... This commit alleviates the homescreen management from both core and plugins, in order to simply add and remove blocks. Also contains refactoring from review * Consistent block and variable usage * Removed unused labels * Avoid word breaks in multiline enumerations and remove margin from enumerations	9 years ago
Jan Sandbrink	4ee163393f	Rearrange mail delivery responsibilities ... - each delivery job delivers only a single mail (like in the past) - a common super-class ensures correct handling of different error conditions (similar to the past) This new structure should allow for an efficient error handling: - fail the mail delivery on a per-recipient basis (i.e. redeliveries on error only affect the user that did not receive a mail) - only fail the delayed job for delivery errors (e.g. network issues, etc) - do not fail the delayed job for rendering errors (which are likely to re-occur on each rendering) -> only log those	9 years ago
Stefan Botzenhart	394c0d08a3	Authorize custom fields controller method	9 years ago
Alexander Bach	4105a920b5	Style watcher notification mail	9 years ago
Alexander Bach	c22c41b7db	Directly notify new watchers by mail	9 years ago
Oliver Günther	a71ce6f1a5	Refactor SCM config to lowercase / symbols ... ENV-based configuration for various configs can only provide case-insensitive values for SCM configuration and thus is unable to properly configure, e.g., managed repositories. This refactoring relies on lowercase configuration and symbols to define SCM vendors, and camelizes them to the old notation (e.g., :git => 'Git') when using `Setting.enabled_scms` to remain compatible with previous installations.	9 years ago
Alexander Bach	a6d32390d2	Adjust naming	9 years ago
Martin Linkhorst	2566c74800	document that we defer loading of airbrake	9 years ago
Martin Linkhorst	238ab55bbb	require airbrake when needed only	9 years ago
Alexander Bach	c771325d0b	Improve class naming	9 years ago
Alexander Bach	66b3978280	Move listener registration	9 years ago
Oliver Günther	1e8c873544	Remove filesystem adapter ... This commit removes the entire FileSystem repository and adapter. It rids all specs (core and legacy) of remaining uses of this adpater and replaces it with a temporary subversion repository, where necessary. We also need to remove remaining filesystem instances from the database, otherwise users will receive errors when accessing said repositories on the Frontend. This does not destroy any data on filesystem, but database information on the repositories (remarks) are lost.	9 years ago
Oliver Günther	da27a552a1	Frontend extensions and build refactoring ... - switched to toggleable-attribute-groups to provide means for adding buttons in the attribute header (e.g., delete button). - added separate destroy_info page with different notifications for managed and linked repositories to ensure ramifications of removing physical repositories are communicated to the user. - Fixed several issues regarding scm_type selection and the building of repositories. Open questions still concern the question of acessing unsupported repositories (e.g., the soon-to-be-removed filesystem adapter). Acessing the class should will then throw an error, but we still have to allow users to remove the affected repository (somehow).	9 years ago
Oliver Günther	05b27c1b98	Asynchronous creation, deletion of repositories from OP. ... This PR begins the push towards management of repository lifetime from within OpenProject. What this currently provides is the following: - A mixin `ManageableRepository`, included by `Repository::{Git, Subversion}` to provide an interface to repo management - Two services and delayed_job workers for creating (`CreateManagedRepositoryService`) and deleting (`DeleteRepositoryService`) - Customized rendering of subforms in the repository settings for arbitrary SCM vendors. TODOS: - [x] Provide sane ground to work on ( cf. PR #3149 ) - [x] Rework SCM settings form (`{scm}_tags` is currently HTML generated from within a Helper.) - [x] Ease integration of arbitrary SCM vendors - [x] Display meaningful error / warning when user looks at bare repository (currently outputs 500, as Git HEAD / svn revision is not available) - [x] I18n - [ ] Specs (in progress) - [x] Fix legacy specs - [ ] Decide what to do with `Filesystem` adapter. Open Questions: - **Configuration**: Currently replaces the existing options in `configuration.yml`. - **Implementation specifics**: - Sub-projects repositories reside in a hierarchy below their parents - How should the delayed_job react upon failure? (esp. creation of repositories) Relevant work package: https://community.openproject.org/work_packages/20416 Merge dependent on PR #3149	9 years ago
Oliver Günther	7ebac37c14	Repository Management - Refactoring and Preparation ... Related work package: [#20415](https://community.openproject.org/work_packages/20415). This is a combined refactoring and extraction effort of local SCM functionality for SVM, Git adapters in preparation for the explicit lifetime management of repositories in #20416 and implementation of (local) repository storage quota in #18393. This PR is still heavily WIP and for the time being, depends on the **legacy specs** for testing. To run the tests, execute the following steps: ~~~ rake test:scm:setup:all rake spec:legacy ~~~ I'm open for ideas on how we integrate scm adapters tests into current specs. --- - [x] Exchange `IO::Open` for `Open3` to avoid countless manual exitcode checks - [x] Extract local functionality in its own Module - [] Extend `LocalClient` module with links to create/delete services for #20415 - [x] Break down unbearable local parse routines (Hound will be over the place until fixed - but down from 260 to < 20) - [x] `entries` - [x] `revisions` - [] local repository factory - [] Specs - [] Fix / Modernize - [] More adapter-related specs	9 years ago
Oliver Günther	165e56c7ed	Hide the module menu when user is anonymous and login is required. ... The public permission of `:view_news` causes the Module menu to always render when the user is anonymous, even when the Setting `login_required` is enabled. This workaround hides the module menu in this specific case. Relevant work package: https://community.openproject.org/work_packages/20935	9 years ago
Alexander Bach	ee14628c09	Move send_notification to event origin	9 years ago
Jan Sandbrink	fb2efa5909	be more concise!	9 years ago
Alex Coles	ec09ce1485	Add, configure FriendlyId for permalinks	9 years ago
Jan Sandbrink	88e052a53e	style ... [ci skip]	9 years ago
Jan Sandbrink	b374ebdd7f	store messages alongside error symbols ... - allows to skip translation part in ErrorBase - allows to have correct translations containing placeholder values	9 years ago
Jan Sandbrink	a9d28d3fb6	fix some errors uncovered by specs ... - bad default values - missing attribute sanitation - style	9 years ago
Jan Sandbrink	6c9bd3c63f	apply a hack to fix an error	9 years ago
Jan Sandbrink	dcd2a3b03c	rework error instantiation ... - multiple errors are no longer a special case of specific errors - there is a separate error class to represent multiple API errors - convert ActiveRecord errors to API errors in a single place, ideally work with API errors from there on	9 years ago
Jan Sandbrink	c7207f0330	resort errors in WP contracts ... - use attributes as keys and error messages as value - AM errors immediately turn message symbols into translated strings, this makes them hardly processable -> patch some helper methods onto AM::Errors and everything is fine forever	9 years ago
Alex Coles	1bf90d2ff1	Revert "Add patch to fix Rails' hash types with Ruby 2.1.1" ... Rails 4.0.x `Hash` subclasses have been patched to deal with this behaviour change: https://github.com/rails/rails/pull/14198/ This reverts commit 8d6ae91d8b. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Alex Coles	fea5478893	Remove unloadable from initializers ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Markus Kahl	6fa07f060f	fixed default realm	10 years ago
Markus Kahl	a770bf762c	follow warden default, which is true for store	10 years ago
Markus Kahl	3865ce4f1f	polish	10 years ago
Markus Kahl	bcd981df5c	consider X-Authentication-Scheme; opt scoped realm	10 years ago
Oliver Günther	e0af219a36	Fix invalid time sheet link ... This adds specs for top menu items	10 years ago
Alex Coles	c030b08cb2	Fix syntax (w/Rubocop) in Rails routes, config ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	57618b25ec	Replace dynamic finder usages with #find_by, etc. ... This patch replaces all dynamic finders, for the sake of consistency, although only some methods are deprecated. See: https://github.com/rails/activerecord-deprecated_finders#active-record-deprecated-finders * Revert some `User#find_by_login` usages in cuke steps accidentally removed in 74228b59. User Story # 20325 Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Jens Ulferts	01f62ce9d6	open help in new tab ... Please note that the implementation of what to do on target='_blank' is browser specific but they should open up a new tab. Alternatively they can open up a new window. The specification can be found here: http://www.w3.org/html/wg/drafts/html/master/browsers.html#browsing-context-names	10 years ago
Oliver Günther	99098c375c	Fix for module items pointing to wrong routes in some cases ... The global routes defined in Module menu items are being overridden to their project counterparts in some cases. Related work package: https://community.openproject.org/work_packages/20613	10 years ago
Jan Sandbrink	430c7f7f46	remove redundant localization ... [ci skip]	10 years ago
Jan Sandbrink	36468cf8c4	add item to reach time entries to project menu	10 years ago
Oliver Günther	af181577f3	Allow overriding the html title for accessible help	10 years ago
Oliver Günther	5ada719136	Consolidate Module menu in header navigation This effectively changes the following menus: ... **Top Menu** - Removed Administration item - Added Item 'Work Packages' -> /work_packages - Added Item 'News' -> /news - Added Item 'Time Sheet' -> /time_entries (if user has a project with view time log permission) **My Menu** - Added Administration item as first position With work packages, time entries, news now residing in the top menu, these buttons are superfluous in the projects overview and are also removed. Relevant work package: https://community.openproject.org/work_packages/20512	10 years ago
Oliver Günther	60a2bd6a0f	Reduce space needed by search and help top menu item ... This commit changes two top menu items: 1. Search is by default collapsed to its magnifier icon - Upon clicking it, it is expanded and focus given to the search field - Clicking any hierarchy not in below the wrapper, the search is collapsed again 2. The help button remains as a '?' icon, and loses the caption. Relevant work package: https://community.openproject.org/work_packages/20540	10 years ago