3 Commits (9aaa33e050d87c5fa27300f98c764c533b805816)

Author	SHA1	Message	Date
Oliver Günther	8b9212bf73	Use op-auto-complete in comment field and add test	9 years ago
Jens Ulferts	17c56e6163	harmonize inplace edit comment fields	9 years ago
Alex Dik	bee33965ad	Reorganise directory structure of work-packages components	9 years ago
Alex Dik	b49e851fac	Remove forcedEditState flag	9 years ago
Oliver Günther	743b9b8971	Correct WP comment save and cancel titles	9 years ago
Oliver Günther	03117cc2fe	Add labels to inplace containers, rather than spans.	9 years ago
Alex Dik	126e1b7964	Move notifications to multi storage service	9 years ago
Alex Dik	1fa4b39d12	Implement multi storage service ... For saving multiple inplace forms at once in a certain order.	9 years ago
Alex Dik	f1c9af9d2e	Implement add comment method in inplaceEditStorage service	9 years ago
Alex Dik	e94603f6a8	Remove submissionPromises reference from WP comment directive	9 years ago
Oliver Günther	d1a53ddcf8	Remove comment notification	9 years ago
Jens Ulferts	64819caa14	use standard notification message ... To the user, an update is an update.	9 years ago
Alex Dik	d82bd3ebe4	Move WP comment directive to new components location	9 years ago
Jens Ulferts	31709781e9	correctly initialize comment controller	9 years ago
Jens Ulferts	f676d036f6	allow for issuing a second comment with the same controller	9 years ago
Oliver Günther	bd1247d376	Strip notify from frontend ... The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Alex Dik	5aeccc2d2c	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	5c9975fd64	Implement WP-edit save button	9 years ago
Jens Ulferts	dbfcfb49b7	Revert "Merge pull request #3646 from furinvader/16364-fullscreen-edit" ... This reverts commit cddeebbf43, reversing changes made to 44ba79e900.	9 years ago
Alex Dik	b422907206	Reduce fieldController redundancies ... [ci skip]	9 years ago
Alex Dik	be5beca5ca	Implement WP-edit save button	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Henriette Dinger	01d47ea851	Editable comment field ... This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago