openproject

Commit Graph

Author	SHA1	Message	Date
Wieland Lindenthal	a18954b2c9	Placeholder user services and administration (#8944 ) * Adding placeholder user contracts * Adding create, update, and delete services for placeholder users * WIP: Adding Placeholder User contract specs [ci skip] * Extract contract validation into common helper * Add common validation in BaseContract + common example for admin checks * Introduce common ModelContract shared context for validations * WIP: PlaceholderUser controller, i18n, and routes [ci skip] * Placeholder users index page and query - moved all group related scopes from User to Principal to make them also available in PlaceholderUser. * end * Create PlaceholderUser * Feature spec for editing a placeholder user * Manage PlaceholderUser memberships The managment of memberships is pretty similar for User and PlaceholderUser. This commit extacts the similarities and uses them for both. * General partial and show view for PlaceholderUser * Delete obosolete partial * Allow RequireAdminGuard to be used as a module function * Fix I18n for confirmation text * Smaller code improvements * Fix: Syntax for accessing status enums was wrong. * Use UpdateService for updating a placeholder user * Add spec for PlaceholderUsersController * First code improvements after code review. - more improvements to come. * Further code improvements after review ... still more to come * Correct namespace of delete service * Fix: Make placeholder user contract validate * Remove :type attribute from base contract of User and PlaceholerUser ...and add it to the CreateContracts. Also add type validations. Further extract shared examples for placeholder user attribute validation * Refactor: Extract membership hook calls to helper * Fix redirect paths for membership controllers * Specs already present in shared exampels. * Fix duplicates routes for users and placeholder users * Fix user path * Add attribute name and lastname We don't need a writeable check as both are equally writable * Replace more references to tab_edit_user_path * Skip specs for PlaceholderUsers::DeletionService We will tackle that service in a separate PR. * Fix module usage of RequireAdminGuard * Fix group filter for placeholder users * Fix invalid reference to expect_valid * Fix: Fix tabbed edit path for placeholder users * Fix status filtering on users * Linting * Improve generalisation of individual principal filter cell - Check for presence of groups and statuses in order to toggle visibility of their UI element. - Remove groups from placeholder user controller and cell initialization and options * Fix selector on groups assign * Remove using_shared_fixtures Co-authored-by: Oliver Günther <mail@oliverguenther.de>	4 years ago
ulferts	1bdd2ab9ae	safe automatic fixes by rubocop (#8994 )	4 years ago
Oliver Günther	cdf3cf4c34	[36136] Rework members page to show name and avatars for principals (#8973 ) * Rewrite members page to output name column * Remove white-space nowrap for long login names in administration * Extend member specs * Allow query instance to be used in table cell * Fix memberships specs with changed columns * Add order for email * Review feedback * Allow x to close add member form * WIP sort firstname/lastname * Make status sortable * Extract order_by_name into the order class * Re-add but deprecate order_by_name It's still in use in combination with some special scopes (custom actions for example) that I don't want to remove right now * Rewrite order_by_name into scope	4 years ago
Oliver Günther	15a2716d95	[35012] Use reorder in table cell to correct sort order In the users table, an implicit order(ID asc) was added before passing to the table cell, which resulting in additional sort orders to only be appended and useless with ID order. To ensure we sort first by the request attribute, then by ID, a `reorder` is used. https://community.openproject.com/wp/35012	4 years ago
ulferts	5ea185ef66	Placeholder user project members (#8961 ) * remove intermediate placeholder scope Doing so, placeholder users will begin to show up in the system * remove scope without value * extract scope * use enum for status * allow placeholder users to become project members * display placeholder user member on members widget * remove now superfluous method The status name can simply be queried via #status now * replace possible_assignees/responsibles on project This also leads to placeholder users becoming eligible as assignees and responsibles. * fix aggregated scope on bulk edit * linting * remove IssueHelper	4 years ago
Oliver Günther	3c9be3bdbe	[35507] Allow global permission to add and edit users (#8937 ) * Add global permission for add_user * Rename fieldset for global roles to "Global" * Add permission to admin actions * Add index action to add_user permission * Redirect to first admin item if only one * Hide status action for non admins * Break down user form into partials for easier rendering * Disable some user form tabs for non-admins * Make users API and services conformant with endpoints * Fix references to DeleteService#deletion_allowed? * Authorize add_user on show as well * Only show invite user toolbar item with permission * Fix Delete Service spec * Fix the way user prefs are handled in service * Ensure session_id is treated as string This causes a cast error otherwise as it passes rack session locally * Fix service call on onboarding controller * Fix service call on users controller * Add delete spec for global user * Hide login attribute again when adding a new user * Render auth source correctly in simple form * Fix creating invited users through service The invitation requires the mail attribute to be present. Previously, there was a manual error added to the mail. As the errors are now determined by the contract + model, we now end up with all missing properties as errors. * Properly constraint attributes for non-admins * Add specs for global user * Start working on how to update password from UsersController that code is a mess... * Change permitted_params spec to include non-admin params * Fix create user service spec * Remove mail_notification param from users controller It's not part of the contract/params passed to user * Remove todos * Extend docs * Correct the way backlogs patches into the user settings * Remove superfluous UpdateUserService * Rewrite duplicated update service examples into common shared example * Remove duplicate password writable check * Base Users::DeleteContract on base delete contract * Move checks for active users into the UserAllowedService * Restore password writable check as it is not an attribute * Fix menus for global user * Allow global users to add custom fields * Allow global user add permission to reinvite user * Fix changed var name in update service spec * Ensure also invited or registered users can be authroized This ensure that e.g., invited users can also be set as watchers * fix typo Co-authored-by: ulferts <jens.ulferts@googlemail.com>	4 years ago
ulferts	6140f4c7e9	update copyright to 2021 (#8925 ) Updates the copyright to 2021 for all files that have a copyright. Files in our source code without the copyright header still do not receive one automatically. Additionally, backlisted files are also excluded. Previously the copyright of chiliproject which references redmine stated a copyright of redmine up to and including 2017 which is not true for the code we have in here. Because of that I changed that to 2013	4 years ago
ulferts	6cce947cbd	Chore/rename timestamps (#8765 ) * rename timestamps on time entry * add updated_at filter/order for time entries * rename on cost entries as well This will make handling in the cost query easier * adapt specs * linting * adapt project activity * update references to updated_on * remove outdated docs/code * global memberships are just memberships * rewire global membership creation/update/deletion * delete no longer required code and patches * move code to core * move specs to core * completely remove global roles in the form of a plugin * adapt specs * remove unused methods * migrate existing data * adapt membership representer to changed timestamps * global memberships available via API * implements created/update_at filters on memberships * update member on roles being added/removed * specify default value for created_at * fix project permission check and validation on members * adapt membership schema * adapt usage of sort by on members widget * support created/updated_on for api sort and filter * remove outdated model file * rename timestamps * allow specifying timestamp column for aaj * reload column information * further rename of created_on * include updated_at into journal creation * adapt document updated_at calculation * remove references to JournalVersion	4 years ago
Oliver Günther	1bdc2daff9	[34509] Output html of custom field long text value on projects https://community.openproject.com/wp/34509	4 years ago
Behrokh Satarnejad	1943c4db29	making the projects table scrollable and has sticky header (#8692 )	4 years ago
Oliver Günther	33294a2911	[34190] Add missing wiki classes on project list https://community.openproject.com/wp/34190	4 years ago
Oliver Günther	15a8257314	Add missing status explanation column to projects	4 years ago
Oliver Günther	e8dde985aa	Make columns configurable in admin settings	4 years ago
Oliver Günther	79bfe2a922	Refactor project list into cell	4 years ago
Oliver Günther	10e21154f7	Move asset pipeline javascripts to frontend (#8482 ) * ove reporting and reporting_engine js to frontend page * Replace webhook assets javascript * Add path augment service to dynamically load scripts * Remove JS-Files that are not used/not needed any more * Include AugmentingModule correctly * Remove special handling for checkbox selection which is outdated and two jquery libs that are not used any more * Load scripts dynamically that are not needed globally * Move plugin JS to frontend * Move toggable fieldsets to global listeners * Move top-menu to global listeners and convert to TS * Move action_menu to frontend and port to TS * Move settings listener to frontend * Remove global js assets that were not used anyway * Move date range to timelog dynamic script where it's still used until removed * Move colors to global-listeners and port to TS * Replace tooltip with simple form instructions on the one place used Tooltips were only used at the one place in our application, when changing a users password. We can simply remove it there and use a modern solution the next time we need a tooltip * Move danger zone validation to frontend and port to TS * Move colorcontrast to backlogs vendor where it's used now * Remove contents of application.js.erb * Move project and user scripts to dynamically loaded * Move onboarding tour to dynamically loaded * Use correct syntax for jQuery so that $ is known keyword within this function * Fix onboarding tour * Fix onboarding tour for scrum tour * Fix specs after moving JS * Remove application.js.erb * Move locales and ckeditor to the frontend to dynamically load * Remove bundles caches These are no longer being used since angular cli * Ensure locales are exported before angular Co-authored-by: Henriette Darge <h.darge@openproject.com>	4 years ago
Oliver Günther	812cbf183c	Allow filters to define multiple LDAP synchronized groups	5 years ago
ulferts	66fe8c3d5a	remove unneccessary brackets	5 years ago
ulferts	bd4b59e321	replace backlogs page overriding by cell	5 years ago
Oliver Günther	1008a2c4c1	[32274] Show the original roles for admins https://community.openproject.com/wp/32274	5 years ago
ulferts	5643876280	avoid having a ckeditor fields for every language	5 years ago
Henriette Dinger	bd7f4e4814	Update copyright notice	5 years ago
ulferts	5b217ec039	prevent multiple clicks on member destroy link	5 years ago
Oliver Günther	5eb6fbf676	[31082] Remove max-height from ckeditor As we now have a proper `position: sticky` solution, the max-height is no longer required. It can by itself scroll when the next outer scroll container is being scrolled, which works on both content-wrapper scrolled pages, and work package pages. However that requires that we avoid `overflow: hidden` on the `form--fields` so this introduces a modifier for globally scrolled pages to do just that. https://community.openproject.com/wp/31082	5 years ago
ulferts	a93ecca5a8	Feature/members api show (#7308 ) * basic members collection response * complete member index end point * document versions#index * remove user association from members There is already a more generic principals association. Having both causes confusion and leads to duplicate loading of models * linting * remove disabled test * add members#show api end point * add project and principal to member representer * replace member.user reference with principal * use principal reference in project members association * modernize roles api * complete member representer rendering * replace remnants of user association * add member schema api endpoint * have dedicated available projects end point for versions * linting * limit roles to assignable ones in schema * rename member to membership in api * remove remnants of user in member * spec fixes * use available_projects endpoint in versions board * add eager loading to memberships#index * members create form api endpoint * ensure role exists for default assignment * extract switch for users/groups to work_packages representer * document membership create form * add l10n expected in specs * strengthen the usage of a delete base service * use base class for set attributes service * fix alias in service * add create endpoint to members api * document members create endpoint * linting * adapt to altered service signature * use default endpoint for wp#get * use CF infused representer [ci skip]	6 years ago
Oliver Günther	67b3e575ce	[28036] Give admin all roles in a project https://community.openproject.com/wp/28036	6 years ago
Oliver Günther	70e2393f6a	[29611] Remove members group sort by https://community.openproject.com/wp/29611	6 years ago
Jens Ulferts	c0042fc032	bump fog-aws & cells	6 years ago
Jens Ulferts	953fb05824	Revert "Merge pull request #6986 from opf/fix/bump_gems" This reverts commit `9dd97f66c6`, reversing changes made to `72e5dc6d9b`.	6 years ago
Jens Ulferts	1cada767da	bump fog-aws & cells	6 years ago
Oliver Günther	d68a015f45	Review feedback	6 years ago
Oliver Günther	9e72c05ed3	Implement client credentials flow with a custom user_id	6 years ago
Oliver Günther	91e884d41c	[29334] Fix alias name for group sorting https://community.openproject.com/wp/29334	6 years ago
Oliver Günther	e41d85e9c7	Implement OAuth applications CRUD	6 years ago
Inga Mai	edc3bcc613	Remaining Labels removed; titles for all buttons instead	6 years ago
Inga Mai	7344eb0af3	Codeclimate and tests fixed	6 years ago
Inga Mai	de20d43ee3	Delete and edit icon texts in tables removed	6 years ago
Henriette Dinger	6259e4f2d5	Refactor simple filters to CSS grid layout && generalize rule for forms in toolbars	6 years ago
MarcoSpittka	245ef7b60c	changed mysql alias Update table_cell.rb - changed mysql alias groups for upwards compatibility	6 years ago
Oliver Günther	45453fb589	Prepare for core integration	6 years ago
Oliver Günther	7fc6e7f914	Prepare for core integration	6 years ago
Oliver Günther	c67cc392ce	Prepare for core integration	6 years ago
Oliver Günther	3ba6913960	Implement read-only work package attributes based on status	6 years ago
Oliver Günther	d64de4953d	Add some missing buttons to groups management [ci skip]	6 years ago
Oliver Günther	95d2cb54aa	Pass action_view to rails cell to correct helpers	6 years ago
Oliver Günther	0a136e61b4	Use larger form controls for ckeditor fields	6 years ago
Oliver Günther	19292229ac	Replace modal-wrapper with service	6 years ago
Oliver Günther	aea0e41001	Add check box to update consent time to current time	7 years ago
Oliver Günther	48087bf6d4	Seed better colors and apply them to status and prirorities	7 years ago
Oliver Günther	0f5813ec3b	Improve styling of display fields	7 years ago
Oliver Günther	a101a67374	Add color to priority	7 years ago

1 2 3

109 Commits (a18954b2c9c8a1b3f2891cff9910b2b96306b7c0)