13027 Commits (a48792b12b24b23f1a64752dfb9f1278ce203644)

 

All Branches   

Search

Author	SHA1	Message	Date
Martin Linkhorst	a48792b12b	no underscores for private methods	11 years ago
Martin Linkhorst	10d694f6e9	push down callback block check into OpenProject::Notifications	11 years ago
Martin Linkhorst	88ce1c9d9d	Merge remote-tracking branch 'origin/dev' into feature/settings_callbacks	11 years ago
Hagen Schink	9341fd5d6e	Add changelog entry	11 years ago
Hagen Schink	0d99603b49	Merge pull request #1024 from opf/feature/admin_membership_notices	11 years ago
Alex Coles	1f041e0415	Merge pull request #1111 from opf/feature/rubocop ... Add rubocop.yml	11 years ago
Michael Frister	9ea81d0e8d	Add rubocop.yml	11 years ago
Martin Linkhorst	f0b1df9e07	based the settings callbacks on OP::Notifications	11 years ago
Martin Linkhorst	feba6723cd	specs for the OP::Notifications based settings notifier: ... * arguments to the block is a hash * no clearing of callbacks * no callback objects	11 years ago
Alex Coles	e712ee9f29	Merge pull request #1102 from opf/fix/auto_complete_tumbling_spec ... should fix tumbling spec by avoiding explicit id	11 years ago
Jens Ulferts	91588523ce	should fix tumbling spec by avoiding explicit id	11 years ago
Michael Frister	30ea6190ee	Add public/javascirpts to gitignore	11 years ago
Hagen Schink	cf0bd8b412	Merge pull request #1100 from opf/fix/fix-controller-specs-in-plugin-envs	11 years ago
ulferts	2f926e7497	Merge pull request #1097 from opf/fix/4789_story_points_not_visible_in_wp_show ... Extract work package attributes to partial	11 years ago
Alex Coles	513c2fc8a5	Switch rspec-example_disabler to a git dependency ... Using master until further work on a new rspec-example_disabler release. Master contains a fix for an issue in an OpenProject environment configured with certain private plugins that disable Controller specs with `RSpec::ExampleDisabler`: rather than being disabled, examples were instead resulting in a `NoMethodError`. See: 45cf9ce55a Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Martin Linkhorst	7a29578dfd	adds a spec to test invocation of multiple callbacks	11 years ago
Martin Linkhorst	dda5226dff	fire callbacks only when setting was stored sucessfully	11 years ago
Martin Linkhorst	48abe7d64c	dry up setting specs	11 years ago
Hagen Schink	2f003f9a41	Extract work package attributes to partial	11 years ago
Philipp Tessenow	f4282fc712	Merge pull request #1064 from opf/fix/rspec-expect-syntax ... Migrate all specs to the newer expect syntax	11 years ago
Hagen Schink	fbf074ed64	Precompile acitvate error messages js	11 years ago
Philipp Tessenow	9db54f08a0	call private methods the right way	11 years ago
Alex Coles	21d588a1c3	Merge pull request #1092 from opf/fix/ruby_2_0 ... Fix/ruby 2 0	11 years ago
Philipp Tessenow	eb4a18ea7d	do not use ruby 2.1 features so we still support 2.0 inofficially	11 years ago
Philipp Tessenow	b26b15ce89	prepend private_class_method to private class methods ... this applies even if they are in the 'private part' of a class definition as in: class Foo ... private def foo; 1; end def self.foo; 2; end end Foo.foo #=> 2 Foo.new.foo #=> NoMethodError: private method `foo' called	11 years ago
Alex Coles	0dcd16d3af	Convert specs to RSpec 2.14.8 syntax with Transpec ... This conversion is done by Transpec 1.10.4 with the following command: transpec spec/models/permitted_params_spec.rb * 10 conversions from: obj.should to: expect(obj).to * 10 conversions from: == expected to: eq(expected) * 1 conversion from: obj.should_receive(:message) to: expect(obj).to receive(:message)	11 years ago
Alex Coles	73b809574a	Merge branch 'dev' into fix/rspec-expect-syntax ... Signed-off-by: Alex Coles <alex@alexbcoles.com> Conflicts: spec/models/permitted_params_spec.rb spec/models/work_package/work_package_acts_as_journalized_spec.rb spec/models/work_package/work_package_planning_spec.rb	11 years ago
Philipp Tessenow	56d1a24fc8	Merge pull request #1066 from opf/fix/peg-simplecov-version ... Peg simplecov version to 0.8.0.pre	11 years ago
Martin Linkhorst	99427f281c	re-render everything so there won't be multiple error flash messages on the page	11 years ago
Martin Linkhorst	c00771156a	do not display successful flash message when in wasn't	11 years ago
Philipp Tessenow	40133c1d6a	Merge pull request #1080 from opf/feature/users_strong_parameters ... Use ForbiddenAttributesProtection for User	11 years ago
Michael Frister	4c93ba8e62	Add spec for PermittedParams.add_permitted_attributes	11 years ago
Michael Frister	78ab5970a4	Allow plugins to add permitted attributes	11 years ago
Michael Frister	0c338e042a	Remove attr_protected on User now that we use strong_parameters	11 years ago
Michael Frister	a5b73fdc0c	Fix Users controller test with strong parameters	11 years ago
Michael Frister	3c324bdc42	Use strong_parameters for User, remove safe_attribtues	11 years ago
Philipp Tessenow	37f954409a	update changelog - fix #1865	11 years ago
Philipp Tessenow	1ee8a53b67	Merge pull request #1028 from opf/fix/remove_symbols_from_journal_creation ... Removes symbols from the creation process of journals ...	11 years ago
Philipp Tessenow	77dd0dfe9d	update changelog - fix #4007	11 years ago
Philipp Tessenow	0d8346399d	Merge pull request #1025 from opf/fix/timelines_page_titles ... put timeline name into page title where possible	11 years ago
Philipp Tessenow	f6e4eee8b6	update changelog - fix #1502	11 years ago
Philipp Tessenow	18b35643dd	Merge pull request #1026 from opf/fix/members_double_escaping ... Fix/members double escaping	11 years ago
Alex Coles	7744683518	Merge pull request #1087 from marutosi/finn-weigh ... fix miss fixing 'weigh'	11 years ago
Toshi MARUYAMA	00d60e9583	fix miss fixing 'weigh'	11 years ago
Philipp Tessenow	a5fe50a080	Merge pull request #1085 from opf/fix/doc-typo-fixes ... Fix typos, spelling in comments and docs	11 years ago
Alex Coles	31a6a2597f	Fix typos, spelling in lib-folder comments ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	376eca0f72	Fix typos, spelling in helper comments ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	c409c542c3	Fix typos, spelling in mailer comments ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Alex Coles	d872d91d0d	Fix typos, spelling in model comments ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Martin Linkhorst	c9effc5b6b	implements callbacks for settings	11 years ago