63 Commits (a93ef1a6885fe9890507e58e6ef23f734b526718)

Author	SHA1	Message	Date
Jens Ulferts	ea745865ad	remove focusability/role on non editable elements	9 years ago
ulferts	1d99206232	Fix/accessible error messages (#4529) ... * add error messages to each field * move role=alert up so that success messages are also covered * remove focus code from notification-box directive The box does not need to be focused as it has the role=alert which will lead to it being read out. * remove specific focusing behaviour for accessibility mode The mode was introduced to present error messages to user requiring assistive technology e.g. screen readers. By setting role=alert on the error fields and additionally labeling the fields with the errors, this should no longer be necessary	9 years ago
ulferts	cbd33707b8	don't submit field if we already know it to be erroneous (#4525) ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
Jens Ulferts	43a4ecce5d	remove wpEditField dependency from wpDisplayAttr	9 years ago
Jens Ulferts	48200d3a5c	don't submit field if we already know it to be erroneous ... Either because: * it is required and empty * it is erroneous and unchanged	9 years ago
ulferts	76e2a5e0ce	submit on user blur (#4513) ... Will also submit the work package when clicking somewhere else (blur).	9 years ago
Jens Ulferts	3bfc489a8e	remove html-class setting already present in the template ... There is already an ng-class statement setting the desired class upon editability. As the wp-edit-field directive is applied via an attribute, the $element is the dom element the directive is an attribute of. That way, the -editable class is applied twice.	9 years ago
Roman Roelofsen	e0bf811f77	Reduced watchers count, needs review!	9 years ago
ulferts	48ac7aa6f4	introduce strategy for displaying fields (#4469) ... In order improve the code structure and in order to enable plugins to add display strategies for fields, that are not covered by the core yet, a strategy pattern is introduced for displaying fields. The mechanism is identical to the way EditFields are handled. In fact, the DisplayFields and EditFields now inherit from a common superclass, Field. Also, the service and the factory inherit from a common superclass.	9 years ago
Oliver Günther	c223d6f108	Explicit setter for wpEditField.workPackage	9 years ago
Oliver Günther	ca65f078c3	Fix leftover values from wp resource still showing up ... The display-attr causes old values in the resource to still show up, despite no associated schema being available. I don't think it hurts to have old values in the resource, as long as we can ensure that it's the schema that decides what is showing.	9 years ago
Oliver Günther	6589b6ba50	Initialize edit field when work package is updated in cache	9 years ago
Oliver Günther	ef94a15660	[23120,23121] Add required fields, labels to wp-edit-fields (#4421) ... * Add default label (name) to fields * Mark fields as required when schema says so * Work around xvfb :invalid state	9 years ago
Oliver Günther	9c7a368c05	Fix description focussing	9 years ago
Oliver Günther	6549869000	Fix focussing on erroneous fields	9 years ago
Oliver Günther	2bdf6ac776	Remove invalid description spec	9 years ago
Oliver Günther	a1755f3ef3	Avoid click propagation from active edit-fields (#4428) ... Avoid clicks within the form to bubble up to the row handler. Otherwise, clicks within wp-edit-fields may cause the split / full view to open.	9 years ago
Oliver Günther	5da8c31f40	Fix switching types in Edit all mode	9 years ago
Oliver Günther	760fc47c7f	Fix focus on first element on create	9 years ago
Oliver Günther	67e4551387	Mark WorkPackageResource as dirty when values were changed ... This allows us to check the cache services for changes in the work package and not refresh it from the cache. Currently, this is only relevant for edit all mode, however it may be the entry point for a API merging / refreshing service.	9 years ago
Oliver Günther	b849514904	Separate methods for entering/cancelling by user events	9 years ago
Oliver Günther	426876a264	Fix enabling fields by default when switching	9 years ago
Oliver Günther	cd17492a44	Save $pristine values in work package resource	9 years ago
Oliver Günther	d34799a89a	Edit all on fullscreen view	9 years ago
Oliver Günther	650b5f4159	Implement edit-all through wpEditForm	9 years ago
Oliver Günther	a5823dc755	Fix error state of fields newly introduced by type switch	9 years ago
Jens Ulferts	23515190cb	restyle subject on the wp.show	9 years ago
Oliver Günther	6533df1d7a	Focus description field correctly	9 years ago
Jens Ulferts	e5d874a966	Accessibility for wp-edit fields ... * Hidden label for all fields once they are activated * aria-labelledby for all fields when they are in read mode * turned visible attribute text on split/fullscreen to be clickable so that it behaves like a label	9 years ago
Oliver Günther	91ba21556e	Focus element when exiting edition	9 years ago
ulferts	a4c8fa75bb	add ability to activate inline edit fields via keyboard (#4405) ... Allows tabbing on the inline edit field. https://community.openproject.com/work_packages/23076/activity I feel that one scenario is still not supported the way it should be. If the user presses the "ESC" key while being in an inline edit input, the input disappears and the text representation is displayed as desired. But the focus is not placed on the text so it becomes hard to reactivate the field as the user has to start the tabbing journey anew. I couldn't get this to work as the field can only be focused after it reappears.	9 years ago
ulferts	4b8ec6dcf4	add ability to activate inline edit fields via keyboard (#4405) ... Allows tabbing on the inline edit field. https://community.openproject.com/work_packages/23076/activity I feel that one scenario is still not supported the way it should be. If the user presses the "ESC" key while being in an inline edit input, the input disappears and the text representation is displayed as desired. But the focus is not placed on the text so it becomes hard to reactivate the field as the user has to start the tabbing journey anew. I couldn't get this to work as the field can only be focused after it reappears.	9 years ago
Oliver Günther	2c26ecdeec	Toggle preview without saving the description	9 years ago
Oliver Günther	ac592de867	Restore preview functionality	9 years ago
manuschiller	c0e66f1646	fix for pristine check with formattable fields	9 years ago
Alex Dik	977e6529a5	Adapt WP edit form to WP edit sync	9 years ago
Oliver Günther	0039d7727f	Force focus on click, even in accesibility mode	9 years ago
Oliver Günther	4cc339eb48	toggleClass requires actual booleans	9 years ago
Oliver Günther	42cb4a7a78	Show inline-create in global work package list (#4340) ... When no project context is available, this fetches the `available_projects` endpoint and suggests using the first project for creating a new row.	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290) ... * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
Oliver Günther	f9fe1a5d79	[22916] Inline edit only on attribute text, double click to fullscreen ... * Reduce editable field to wp-table--cell-span * Allow macs to CMD-click for multiselect * Set double click to full screen * Set focus expectation to anchor * Fix flickering in inline expectation * Update selector for double clicks * Simplify innerMostSpan * Add spec for double click full view	9 years ago
Henriette Dinger	47fe6c2ba6	Add additional condtition to avoid error message when clicking on ID	9 years ago
Oliver Günther	33ac29e2ac	Inline edit: Add tooltip when form not editable ... This adds a toolbar to attributes which are writable from their schemas, but are no longer writable when their form is loaded. This may happen for, e.g., priority of parent work packages, but also other magic constraints. While we work on reducing the magic in the constraints, a generic tooltip offers the fastest user-friendly way of informing the user of constraints.	9 years ago
Oliver Günther	b2c44f8a4b	Keep loading Promise in Hal resource	9 years ago
Oliver Günther	2710c2f754	Cache resources in halResource	9 years ago
Oliver Günther	8b2a068ede	Fix schema loading	9 years ago
Oliver Günther	05845e3e0d	Skip activation when already activated ... ng-aria probably adds keypress handlers to ng-click handlers for screenreaders, such as for space. This triggers `activate` of the inline edit and causes the pristine copy to be invalid.	9 years ago
Oliver Günther	c2d0828c98	Make escape cancel edition and restore pristine value	9 years ago
Oliver Günther	b34b28b632	Load schema to determine writable state	9 years ago
Oliver Günther	ec3f48e6a6	Add class states to outer td element ... Mark the td element with `-editable` when the wp-edit field is editable.	9 years ago