79 Commits (a9700deed639bd94f14b25536519d7d1b6ac185d)

Author	SHA1	Message	Date
Jens Ulferts	e7bba2aa8b	show errors on fields	9 years ago
Oliver Günther	bd1247d376	Strip notify from frontend ... The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Jens Ulferts	dbfcfb49b7	Revert "Merge pull request #3646 from furinvader/16364-fullscreen-edit" ... This reverts commit cddeebbf43, reversing changes made to 44ba79e900.	9 years ago
Alex Dik	0faeeff74c	Refactor inplace-edit directory structure ... [ci skip]	9 years ago
Alex Dik	5dbb78fe79	Replace UI Select with default HTML elements ... [ci skip]	9 years ago
Alex Dik	9ec5cd8ea6	Reset user input when cancel button is used in edit mode	9 years ago
Alex Dik	be5beca5ca	Implement WP-edit save button	9 years ago
Alex Dik	9b290d18f3	Refactor EditableFieldsService and EditPaneController ... Move isActiveField and getPendingFormChanges to EditableFieldsState service.	9 years ago
Alex Dik	b9bf6d0274	Add work package edit actions toolbar (save & cancel) ... Saving the work package does not work as of yet.	9 years ago
Alex Dik	c662325ba8	Implement work package editing in fullscreen view	9 years ago
Oliver Günther	d5a3b21049	Scroll to element only when visible ... Introduces a simple helper plugin to determine whether an element is `visible()`.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	7f602664fc	Allow focussing an element after work package has been updated ... This commit allows comments or fields to specify a callback after the work package has been updated. This is currently used to scroll to the element (such as the inserted comment), whenever the work package has loaded.	9 years ago
Oliver Günther	9bd4e06d29	Use promises in submitFields methods to defer updating ... As submitting comments and fields in one go requires work packages to be submitted first, we can use promises to ease the processing of each and abort early, e.g., when the WP couldn't be updated, we don't want to submit the comment.	9 years ago
Oliver Günther	8da4ac0d63	Restore empty description submit	9 years ago
Oliver Günther	c3589353cb	Scroll to textarea controls when editing and space available	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	5732eee3d3	Propagate and distribute field and comment submits in WP Field Service ... This commit allows parallel saving of comments and fields, however this currently results in a conflicting modification due to two saves with thes same lock version.	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Henriette Dinger	01d47ea851	Editable comment field ... This provides the basic functionality to deliver a comment field in the in-place editing style. Adds the `autogrow` plugin This still breaks a number of features currently, such as formatted previewing.	9 years ago
Jens Ulferts	adb27e589e	open ui-select upon watcher adding clicked	9 years ago
Jens Ulferts	aadf639e68	remove helper method no longer needed	9 years ago
Florian Kraft	df2a5fb02a	only show errors when there are errors to be shown ... Errors were alwas shown by accident. As the EditableFieldsState object is not cleared upon successful request, using `finally` would show the error once more for a successful api call. Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	1faff1dada	show the errors when the requests have completed ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	93a3b2a56e	intitial display of error messages via the notification service ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	a3595873fa	separating viewmodel and view logic	9 years ago
Jens Ulferts	bb3f9fdc6c	consolidate duplicate code	9 years ago
Jens Ulferts	3232a3d21b	sort version by name	9 years ago
Florian Kraft	9d679cb68f	update tests and fix codestyle problems ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	96d5cdab8f	basic upload for details view ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64ff5a7383	use distinct event for uploading pending attachments ... Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Mihail Maxacov	ebe62238d0	peace between create and update	10 years ago
Mihail Maxacov	edc8b7b5f7	seamless edit/create	10 years ago
Mihail Maxacov	6e965d9e3d	buttons and functional view	10 years ago
Mihail Maxacov	76521e956e	barely breathing wp form	10 years ago
Jan Sandbrink	2c19f97345	centralize knowledge of WP autocomplete url ... - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	10 years ago
Jan Sandbrink	cc844c1068	centralize knowledge of WP autocomplete url ... - project information is not needed anymore - the endpoint format was fixed anyway (also accepted parameters)	10 years ago
Mihail Maxacov	785a0f93cc	code extraction	10 years ago
Mihail Maxacov	3fdbe072d0	subject and some description specs	10 years ago
mhirtie	132a126f93	Change done button behaviour.	10 years ago
mhirtie	f7b668437e	Refactor date range directive to match the current system of directives.	10 years ago
mhirtie	2124e98622	Add of posibility to select end date before start date, and vice-versa. ... Add of highlighing of changed field.	10 years ago
mhirtie	dc8a037f02	Fix changing of month when clicking arrows.	10 years ago
mhirtie	b6119c069f	Fix editing of null date for type 'Milestone'.	10 years ago
mhirtie	50c3df3f09	Fix date field on changing type to Milestone and back. ... Fix hiding of datepickers.	10 years ago
mhirtie	086a346cf0	Add title labels. Remove console.log call.	10 years ago
mhirtie	790a951c16	Merge of changes from different PRs.	10 years ago
mhirtie	83a03b3e99	Fix reversing day and month. Changed date-format on write. Added hints for date format.	10 years ago
Mihail Maxacov	4363e7c31b	fix focus	10 years ago
Mihail Maxacov	15dc43c302	display control elements on one element only; fix title	10 years ago