14 Commits (acac10820dc7d911a44f129822bf451ca3982d81)

Author	SHA1	Message	Date
Oliver Günther	e8f668fc52	Remove traces of workPackageRefreshRequired	8 years ago
Oliver Günther	cd20eb05f9	Remove HALAPIResource	8 years ago
Oliver Günther	f705e4d9ac	Rewrite comment directive in TypeScript without inplace	8 years ago
Oliver Günther	e4f479c1b4	Use WorkPackageResource in panels	8 years ago
Alex Dik	d36099f6ca	Implement wpActivity service ... Move the main logic into this service instead of having it in the controller.	9 years ago
Oliver Günther	bd1247d376	Strip notify from frontend ... The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Tim Habermaas	8554125f63	Move isInitialActivity to ActivityService.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback ... * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview ... This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Alex Coles	e0191e759c	Update year in copyright header to 2015 ... [ci skip]	10 years ago
Alex Coles	6ec5ca58ed	Move Angular app under frontend/app ... This mass rename has been brought forward to work-around an apparent naming collision when running Karma tests. ERROR [karma]: [Error: Path is a file /_js/app/assets/javascripts/angular] Error: Path is a file /_js/app/assets/javascripts/angular Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	3abdbac4c9	Fix semicolons in Angular app to placate JSHint ... Most final semicolons missing after conversion to CommonJS modules (see 5f6696d5). Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	5f6696d5db	Restructure Angular app into CommonJS modules ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Alex Coles	89646b9ca3	Make activityService send request body as JSON ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	10 years ago
Richard	815ff9f5cb	Require comment text on overview/activity.	10 years ago
Richard	3888e3d830	Add addComment link to work package representer and wire up template.	10 years ago
Richard	64734f2291	Wired up update comment permission to front end.	10 years ago
Richard	ee29bbd089	Journal editable_by? checks if user is the journal owner.	10 years ago
Richard	80ce549f82	Performing updated but not updating the view yet.	10 years ago
Richard	5820a8e470	WIP quoting and editing of comments. not working!	10 years ago
Richard	b02d01550b	Added some tests for latest filter and activity service.	10 years ago
Richard	baa487af2a	Forgot to add activity service:>	10 years ago
Alex Coles	c023400642	Add/update Copyright header to ng app sources ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	11 years ago
Richard	cf12e1f74b	Wired up assignee's role and group filters.	11 years ago