TheDude
/
openproject
2
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6216 Commits
139 Branches
203 Tags
1.2 GiB
Tag: Branch: Tree: b231930f69
Branches Tags
${ item.name }
Create tag ${ searchTerm }
Create branch ${ searchTerm }
from 'b231930f69'
${ noResults }
Commit Graph

6216 Commits (b231930f69969955c7b007fc5ff2687c25a7f2ae)
 

Author SHA1 Message Date
Martin Linkhorst b231930f69 why use an instance variable here? this makes more sense and fixes the tests
12 years ago
Martin Linkhorst d563d3387f fix active record queries by correctly using the new api
12 years ago
Martin Linkhorst f3ea450c1e expect two emails since we send one email per user instead of bcc'ing them. we could stub out the #notified_users to remove the magical number and make it more clear but the stubbing is somehow forgotten on the way
12 years ago
Martin Linkhorst aa18d1fe22 REVIEW: since this started with "test_" it was executed each time one executes the tests. test/unit does not seem to require it anymore but it maybe causes errors in some different task?
12 years ago
Martin Linkhorst c06e3fa94a Just make sure we have a clean state before creating the project
12 years ago
Martin Linkhorst 621fe4a477 clone will return the same active record object (same id in the db) which will cause an issue relation to be invalid (same object in from and to). this creates two active record objects which you can then link to each other. probably active record changed the way they handle #clone
12 years ago
Martin Linkhorst d9f422e6b0 use #joins instead of #includes since includes does seem to have a bug when combining with #maximum, #sum etc.
12 years ago
Martin Linkhorst 74866ae596 omit default scope by using reorder
12 years ago
Martin Linkhorst 35bf0301f2 REVIEW: this gem adds the #auto_link method which is used several times in the code. it was removed in rails 3.1. we should get rid of this dependency at some point in time.
12 years ago
Martin Linkhorst d9f2f17b5d REVIEW: include ERB::Util module in order to use #h and co in the all helpers.
12 years ago
Martin Linkhorst 7d2f6be3b0 remove the globalize3_patch.rb hack that allowed for uniqueness validation on translations. instead use the current git master since the fix is not yet released in version 0.2.0 of globalize3
12 years ago
Martin Linkhorst 2cf9a31f95 require fastercsv differently (taken form redmine)
12 years ago
Martin Linkhorst 61b9f5abfc DEPRECATION FIX: remove require_library_or_gem, update the template hander api
12 years ago
Martin Linkhorst 01a502712d small refactoring of the document tests. note the failing test that actually should pass.. investigate that later
12 years ago
Martin Linkhorst e6e421297e yay, and active record bug, woohoo :) TODO: fix me on rails 3.2
12 years ago
Martin Linkhorst 7de159fbca refactor comment class and fixed the tests. give news a clearer api to create a comment for a news object. this couples news to the comment class atm but can easily be extracted into a module or so.
12 years ago
Martin Linkhorst 710c3cc2b3 add the database cleaner gem to easily purge data in the db
12 years ago
Martin Linkhorst 366b994407 match the new active record initializer signature when overwriting
12 years ago
Martin Linkhorst f22075f7d7 use a notifier class to abstract the sending of notifications. atm this just checks whether the event should be notified. but in the future this class should abstract more to make the controllers/models and the mailer (i18n) simpler. let's see
12 years ago
Martin Linkhorst 8650015b41 let's not fail, when the subject doesn't have a project assigned. let's just return an empty array of recipients instead
12 years ago
Martin Linkhorst a677322643 this is how it's done now. much better
12 years ago
Martin Linkhorst 46939eb4a6 REVIEW: remove unloaded calls, let's have a look wether that's still needed in rails 3
12 years ago
Martin Linkhorst 3566eb1849 fix deprecated stuff in the helper testcase
12 years ago
Martin Linkhorst 03b6fa88bc remove deprecated constant
12 years ago
Martin Linkhorst dc197a12e5 fix failing migration
12 years ago
Martin Linkhorst 4b7c30a6be REVIEW: remove require_dependency which shouldn't be needed anymore?
12 years ago
Martin Linkhorst d19fdaf6a1 apply the rails 3.1.8 generator on the project
12 years ago
Martin Linkhorst 8743d77ac6 finally, re-enable all deprecation warnings since there are only a few left
12 years ago
Martin Linkhorst 174c8e5d24 DEPRECATION FIX: use #redirect_url instead of #redirect_to in tests
12 years ago
Martin Linkhorst 1775f004b9 DEPRECATION FIX: remove deprecated constant RAILS_ENV
12 years ago
Martin Linkhorst 57abae4b06 call #labelled_tabular_form_for correctly (changed in 36a400b7)
12 years ago
Martin Linkhorst 030242ab7b DEPRECATION FIX: use #descendants instead of #subclasses
12 years ago
Martin Linkhorst f60a29e9e0 DEPRECATION FIX: and the mother of all block helpers #content_tag
12 years ago
Martin Linkhorst 464473c9d7 DEPRECATION FIX: and #javascript_tag
12 years ago
Martin Linkhorst 61d8449764 DEPRECATION FIX: now #syntax_highlight
12 years ago
Martin Linkhorst a37b574d98 DEPRECATION FIX: the notorious #other_formats_links want treatment, too
12 years ago
Martin Linkhorst 2ab039164f DEPRECATION FIX: don't forget #remote_form_for
12 years ago
Martin Linkhorst cec9c06a61 DEPRECATION FIX: and of course #form_for
12 years ago
Martin Linkhorst 9ee4ebde1a DEPRECATION FIX: continuing with #labelled_tabular_form_for
12 years ago
Martin Linkhorst d81ce2a530 DEPRECATION FIX: the saga begins: adding equal signs to form helpers in view. we start with form_tag
12 years ago
Martin Linkhorst d616d0574e DEPRECATION FIX: use errors.add(:base, msg) instead of errors.add_to_base(:msg)
12 years ago
Martin Linkhorst 36a400b711 DEPRECATION FIX: switch some variables around in order to match the new form_for api
12 years ago
Martin Linkhorst 78c4196656 DEPRECATION FIX: use errors[:attribute] instead of errors.on(:attribute).
12 years ago
Martin Linkhorst 6c5239c4e2 DEPRECATION FIX: make a badly named GroupUser model to acts as the join model for a has_many :through between groups and users.
12 years ago
Martin Linkhorst cc8c77bcf9 DEPRECATION FIX: use Rails.logger instead of RAILS_DEFAULT_LOGGER
12 years ago
Martin Linkhorst 8e85f48572 DEPRECATION FIX: use Rails.application.routes.url_helpers instead of ActionController::UrlWriter
12 years ago
Martin Linkhorst 3419564990 DEPRECATION FIX: use save(:validate => false) instead of save(false)
12 years ago
Martin Linkhorst 7d9f3cd148 DEPRECATION FIX: this plugin brings back the old verify functionality in the controllers (for the meantime)
12 years ago
Martin Linkhorst b51227a960 DEPRECATION FIX: new way of resetting the javascript expansions
12 years ago
Martin Linkhorst 71fe49e862 DEPRECATION FIX: use validate :method_name instead of overwriting the validate method
12 years ago