openproject

Commit Graph

Author	SHA1	Message	Date
ulferts	a4c8fa75bb	add ability to activate inline edit fields via keyboard (#4405 ) Allows tabbing on the inline edit field. https://community.openproject.com/work_packages/23076/activity I feel that one scenario is still not supported the way it should be. If the user presses the "ESC" key while being in an inline edit input, the input disappears and the text representation is displayed as desired. But the focus is not placed on the text so it becomes hard to reactivate the field as the user has to start the tabbing journey anew. I couldn't get this to work as the field can only be focused after it reappears.	9 years ago
ulferts	4b8ec6dcf4	add ability to activate inline edit fields via keyboard (#4405 ) Allows tabbing on the inline edit field. https://community.openproject.com/work_packages/23076/activity I feel that one scenario is still not supported the way it should be. If the user presses the "ESC" key while being in an inline edit input, the input disappears and the text representation is displayed as desired. But the focus is not placed on the text so it becomes hard to reactivate the field as the user has to start the tabbing journey anew. I couldn't get this to work as the field can only be focused after it reappears.	9 years ago
manuschiller	f0f09365d0	textile service adaption	9 years ago
manuschiller	6b1d45ac00	textile service adaption	9 years ago
Oliver Günther	141cbfa4e4	[22624] Display 'Open this work package in full screen' correctly (#4363 ) * Display 'Open this work package in full screen' correctly Currently, the 'Click here to open this work package in fullscreen view.' is not implemented correctly: 1. It is not only shown for update and create, but also delete in the table 2. It is not shown for inline create / edit 3. It is shown in full screen This reimplements the functionality without requring deep knowledge in NotificationsService. * Move NotificationsService * Move notification box directive * Move DetailsTabOverviewController	9 years ago
Alex Dik	116c4ec5c1	Refactor WP filter related components (#4348 ) * Implement WP filter button directive * Tidy up the WP inline create button controller * Reformat WP list route code * Move Filter model to components * Move filter constants to filters component directory * Move query filters directive * Move query filter directive * Add filter container directive Vote furinvader for less copy pasta! * Refactor filter visibility code * Move filters helper * Move query model service * Make the query service a part of the filters module * Remove getFilterCount test from WP list controller * Fix query model module import * Fix karma tests Importing Angular modules within the test files is not possible yet. * Move filter visibility to a dedicated service * Get rid of the FiltersHelper service	9 years ago
Oliver Günther	42cb4a7a78	Show inline-create in global work package list (#4340 ) When no project context is available, this fetches the `available_projects` endpoint and suggests using the first project for creating a new row.	9 years ago
Oliver Günther	02cf2b0efe	[22851] Table Inline Create (#4290 ) * Move the WP create button to the WP buttons directory * Move the keepTab service to the wp-panels directory * Move angular module definitions into separate file * Move the WP create button into a separate file * Use TS in WP create button directive * Refactor the WP create button controller * Move the has-context-menu directive to the components directory * Refactor has-context-menu item focus * Create new button directive and place in table * Export and use wpButton module * Add title to form properties * Add -new modifier to new work package rows * Add WP inline create directive * Reduce error widths to cell span * Save or update work package conditionally * Mark work package as new * Implement the WP inline create button * Style button correctly * Decide when to activate the field for new WPs * Remove padding on -new row * Avoid animation on added -new rows * Avoid writing title when passed from new workPackage * Remove jqMigrate warning * Avoid animations for newly added rows * Add cancel button to inline create row * Track new work packages by custom id If we don't track new work packages, ng-animate will freak out due to the track by expression. We thus track work packages by setting a custom id set from the current date. * Disable focus on errors outside accessibility mode * Add inline create cancel context menu * Conditionally set focus on fields Set focus on the first active field	9 years ago
Oliver Günther	7be07f9a1c	Wrap $http for caching We'll need an option to disable caching for specific routes, or ideally, specify other means of caching requests. This commit adds: - A wrapper for $http to catch caching options passed through Restangular - An improved CacheService that can handle loading promises (previously, it interfaced only to Resources)	9 years ago
Jens Ulferts	374fcb479f	add specific formatting	9 years ago
Jens Ulferts	d67b7fe6fc	extend focus js to all focusable elements	9 years ago
Alex Dik	caf347b31f	Move query service to components	9 years ago
Oliver Günther	3ac7490c01	Fix static paths of Frontend PathHelper	9 years ago
Jens Ulferts	e6c5601953	have "copy" shown in the work package menu	9 years ago
Alex Dik	d36099f6ca	Implement wpActivity service Move the main logic into this service instead of having it in the controller.	9 years ago
Alex Dik	c299311eee	Move watchers service to panels component	9 years ago
Alex Dik	01d8e9c1b5	Get create WP permission via HAL resource links	9 years ago
Alex Dik	c8d77db1f8	Move auth service to components directory	9 years ago
Oliver Günther	955c1194f2	Add definingProject as group to version	9 years ago
Jens Ulferts	e09f3251ad	ensure to always have only one error/success notification	9 years ago
Alex Dik	a6170eb164	Move WorkPackageService to new components location	9 years ago
Oliver Günther	c6a01459a4	Split view: Add watch, unwatch buttons	9 years ago
Jens Ulferts	7577385057	first stab at updating form on type switch	9 years ago
Oliver Günther	bd1247d376	Strip notify from frontend The option to save and send mail for a work package attribute has been removed in https://github.com/opf/openproject/pull/3689. However, some pieces of that implementation remained: 1. The comment field still had the third notify button 2. Several directives and the `WorkPackageService` processed the notification field.	9 years ago
Oliver Günther	1d789b0fba	Globally disable CachService in run block Avoid checking the state of the cache in every resource loading, but rather disable it upon startup.	9 years ago
Oliver Günther	ce759d3725	Allow more than one cache	9 years ago
Oliver Günther	0b77d9a389	Disable CacheService for testing	9 years ago
Oliver Günther	d3d6cd60ee	Temporarily store promises until they are resolved The original commit simply stored promises into the cache, which seemed to work in browsers but failed with karma/PhantomJS. I'm not yet certain why that is, but I wanted to get rid of complex objects in sessionStorage anyway, so this commit does: * temporarily store running promises for a given key * cache the resolved data directly	9 years ago
Oliver Günther	64d5b399c5	Experiment with angular-cache One prominent example where we can employ frontend-side caching is the fetching of associated users in activities. For a large number of comments of the same user, that user is retrieved once per activity, which causes a drastic overhead. This commit introduces a simple wrapper around angular-cache to store values in the sessionStorage.	9 years ago
Oliver Günther	868671475c	Use correct manual work package form path The new controller builds its own API resource using the static `/projects/:identifier/work_packages/form` path, which was expanded with the `/api/v3` prefix until `0c768829e7`. With this commit, the resource was invalid and causes new work packages to be broken. In order to restore the manual path, a new path helper was created.	9 years ago
Alexander Bach	cb890e60ac	Added addNotice for consistency	9 years ago
Jens Ulferts	0c768829e7	rely on fully qualified uris for HALAPI As we should more and more rely on the links provided by the API, it makes less and less sense to construct the urls by ourselves. We can simply use the links, the api offers. There are still a lot of places that construct the uri manually. The HALAPIRessource adds to that manual construction by adding [appBasePath] + /api/v3 to every path provided to it. The callers do now have to care for that. The current callers have been altered so that they do by relying on the PathHelper which should reduce the places in which uris are constructed.	9 years ago
Oliver Günther	9ad48023ed	Always allow attachment upload for new work packages `af73d60773` introduced a check whether the work package contains a link addAttachment (i.e., the user is allowed to :edit_work_packages). For new work packages, this link is not available, thus we need to provide some alternative as for now, when adding work packages it is always possible to add attachments (given the :add_work_packages permission).	9 years ago
Stefan Botzenhart	4e3a0050ec	Provide bulk destroy functionality for work package This is considered to be hacky and needs to be removed soonest.	9 years ago
Tim Habermaas	8554125f63	Move isInitialActivity to ActivityService.	9 years ago
Jens Ulferts	4bfc4cc8b2	sort versions case insensitive	9 years ago
Jens Ulferts	38cc9ff716	remove outdated comment	9 years ago
Oliver Günther	de96916dac	Minor corrections This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Henriette Dinger	27c60cf667	Incorporate review feedback * Notification when comment is created * Better binding to editing comments * Quote with inserted text fixed	9 years ago
Oliver Günther	51509e6b34	Editing of comments with in-place button styles and preview This commit changes the comment edit and cancel buttons to reflect the in-place editing style. Also allows previewing of edited comments and also shows a notification-box when comments are edited.	9 years ago
Oliver Günther	0aed8bb310	Test for comment input	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Oliver Günther	528e2f92e2	Load preselected work package when required	9 years ago
Florian Kraft	07058738a1	handle injections to watchers service properly and add tests Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64daddf767	remove dead code and provide helpers for the array sets Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	64ba83a718	make watchers removable Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	f47418de07	provide a method of adding watchers Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	6025a1b0e5	add a lookup directive Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Florian Kraft	3ff36d9247	prepare the directives and load both available and watching users Signed-off-by: Florian Kraft <f.kraft@finn.de>	9 years ago
Jens Ulferts	f4b820553a	allows for creating error notifications with only an error message	9 years ago

1 2 3 4

158 Commits (b63151c26529de066681e4eb52f27d96da610eb8)