3828 Commits (b9756f6f71a47998a3e08f4802152940b082b3b4)

Author	SHA1	Message	Date
Stefan Botzenhart	0ede6db03c	Revert "Allow to make "read only" values using the form builder" ... This reverts commit 21fd0465ce.	9 years ago
Jan Sandbrink	85f60d8bbc	Also allow to add attachments to a WP with permission to add WPs ... This is neccessary to allow adding attachments, after creating a new work package. The undesired part is, that it also allows you to add attachments long after creating the WP.	9 years ago
Oliver Günther	7d77bef80e	Account for remote repositories in SCM rake task	9 years ago
Mohamed Wael Khobalatte	d2349cf819	Delete Redmine's safe_attributes implementation ... It was an early implementation of strong_parameters, more or less. Going forward, we should strive to make the whitelisting of attributes a controller responsibility only.	9 years ago
Mohamed Wael Khobalatte	972b04d86e	Refactor to allow for strong params ... We no longer need attr_accessible.	9 years ago
Peter Lehwess	95434810aa	Revert change that was causing specs to fail	9 years ago
Jan Sandbrink	21fd0465ce	Allow to make "read only" values using the form builder	9 years ago
Jan Sandbrink	ae6655d0bb	Use div rather than span for containers ... - blocks display will be applied anyway - LSG specifies it as div	9 years ago
Oliver Günther	abb2a2757a	Set migration_paths explicitly from config ... Turns out that `ActiveRecord::Migrator.migrations_paths` may contain a relative path to the migrations under `db/migrate`, while `app.config.paths['db/migrate']` contains an absolute one. Let's set these paths from config explicitly.	9 years ago
Oliver Günther	28de164715	Pass migration paths to migration helpers ... In its current implementation, our plugins (Rails engines) automatically append their migration paths to the root application `config['db/migrate']`. This procedure works fine unless using a chained rake command, such as `db:create db:migrate db:seed` due to the migration paths simply not being updated timely. The following simple fix extends the OP engine class to set the migration paths of both `ActiveRecord::Tasks::DatabaseTasks` and `ActiveRecord::Migrator` to the union of the existing paths and the root config after migration paths of a plugin were added. This should effectively fix the chaining issue.	9 years ago
Stefan Botzenhart	150af855f0	Remove unused ci rake tasks	9 years ago
Oliver Günther	b7465b08a6	Remote managed repositories ... This commit starts the work to provide functionality with remote service hooks for managing repositories. The main driver behind this is packager, for which we want apache to be the sole owner of the repositories it delivers, and OpenProject only as a reader, however it benefits other installations as well.	9 years ago
Oliver Günther	acb4431d8a	Implement UserPreferences endpoint ... Provides the implementation to the user preferences endpoint.	9 years ago
Oliver Günther	319c728b1a	Core notifications to alleviate third-party plugins ... This commit provides some helpers to alleviate SCM vendor plugins: * Provide code notifications when project, members and users are changed. * Allow Repository:* to determine base URL themselves (when no common URL is available) * Open Git adapter for subclassing (Gitolite)	9 years ago
Oliver Günther	c5a33fc4fa	[ci skip] Remove reposman functionality. ... This commit removes the functionality provided by reposman.rb, and replaces that script with an empty placeholder printing only a deprecation warning (as to not throw errors in existing cronjobs). In detail, this commit does: * replace reposman.rb with an script printing a deprecation only. * Remove repositories creation API in SysController and corresponding specs * Update documentation guides concerning the deprecation of reposman * Remove packager scripts for creating a reposman.rb cronjob. * Adds a rake task to migrate repositories to managed type with a common * URL prefix.	9 years ago
Oliver Günther	cd7ec57ee6	Empty check for newer Git versions ... Git recently introduced a new format for outputting warnings on empty repositories in ce11360467 This commit extends the empty test for this output	9 years ago
Alexander Bach	faaf5245a9	Allow classless field wrapping	9 years ago
Mohamed Wael Khobalatte	8194f4a850	Silence the 10 slowest specs notice by default. ... The numbers do not change regularly, therefore it should be opt-in.	9 years ago
Stefan Botzenhart	0af30a1990	Remove rake spec:core task as it is not required any longer	9 years ago
Stefan Botzenhart	f7db95d9fb	Cleanup testing tasks ... * spec runs spec:core * suite runs cukes, specs and legacy specs	9 years ago
Stefan Botzenhart	785561c63f	Adjust spec:legacy task to actually run legacy specs	9 years ago
Jens Ulferts	4ed191d659	removes duplicate safeguard for polymorphic association ... The 'journable_type' check is added by AR itself because of the polymorphic association (:as=>:journable)	9 years ago
Jonas Heinrich	7efc4f20e5	Adapt version to corresponding OpenProject core version.	9 years ago
Jonas Heinrich	55ea257f21	Also override cache config when set to file_store	9 years ago
Jonas Heinrich	d9c5290b75	Set directory for file_store cache	9 years ago
Oliver Günther	93356d1173	Add version rake task ... Because why not? [ci skip]	9 years ago
Jens Ulferts	757f6a53d7	eager load preference to avoid N+1 queries	9 years ago
Jan Sandbrink	067f903008	Resolve stackoverflow ... new_connection -> our patch -> determine adapter type -> ActiveRecord::Base.connection -> new_connection	9 years ago
Jan Sandbrink	aaf4637138	Ensure that concurrent version updates play well together	9 years ago
Jan Sandbrink	58aa36ae2a	Check for nil representers explicitly ... Passing nil as model into a representer happens usually only due to an error. If a subclass needs to be able to pass nil as represented, it can specify that by overrding. This however, should be an exception, not the rule.	9 years ago
Oliver Günther	de96916dac	Minor corrections ... This commit addresses the following minor corrections from review: 1. Remove constant URI: It breaks karma, and I can't really tell why 2. Avoid using Object.values Appeared to be supported by chrome, but causes the protractor failure. This also switches the ordering to binary (unshift, push) as that's all we need for now. 3. Remove location.hash when jumping to element `$location.hash` may take precedence over `scrollIntoView` ocassionaly, thus we forcefully remove the location hash when updating the work package on a particular field 4. Avoid showing comment success when empty When opening the comment field, and then submitting on another field with comment being empty and open, the comment was not submitted, but a successful comment notification was still sent. 5. Fix issues for IE 10+ * Force min-height to be set on the element, as IE tends to return 0 as height when empty 6. Misc. * Avoid undefined in comment text * Avoid resizing [msd-elastic] textareas * Rename `add_journal` to `create_journal` Correct wrong bracket for reject function	9 years ago
Oliver Günther	3ca36e1e1d	Parallel sending of comment and fields in WP split view ... Parallel submitting of comments alongside WP edits wasn't possible natively due to the increased lock_version in work packages, caused by `touch`ing and explicitly saving the work package in the process of adding a journal. This commit works around this issue by updating the timestamp columns directly, bypassing optimistic locking in the work package table. This allows comments to be submitted transparently with other fields to the user, while actually, we send it in two subsequent steps.	9 years ago
Oliver Günther	0883cf9834	Replace exclusive-edit with transcluded comment directive ... This commit removes the somewhat superfluous exlusiveEditController in favor of event-based passing of quoted text to the correct comment field. The comment directive now decides for itself whether it wants to be placed above or below the activities and uses transclusion for that purpose. Editing comments is now no longer exlusive, but that shouldn't be necessary anyway.	9 years ago
Oliver Günther	3bfad28db0	Correct comment behavior with optional notifications ... This allows submitting comments with and without notification for the created journal. Using hyperagent resource on activities, the resource `addComment` is replaced when executing `fetch` on the link. This breaks subsequent comment requests. This is fixed by requesting manually on the resource link using `$http`. This commit also provides the functionality required to comment with or without notification propagation, and changes the backend to comply to the APIv3 specification, which defines comments to be sent as a JSON `{ comment: { raw: 'my comment' } }`. This commit also provides: * Displaying the comment input on overview depending on sort setting * Disable inplace controls when comment is empty * correctly hiding the comment based on link availability	9 years ago
Jan Sandbrink	caf6ec07c7	Use SetLocalizationService in LocaleHelper	9 years ago
Jonas Heinrich	2d9adfd43e	Adapt version to corresponding OpenProject core version.	9 years ago
Jonas Heinrich	c513f09984	Small refactoring	9 years ago
Jonas Heinrich	636acde29e	Make method more tolerant	9 years ago
Jonas Heinrich	0542580620	Don't change cache store if already present	9 years ago
Oliver Günther	e41b8aafee	Add rake task to identify unassociated repositories ... This commit adds a rake task to identify and list repositories in the current managed path that do not have an associated project. [ci skip]	9 years ago
Alex Coles	ddbbecdc3a	Add path helper shim to support :only_path option ... `:only_path` is deprecated. Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Jens Ulferts	95aee32a41	fix project permission condition in activity ... Without the #flatten, the arel visitor casts the two arrays to NULL.	9 years ago
Markus Kahl	ac8a096488	polish considering remarks through review and houndci	9 years ago
Markus Kahl	3a3ff0b102	actually unsubscribe cleared subscriptions	9 years ago
Markus Kahl	45153a5d1b	dummy LDAP auth source ... I don't care if we have a company LDAP. My thoughts go out to devs* who don't have that. *OpenSource, right?	9 years ago
Markus Kahl	2ce62e3999	user invitation polish	9 years ago
Markus Kahl	43e18dd00c	switch to user invitation by default ... this changes quite many flows. With this user self registration is a separate flow to what happens when an admin creates a user. Users created by admins are 'invited' instead of 'registered'.	9 years ago
Alex Coles	2f659e76a9	Fix deprecated Model.exists? arg in UpdateContract ... Signed-off-by: Alex Coles <alex@alexbcoles.com>	9 years ago
Oliver Günther	fecd3b3b3e	Simple API for managing the homescreen content ... This commit alleviates the homescreen management from both core and plugins, in order to simply add and remove blocks. Also contains refactoring from review * Consistent block and variable usage * Removed unused labels * Avoid word breaks in multiline enumerations and remove margin from enumerations	9 years ago
Jan Sandbrink	4ee163393f	Rearrange mail delivery responsibilities ... - each delivery job delivers only a single mail (like in the past) - a common super-class ensures correct handling of different error conditions (similar to the past) This new structure should allow for an efficient error handling: - fail the mail delivery on a per-recipient basis (i.e. redeliveries on error only affect the user that did not receive a mail) - only fail the delayed job for delivery errors (e.g. network issues, etc) - do not fail the delayed job for rendering errors (which are likely to re-occur on each rendering) -> only log those	9 years ago